Refine typed Rust lifecycle API - #1255
Open
Gudge (MGudgin) wants to merge 1 commit into
Open
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
This PR refines the direct typed Rust lifecycle surface around explicit sandbox operations while preserving the exact JSON compatibility lane. Details * Group typed provision, start, exec, stop, and deprovision calls under `mxc_sdk::sandbox`. * Add an opaque `SandboxId` and pass identity separately from typed policy. * Move experimental authorization and telemetry preference into `OperationOptions`. * Return distinct `ProvisionResult`, `LifecycleResult`, and `ValidationResult` types. * Add explicit validation entry points instead of mixing dry-run outcomes into successful operation results. Tests * `cargo fmt --all -- --check` * `cargo test -p mxc_engine --all-features` * `cargo test -p mxc-sdk --all-features` * `cargo test -p mxc-sdk --doc --all-features` * `cargo clippy -p mxc_engine -p mxc-sdk --all-targets --all-features --no-deps -- -D warnings` * `git diff --check` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d91874d-feea-4a33-b183-67d506ae61b5 Generated-with: gpt-5.6-sol
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 23, 2026
Gudge (MGudgin)
added this pull request to stack #1257
September 23, 2026 22:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR refines the direct typed Rust lifecycle transport into an
operation-centric public API under
mxc_sdk::sandbox.Details
sandbox::{provision,start,exec,stop,deprovision}and matchingvalidate_*functions.SandboxIdand keep sandbox identity separate frompolicy and operation options.
are not representable through one broad request type.
structure.
This is PR 2 of 3 in the state-aware operation API stack.
🔗 References
🔍 Validation
cargo fmt --all -- --checkmxc_engineandmxc-sdktests passed.mxc-sdkRustdoc tests passed.--no-deps -D warnings.git diff --check✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow