Move lifecycle routing to executor arguments - #1256
Open
Gudge (MGudgin) wants to merge 2 commits into
Open
Gudge (MGudgin) wants to merge 2 commits into
Gudge (MGudgin) wants to merge 2 commits into
Conversation
This PR changes the state-aware executor transport so lifecycle operation and existing sandbox identity are passed as command-line arguments while the raw exact JSON APIs retain their phase-bearing contracts. Details * Add `--operation` and `--sandbox-id` routing to `wxc-exec` and reject lifecycle routing fields supplied in executor-bound JSON. * Preserve exact phase-specific parsing by overlaying CLI routing onto a source-preserving temporary document before normalization. * Update the Node lifecycle SDK and architecture documentation for the new executor transport without changing raw exact API compatibility. Tests * Passed Rust formatting, `wxc_common`, `wxc`, all-feature `mxc_engine` and `mxc-sdk` tests, Rustdoc, and changed-crate clippy with warnings denied. * Passed Node SDK tests, 60 versioning tests and all schema/codegen/config gates, and 323 .NET tests with 27 backend-dependent skips. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d91874d-feea-4a33-b183-67d506ae61b5 Generated-with: gpt-5.6-sol
This PR updates the state-aware lifecycle walkthrough so executor-bound JSON omits operation and sandbox identity and shows their command-line routing. Details * Remove `phase` and `sandboxId` from the five executor payload examples. * Show the matching `--operation` and `--sandbox-id` arguments for each call. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d91874d-feea-4a33-b183-67d506ae61b5 Generated-with: gpt-5.6-sol
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 23, 2026
Gudge (MGudgin)
added this pull request to stack #1257
September 23, 2026 22:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR moves state-aware lifecycle routing out of executor-bound JSON and into
explicit
wxc-execcommand-line arguments. Raw exact JSON APIs continue touse their registered phase-bearing contracts.
Details
--operation provision|start|exec|stop|deprovisiontowxc-exec.--sandbox-idfor non-provision lifecycle operations.temporary source document before exact parsing and normalization.
phaseandsandboxIdfields instead of silentlyoverriding them.
This is PR 3 of 3 in the state-aware operation API stack.
🔗 References
🔍 Validation
wxc_common,wxc, all-featuremxc_engineandmxc-sdktests, Rustdoc, and changed-crate clippy passed.
git diff --check✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow