Repository navigation
fix(clone): finish renaming actionMode Automatic to Autonomous - #377
Open
jlinenkohl wants to merge 1 commit into
Open
jlinenkohl wants to merge 1 commit into
jlinenkohl wants to merge 1 commit into
Conversation
0b900d8 changed the Bicep @allowed list from ['Review', 'Automatic'] to ['Review', 'Autonomous'], but clone-agent.sh was not updated with it. The two halves now disagree, and between them they reject every value except Review: --action-mode Autonomous rejected by clone-agent.sh, which still validates against the old name --action-mode Automatic accepted by clone-agent.sh, then rejected by the template at deploy time as not in @allowed The safety warning at the High access level is tied to the same literal, so it silently stopped firing for exactly the configuration it exists to warn about: an agent that can act without human approval. This updates the validation, the usage text, the error message and the warning to the current name. The old spelling is still accepted and mapped forward, so an export taken before the rename keeps working rather than failing validation. The remaining Automatic references are a different parameter, defaultModelName, and are deliberately untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0b900d8 changed the Bicep Myouki (@allowed) list from ['Review', 'Automatic'] to ['Review', 'Autonomous'], but clone-agent.sh was not updated with it. The two halves now disagree, and between them they reject every value except Review:
--action-mode Autonomous rejected by clone-agent.sh, which still validates
against the old name
--action-mode Automatic accepted by clone-agent.sh, then rejected by the
template at deploy time as not in Myouki (@allowed)
The safety warning at the High access level is tied to the same literal, so it silently stopped firing for exactly the configuration it exists to warn about: an agent that can act without human approval.
This updates the validation, the usage text, the error message and the warning to the current name. The old spelling is still accepted and mapped forward, so an export taken before the rename keeps working rather than failing validation.
The remaining Automatic references are a different parameter, defaultModelName, and are deliberately untouched.