Skip to content

fix(clone): finish renaming actionMode Automatic to Autonomous #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlinenkohl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(clone): finish renaming actionMode Automatic to Autonomous #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions sreagent-templates/bin/clone-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Optional:
--target-resource-groups Comma-separated RGs the clone should monitor
--subscription Target subscription (default: current az account)
--access-level Override access level (High/Low)
--action-mode Override action mode (Review/Automatic)
--action-mode Override action mode (Review/Autonomous)
--override key=value override (repeatable). e.g.:
--override connectors.0.properties.dataSource=/subscriptions/.../new-ai
--backend Deploy backend: bicep (default) or terraform
Expand Down Expand Up @@ -252,10 +252,16 @@ if [[ "$NEW_ACCESS" == "High" || "$NEW_ACCESS" == "Low" ]]; then
else
_err "Invalid access level '${NEW_ACCESS}' — must be High or Low"
fi
if [[ "$NEW_ACTION" == "Review" || "$NEW_ACTION" == "Automatic" ]]; then
# "Automatic" was renamed to "Autonomous" in the Bicep @allowed list, but this validation
# was not updated with it, so --action-mode Autonomous was rejected here while
# --action-mode Automatic was accepted here and then rejected by the template at deploy
# time. Only Review worked at all. The old spelling is still accepted and mapped forward,
# so an export taken before the rename keeps working.
[[ "$NEW_ACTION" == "Automatic" ]] && NEW_ACTION="Autonomous"
if [[ "$NEW_ACTION" == "Review" || "$NEW_ACTION" == "Autonomous" ]]; then
_ok "Action mode: ${NEW_ACTION}"
else
_err "Invalid action mode '${NEW_ACTION}' — must be Review or Automatic"
_err "Invalid action mode '${NEW_ACTION}' — must be Review or Autonomous"
fi

echo
Expand Down Expand Up @@ -417,8 +423,8 @@ else
fi

# 4e. Access level + action mode coherence
if [[ "$NEW_ACCESS" == "High" && "$NEW_ACTION" == "Automatic" ]]; then
_warn "accessLevel=High + actionMode=Automatic — agent can take actions WITHOUT human approval. Make sure this is intentional"
if [[ "$NEW_ACCESS" == "High" && "$NEW_ACTION" == "Autonomous" ]]; then
_warn "accessLevel=High + actionMode=Autonomous — agent can take actions WITHOUT human approval. Make sure this is intentional"
fi

# 4f. Feature flags — check if source agent had workspace tools + v2 loop enabled
Expand Down
Loading