Repository navigation
Fix published diagram URLs under slides/diagrams - #10
Merged
Merged
Conversation
LaMD CIP-0010 was falling back to /mlai/diagrams/ because diagramsdir pointed at a shared library outside the repo. Point diagramsdir at the in-repo tree and set diagramsurl so rebuilt lectures keep working SVGs.
This lecture was part of the same diagram-path fix but was left out of the previous commit to avoid the stray hyphenated junk copies.
Keep published HTML under slides/diagrams via diagramswebpath so CIP-0010 does not fall back to /<course>/diagrams/.
The names are easy to mix: diagramsdir is the filesystem copy source, diagramswebpath is the published URL path, and slidesdir is where HTML and copied figures land.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagramsdirat../slides/diagramsand setdiagramsurlso CIP-0010 does not fall back to/mlai/diagrams/.Test plan
slides/01-intro-probability.slides.html) and confirm diagramsrcishttps://mlatcl.github.io/mlai/slides/diagrams/...._lamd.ymlhasdiagramsdir: ../slides/diagrams/anddiagramsurlset.02-the-data-science-process) rebuilt as well.