Repository navigation
chore(deps): bump the other-dependencies group across 2 directories with 3 updates - #1106
Conversation
There was a problem hiding this comment.
Nice one — the Gradle security patch and both library bumps check out, so this is good to merge.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=297df783-ac2a-44c3-9975-33a3a813a4f1
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.1-bin.zip |
There was a problem hiding this comment.
Problem: this PR moves only 2 of the 6 Gradle wrapper copies in the repo to 9.8.1. gradle/wrapper/gradle-wrapper.properties (root) and samples/{kotlin-mcp-server,simple-streamable-server,weather-stdio-server} stay on 9.8.0, and the four stale gradle-wrapper.jar files are still byte-identical to the old 9.8.0 jar (238e777f…) while the two updated ones are 3b8a2577…. Dependabot has historically bumped the root wrapper in its own PR (#1023, #969, #949 …), but no such PR exists for 9.8.1 — it appears to have been folded into this group PR for the samples directories only, so the root copy will not self-heal.
Failure scenario: 9.8.0 is the release Gradle flagged for three high-rated advisories, including GHSA-j5m7-59rp-24f5 (a repository that fails to establish an SSL connection is not disabled, so a build can be served malicious artifacts). After this merges, build.yml, conformance.yml and — most importantly — gradle-publish.yml, which runs ./gradlew publishToMavenCentral for the released SDK, all still execute Gradle 9.8.0. The PR title reads as a repo-wide wrapper bump, so the gap is easy to miss.
Suggested fix: in the repository root and in each of the three remaining sample directories, run ./gradlew wrapper --gradle-version=9.8.1 twice (Gradle needs the second invocation to rewrite the wrapper jar), and include those four gradle-wrapper.properties + gradle-wrapper.jar pairs here or in an immediate follow-up PR.
| serialization = "1.11.0" | ||
| coroutines = "1.11.0" | ||
| logback = "1.6.4" | ||
| logback = "1.6.5" |
There was a problem hiding this comment.
Problem: kotlinlang-mcp-server is not in the samples.yml build matrix (it lists only kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server) and no other workflow references it, so this logback bump — and the wrapper bump alongside it — is never compiled before merge. Half of this PR ships on review alone.
Failure scenario: a dependency bump to this sample that does break compilation merges green and lands on main undetected; the only consumers who find out are users who clone the sample or build its Dockerfile. (For this particular bump the risk is nil: 1.6.5's behaviour change is confined to MDCBasedDiscriminator/SiftingAppender, and src/main/resources/logback.xml uses only a ConsoleAppender — but that was verified by hand, not by CI.)
Suggested fix: add - kotlinlang-mcp-server to the strategy.matrix.sample list in .github/workflows/samples.yml so the directory is covered by ./gradlew build like the other four samples.
|
@dependabot rebase |
…ith 3 updates Bumps the other-dependencies group with 2 updates in the /samples/kotlin-mcp-client directory: [gradle-wrapper](https://github.com/gradle/gradle) and [com.anthropic:anthropic-java](https://github.com/anthropics/anthropic-sdk-java). Bumps the other-dependencies group with 2 updates in the /samples/kotlinlang-mcp-server directory: [gradle-wrapper](https://github.com/gradle/gradle) and [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback). Updates `gradle-wrapper` from 9.8.0 to 9.8.1 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.0...v9.8.1) Updates `com.anthropic:anthropic-java` from 2.65.0 to 2.71.0 - [Release notes](https://github.com/anthropics/anthropic-sdk-java/releases) - [Changelog](https://github.com/anthropics/anthropic-sdk-java/blob/main/CHANGELOG.md) - [Commits](anthropics/anthropic-sdk-java@v2.65.0...v2.71.0) Updates `gradle-wrapper` from 9.8.0 to 9.8.1 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.0...v9.8.1) Updates `gradle-wrapper` from 9.8.0 to 9.8.1 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.0...v9.8.1) Updates `gradle-wrapper` from 9.8.0 to 9.8.1 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.0...v9.8.1) Updates `ch.qos.logback:logback-classic` from 1.6.4 to 1.6.5 - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.6.4...v_1.6.5) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-version: 1.6.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-dependencies - dependency-name: com.anthropic:anthropic-java dependency-version: 2.71.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: other-dependencies - dependency-name: gradle-wrapper dependency-version: 9.8.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-dependencies - dependency-name: gradle-wrapper dependency-version: 9.8.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-dependencies - dependency-name: gradle-wrapper dependency-version: 9.8.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-dependencies - dependency-name: gradle-wrapper dependency-version: 9.8.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
72daf41 to
3d79a1a
Compare
Bumps the other-dependencies group with 2 updates in the /samples/kotlin-mcp-client directory: gradle-wrapper and com.anthropic:anthropic-java.
Bumps the other-dependencies group with 2 updates in the /samples/kotlinlang-mcp-server directory: gradle-wrapper and ch.qos.logback:logback-classic.
Updates
gradle-wrapperfrom 9.8.0 to 9.8.1Release notes
Sourced from gradle-wrapper's releases.
... (truncated)
Commits
39daf39Release notes for Gradle 9.8.1 (#39409)4fc92e5Release notes for Gradle 9.8.1bfbd14aMake repository disabling stricter (#39403)95e0bf9Check daemon & worker preamble earlier (#39402)7aa9a5bImprove display for distribution url in wrapper (#39401)74a7720Wrap GCP & S3 resolution errors into HTTP to reuse repository disabling mecha...651110aCheck worker token before any serialization similarly to daemon8a6b9d9Harden repository disabling: disable them by default on failure unless there'...f28e514Check the daemon token before any serialization86ab273Replace credentials for distribution url with *** and avoid showing the plain...Updates
com.anthropic:anthropic-javafrom 2.65.0 to 2.71.0Release notes
Sourced from com.anthropic:anthropic-java's releases.
... (truncated)
Changelog
Sourced from com.anthropic:anthropic-java's changelog.
... (truncated)
Commits
59079f0release: 2.71.0d36653aMerge pull request #368 from anthropics/synced/published3d732f6chore(internal): remove unused structured output test helpers (#371)f96bb50feat(api): add workflows, multiagent configuration and thread status filterin...857cf41codegen metadatab437458codegen metadata06157d8feat(client): add options() to read a client's configured options4000ceafeat(client): accept nested union values in single-argument factories20f557dcodegen metadataeafe43bcodegen metadataUpdates
gradle-wrapperfrom 9.8.0 to 9.8.1Release notes
Sourced from gradle-wrapper's releases.
... (truncated)
Commits
39daf39Release notes for Gradle 9.8.1 (#39409)4fc92e5Release notes for Gradle 9.8.1bfbd14aMake repository disabling stricter (#39403)95e0bf9Check daemon & worker preamble earlier (#39402)7aa9a5bImprove display for distribution url in wrapper (#39401)74a7720Wrap GCP & S3 resolution errors into HTTP to reuse repository disabling mecha...651110aCheck worker token before any serialization similarly to daemon8a6b9d9Harden repository disabling: disable them by default on failure unless there'...f28e514Check the daemon token before any serialization86ab273Replace credentials for distribution url with *** and avoid showing the plain...Updates
gradle-wrapperfrom 9.8.0 to 9.8.1Release notes
Sourced from gradle-wrapper's releases.
... (truncated)
Commits
39daf39Release notes for Gradle 9.8.1 (#39409)4fc92e5Release notes for Gradle 9.8.1bfbd14aMake repository disabling stricter (#39403)95e0bf9Check daemon & worker preamble earlier (#39402)7aa9a5bImprove display for distribution url in wrapper (#39401)74a7720Wrap GCP & S3 resolution errors into HTTP to reuse repository disabling mecha...651110aCheck worker token before any serialization similarly to daemon8a6b9d9Harden repository disabling: disable them by default on failure unless there'...f28e514Check the daemon token before any serialization86ab273Replace credentials for distribution url with *** and avoid showing the plain...Updates
gradle-wrapperfrom 9.8.0 to 9.8.1Release notes
Sourced from gradle-wrapper's releases.
... (truncated)
Commits
39daf39Release notes for Gradle 9.8.1 (#39409)4fc92e5Release notes for Gradle 9.8.1bfbd14aMake repository disabling stricter (#39403)95e0bf9Check daemon & worker preamble earlier (#39402)7aa9a5bImprove display for distribution url in wrapper (#39401)74a7720Wrap GCP & S3 resolution errors into HTTP to reuse repository disabling mecha...651110aCheck worker token before any serialization similarly to daemon8a6b9d9Harden repository disabling: disable them by default on failure unless there'...f28e514Check the daemon token before any serialization86ab273Replace credentials for distribution url with *** and avoid showing the plain...Updates
ch.qos.logback:logback-classicfrom 1.6.4 to 1.6.5Release notes
Sourced from ch.qos.logback:logback-classic's releases.
Commits
d1b829dprepare release 1.6.5065b9b2enhance protectin against mischievious MDC values in MDCBasedDiscriminatorb69beabcomplete commit in relation to discussion_10327266c0bfix intermittently failing SocketAppenderMessageLossTest rest conditiona633bb0fix intermittently failing SocketAppenderMessageLossTest rest condition2bc5bccrenamed tbrp and eclosingTBRP, other minor changes2cd8762fix typo in AGENTS.md647846cfix errors when running tests under intellij IDEA1048917removed ConsoleCharsetPropertyDefiner.java39b5002added 'since' and 'forRemoval' attributes to SimpleInvocationGate@Deprecatio...