Repository navigation
chore(deps): bump the other-dependencies group across 2 directories with 3 updates #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [versions] | ||
| anthropic = "2.65.0" | ||
| anthropic = "2.71.0" | ||
| kotlin = "2.4.21" | ||
| ktor = "3.6.0" | ||
| mcp-kotlin = "0.15.0" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ ktor = "3.6.0" | |
| mcp-kotlin = "0.15.0" | ||
| serialization = "1.11.0" | ||
| coroutines = "1.11.0" | ||
| logback = "1.6.4" | ||
| logback = "1.6.5" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Problem: Failure scenario: a dependency bump to this sample that does break compilation merges green and lands on Suggested fix: add |
||
| shadow = "9.6.1" | ||
|
|
||
| [libraries] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: this PR moves only 2 of the 6 Gradle wrapper copies in the repo to 9.8.1.
gradle/wrapper/gradle-wrapper.properties(root) andsamples/{kotlin-mcp-server,simple-streamable-server,weather-stdio-server}stay on 9.8.0, and the four stalegradle-wrapper.jarfiles are still byte-identical to the old 9.8.0 jar (238e777f…) while the two updated ones are3b8a2577…. Dependabot has historically bumped the root wrapper in its own PR (#1023, #969, #949 …), but no such PR exists for 9.8.1 — it appears to have been folded into this group PR for the samples directories only, so the root copy will not self-heal.Failure scenario: 9.8.0 is the release Gradle flagged for three high-rated advisories, including GHSA-j5m7-59rp-24f5 (a repository that fails to establish an SSL connection is not disabled, so a build can be served malicious artifacts). After this merges,
build.yml,conformance.ymland — most importantly —gradle-publish.yml, which runs./gradlew publishToMavenCentralfor the released SDK, all still execute Gradle 9.8.0. The PR title reads as a repo-wide wrapper bump, so the gap is easy to miss.Suggested fix: in the repository root and in each of the three remaining sample directories, run
./gradlew wrapper --gradle-version=9.8.1twice (Gradle needs the second invocation to rewrite the wrapper jar), and include those fourgradle-wrapper.properties+gradle-wrapper.jarpairs here or in an immediate follow-up PR.