Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/kotlin-mcp-client/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[versions]
anthropic = "2.65.0"
anthropic = "2.71.0"
kotlin = "2.4.21"
ktor = "3.6.0"
mcp-kotlin = "0.15.0"
Expand Down
Binary file modified samples/kotlin-mcp-client/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.1-bin.zip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: this PR moves only 2 of the 6 Gradle wrapper copies in the repo to 9.8.1. gradle/wrapper/gradle-wrapper.properties (root) and samples/{kotlin-mcp-server,simple-streamable-server,weather-stdio-server} stay on 9.8.0, and the four stale gradle-wrapper.jar files are still byte-identical to the old 9.8.0 jar (238e777f…) while the two updated ones are 3b8a2577…. Dependabot has historically bumped the root wrapper in its own PR (#1023, #969, #949 …), but no such PR exists for 9.8.1 — it appears to have been folded into this group PR for the samples directories only, so the root copy will not self-heal.

Failure scenario: 9.8.0 is the release Gradle flagged for three high-rated advisories, including GHSA-j5m7-59rp-24f5 (a repository that fails to establish an SSL connection is not disabled, so a build can be served malicious artifacts). After this merges, build.yml, conformance.yml and — most importantly — gradle-publish.yml, which runs ./gradlew publishToMavenCentral for the released SDK, all still execute Gradle 9.8.0. The PR title reads as a repo-wide wrapper bump, so the gap is easy to miss.

Suggested fix: in the repository root and in each of the three remaining sample directories, run ./gradlew wrapper --gradle-version=9.8.1 twice (Gradle needs the second invocation to rewrite the wrapper jar), and include those four gradle-wrapper.properties + gradle-wrapper.jar pairs here or in an immediate follow-up PR.

networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
2 changes: 1 addition & 1 deletion samples/kotlinlang-mcp-server/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ktor = "3.6.0"
mcp-kotlin = "0.15.0"
serialization = "1.11.0"
coroutines = "1.11.0"
logback = "1.6.4"
logback = "1.6.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: kotlinlang-mcp-server is not in the samples.yml build matrix (it lists only kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server) and no other workflow references it, so this logback bump — and the wrapper bump alongside it — is never compiled before merge. Half of this PR ships on review alone.

Failure scenario: a dependency bump to this sample that does break compilation merges green and lands on main undetected; the only consumers who find out are users who clone the sample or build its Dockerfile. (For this particular bump the risk is nil: 1.6.5's behaviour change is confined to MDCBasedDiscriminator/SiftingAppender, and src/main/resources/logback.xml uses only a ConsoleAppender — but that was verified by hand, not by CI.)

Suggested fix: add - kotlinlang-mcp-server to the strategy.matrix.sample list in .github/workflows/samples.yml so the directory is covered by ./gradlew build like the other four samples.

shadow = "9.6.1"

[libraries]
Expand Down
Binary file modified samples/kotlinlang-mcp-server/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.1-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
Loading