Repository navigation
chore(deps): bump kotlin from 2.4.20 to 2.4.21 in /samples/kotlinlang-mcp-server - #1113
Conversation
There was a problem hiding this comment.
Clean patch-level bump — verified it compiles and resolves fine, so this is good to merge. 🙂
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=a8b76423-6a61-4545-aafa-78f656c63885
04322d3 to
edbe3b0
Compare
There was a problem hiding this comment.
Nice clean patch bump — verified it compiles, so this is good to merge once you've had a look at the one note below. 🙂
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=3f51d46f-9fd0-4a1f-9963-f143f8117781
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| kotlin = "2.4.20" | |||
| kotlin = "2.4.21" | |||
There was a problem hiding this comment.
Problem: kotlinlang-mcp-server is the only sample missing from the samples matrix in .github/workflows/samples.yml (which lists kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server). The checks on this PR confirm it: four Build Sample (...) jobs ran, none for the sample this PR actually changes. So this toolchain bump — and every future Dependabot bump to this directory — merges without ever being compiled or tested.
Failure scenario: The gap has already bitten. Building this sample locally, KotlinlangServerTest > server registers both tools with correct schema and annotations fails with McpException: Request timed out (Protocol.request resolving under runTest's virtual-time scheduler). It reproduces identically on 2.4.20 and 2.4.21, so it is not caused by this bump — it is pre-existing red on main that no CI job observes. (Caveat: my sandbox had no JDK 21, so I retargeted jvmToolchain(21) to JDK 25 with jvmTarget = 21; the other 55 tests passed on both versions.) The next bump that genuinely breaks compilation will land just as silently.
Suggested fix: Add - kotlinlang-mcp-server to the matrix in .github/workflows/samples.yml, then fix the timed-out test (give it a real dispatcher, or an explicit request timeout, instead of letting virtual time fast-forward the SDK's timeout) so the newly-enabled job starts green. Non-blocking for this bump itself.
|
@dependabot rebase |
edbe3b0 to
6a5eeb1
Compare
|
@dependabot rebase |
There was a problem hiding this comment.
Rebase looks good — the bump still compiles cleanly, so this is ready to merge whenever you are. 🙂
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=7662bbef-07fe-46a1-aa0e-e22f21f5271d
Bumps `kotlin` from 2.4.20 to 2.4.21. Updates `org.jetbrains.kotlin.jvm` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.plugin.serialization` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.jvm dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
6a5eeb1 to
4c6c42b
Compare
There was a problem hiding this comment.
Looks good to me — approving this one. 🙂
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=33089d73-2493-42e1-bc14-2753a9d6a306
Bumps
kotlinfrom 2.4.20 to 2.4.21.Updates
org.jetbrains.kotlin.jvmfrom 2.4.20 to 2.4.21Release notes
Sourced from org.jetbrains.kotlin.jvm's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin.jvm's changelog.
Commits
9180ce6Add changelog for 2.4.21-RC851077b[Serialization] Copy type parameter bounds onto generated serializers (#8421)1b6b624[Wasm]: Generate a Kotlin-level cast for bridged lambda functions. (#8404)3c223c2Rrr/2.4.20/core docs (#8322)c681c2e[2.4.20] [KT-89285] Stop the xcodebuild logs being output by default (#8277)f0645d1[2.4.20] [JS] ReorderCompilerConfigurationproperties initialization (#8282)f507ecd[JS] Don't try to initialize an external class's companion objectc60d7d8Reflection: fix NoSuchElementException in ConvertFromJava.kt05d1cdeREPL: render correct reflected binding type5acec47Scripting: store collected dependencies recursivelyUpdates
org.jetbrains.kotlin.plugin.serializationfrom 2.4.20 to 2.4.21Release notes
Sourced from org.jetbrains.kotlin.plugin.serialization's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin.plugin.serialization's changelog.
Commits
9180ce6Add changelog for 2.4.21-RC851077b[Serialization] Copy type parameter bounds onto generated serializers (#8421)1b6b624[Wasm]: Generate a Kotlin-level cast for bridged lambda functions. (#8404)3c223c2Rrr/2.4.20/core docs (#8322)c681c2e[2.4.20] [KT-89285] Stop the xcodebuild logs being output by default (#8277)f0645d1[2.4.20] [JS] ReorderCompilerConfigurationproperties initialization (#8282)f507ecd[JS] Don't try to initialize an external class's companion objectc60d7d8Reflection: fix NoSuchElementException in ConvertFromJava.kt05d1cdeREPL: render correct reflected binding type5acec47Scripting: store collected dependencies recursively