Skip to content

chore(deps): bump kotlin from 2.4.20 to 2.4.21 in /samples/kotlinlang-mcp-server #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devcrocod merged 1 commit into from
Oct 13, 2026
Merged

chore(deps): bump kotlin from 2.4.20 to 2.4.21 in /samples/kotlinlang-mcp-server #1113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/kotlinlang-mcp-server/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[versions]
kotlin = "2.4.20"
kotlin = "2.4.21"

@jetbrains-air jetbrains-air Bot Oct 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: kotlinlang-mcp-server is the only sample missing from the samples matrix in .github/workflows/samples.yml (which lists kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server). The checks on this PR confirm it: four Build Sample (...) jobs ran, none for the sample this PR actually changes. So this toolchain bump — and every future Dependabot bump to this directory — merges without ever being compiled or tested.

Failure scenario: The gap has already bitten. Building this sample locally, KotlinlangServerTest > server registers both tools with correct schema and annotations fails with McpException: Request timed out (Protocol.request resolving under runTest's virtual-time scheduler). It reproduces identically on 2.4.20 and 2.4.21, so it is not caused by this bump — it is pre-existing red on main that no CI job observes. (Caveat: my sandbox had no JDK 21, so I retargeted jvmToolchain(21) to JDK 25 with jvmTarget = 21; the other 55 tests passed on both versions.) The next bump that genuinely breaks compilation will land just as silently.

Suggested fix: Add - kotlinlang-mcp-server to the matrix in .github/workflows/samples.yml, then fix the timed-out test (give it a real dispatcher, or an explicit request timeout, instead of letting virtual time fast-forward the SDK's timeout) so the newly-enabled job starts green. Non-blocking for this bump itself.

ktor = "3.6.0"
mcp-kotlin = "0.15.0"
serialization = "1.11.0"
Expand Down
Loading