Repository navigation
fix(organizer): reconcile filename mode symlinks - #133
moderniselife merged 1 commit into
Conversation
|
Thanks @samtruman, this looks good to me. Comparing sources by realpath fixes the duplicate-link case for mount aliases, and the reconcile pass is nicely conservative: it only unlinks symlinks (never real files), skips dry runs, and only removes a link when the same source has a different desired target. CI is green; I've queued it for a final merge decision. |
|
Thanks for the review. I reproduced a separate runtime issue on provider-backed FUSE mounts: realpath() can block organizer startup/reconciliation when the remote is degraded. The focused correction is available in PR #136, which avoids realpath() for paths under the configured provider mount while preserving local-filesystem alias handling. PR #133 remains closed and is superseded by #136. |
Merge #136 into develop: avoid blocking FUSE I/O during symlink reconciliation. Retargeted from main (follow-up to #133, which lives in develop); conflict resolved keeping both FUSE non-blocking guards and collision-safe versioning. Thanks @samtruman.
Summary
When
ORGANIZER_FILENAME_MODEchanges between canonical and original release filenames, existing organized symlinks were left behind. In deployments where the same source is visible through different mount aliases, source identity could also be misclassified.This follow-up makes filename-mode changes converge safely:
realpathwhen available;This is generic organizer behavior and does not depend on any deployment-specific paths, compose files, or provider configuration.
Validation
git diff --check: passRelated to the filename-mode behavior introduced by #125.