Repository navigation
fix(build): the daemon-payload guard runs only on the tasks that produce the app - #10
Merged
Merged
Conversation
…uce the app The guard was attached to every task starting with "bundle" or "assemble", including AGP's intermediate bundleReleaseResources, which runs before mergeReleaseAssets stages the daemon. On a clean checkout the guard failed a build that was fine: the first main run of the beta workflow died with "Daemon payload missing". Locally the staged folder is left from earlier builds, so it never showed.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
mohitsoni48
had a problem deploying
to
play-alpha
October 31, 2026 09:40 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the first run of the merge-to-beta workflow on main (run #37): it failed with
Daemon payload missing: …/assets/daemon/dist/cli.js — the APK would boot to a crash, and nothing was published.Cause
composeApp/build.gradle.ktsattaches adoLastguard to every task whose name starts withassembleorbundle, to fail a build that has no daemon payload. That also matches Android Gradle Plugin's intermediate taskbundleReleaseResources, which runs beforemergeReleaseAssets, the taskstageDaemonAssetsis wired to. On a clean checkout (CI) the daemon is not staged yet at that point, so the guard fails a build that is fine. Locally the staged folder is left over from earlier builds, so it never showed.CI builds of the post-#8 code had not run before: the PR alpha runs have been waiting for owner approval since 26 Oct.
Fix
The guard now runs only on the tasks that produce the app:
assembleDebug,assembleRelease,bundleDebug,bundleRelease(the project has only thedebugandreleasebuild types and no flavors). By thenmerge*Assetshas staged the daemon, so a build that really lacks the payload still fails there.Not verified yet
This is a one-line matcher change confirmed from the failing run's log (the failing task was
bundleReleaseResources, the message is the guard's). It has not been built: a CI run needs approval, and a merge to main publishes a bundle to the Play beta track. The bundle that run produces is CPU-only (CI does not build the Vulkan engine).