Skip to content

fix(build): the daemon-payload guard runs only on the tasks that produce the app #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohitsoni48 merged 1 commit into from
Oct 31, 2026
Merged

fix(build): the daemon-payload guard runs only on the tasks that produce the app #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion composeApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,12 @@ tasks.matching { it.name.startsWith("merge") && it.name.endsWith("Assets") }.con

// A build that produced no payload would ship a broken app, so fail loudly at assemble time
// rather than at the user's first launch.
tasks.matching { it.name.startsWith("assemble") || it.name.startsWith("bundle") }.configureEach {
//
// Only the tasks that PRODUCE the app. A `startsWith("bundle")` match also caught AGP's intermediate
// bundleReleaseResources, which runs BEFORE mergeReleaseAssets stages the daemon: on a clean checkout (CI) the guard
// failed a build that was fine, and it never showed locally because the staged folder is left over from earlier builds.
val appPackagingTasks = Regex("(assemble|bundle)(Debug|Release)")
tasks.matching { appPackagingTasks.matches(it.name) }.configureEach {
doLast {
val cli = stagedDaemonAssets.file("dist/cli.js").asFile
if (!cli.exists()) {
Expand Down