Repository navigation
feat(hang)!: one continuous broadcast clock at the catalog root - #3675
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7435fdd23c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7435fdd to
36cfa43
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36cfa43806
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replaces Archive.timeline.wall with clock: { wall, timescale } advertised at
the catalog root, owned by the shared moq_mux::Clock. HLS program-date-time
and DASH availabilityStartTime map through it after timescale conversion.
Capture stamps from the catalog's advertised clock so HLS/DASH wall times match the root mapping. Reject wall times before the moq epoch and explicit null timescales instead of substituting defaults. Co-Authored-By: grok-4.6 <noreply@x.ai>
SourceMap rejects a mapped timestamp above u64 microseconds instead of wrapping. The JS clock schema matches Rust's u32 timescale bound. Co-Authored-By: grok-4.6 <noreply@x.ai>
36cfa43 to
c15b6cc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c15b6cc157
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Rebased onto current Codex findings:
(written by grok-4.6) |
Problem
The broadcast clock lived on the archive timeline section (
Archive.timeline.wall), so a live-only publisher had to create an archive timeline just to expose its clock, and every track carried a potentially competing wall epoch. There was no shared clock owner:timeline::Config.wallwas a passive timestamp and delayed first frames, source resets, and multi-timescale tracks had no consistent mapping.Approach
Advertise one fixed broadcast clock at the catalog root as
clock: { wall, timescale }, wherewallis PTS zero in clock timescale units since the MoQ epoch (2020-01-01T00:00:00Z). Every media track and the archive index refer to it after explicit timescale conversion.moq_mux::Clockis the shared owner (one monotonic epoch,Copyacross producers) and publishes itssection()at the catalog root from the first snapshot, independently of any archive.catalog::Config::with_clocknames a recording import's real start;catalog::Producer::clockshares the epoch.Clock::source(SourceMap) translates a source's own zero onto the mapping: first frame anchors live (accounting for its PTS), resets re-anchor forward preserving the real idle gap, B-frame reordering within a group survives, unmappable sources are refused viaError::UnmappableTimestamp. Wall mapping is never overwritten and system-clock adjustments never retime it.Archive.timeline.wallandtimeline::Config.wallwith no compatibility alias. Zero timescales and walls past the JSON-safe integer range are refused (Rust + JS).EXT-X-PROGRAM-DATE-TIMEand DASHavailabilityStartTimemap through the root clock; without a catalog clock the manifest falls back to the arrival anchor and playlists omit program-date-time.rs/hang/fixtures/catalog-clock.jsonreader fixture plus clock-owner/HLS-migration tests wired into CI.quest/m1/broadcast-clock.md, removing its references across the quest tree. Native capture, CLI imports, andjs/publishadoption stay in the M2 publisher-clock quest.Alternatives
(Written by Muse Spark)