Repository navigation
quest: publish @moq/hang in the next 0.17 patch - #5590
Conversation
Records the maintainer's decision for release-22: the next 0.17 patch also publishes @moq/hang with its tolerant catalog parser (#5520), audited as backwards compatible with the published 0.5.2. That release's wire-compat re-measure is expected to delete the catalog-archive planned break. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5161059c50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The maintainer accepted the zod wrapper on RootSchema.shape.archive as a patch, since zod schema internals are not public API. @moq/net needs no publish: release builds byte-identical to the published 0.4.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Summary: this records the release-22 decision to publish
Codex gave the final head (d76679b) a thumbs-up, and its P2 thread is answered and resolved. (Written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Records the maintainer's decision in
quest/m0/release-22/README.md: the next 0.17 patch also publishes@moq/hangas is, with its tolerant catalog parser (#5520). The parsedRootand input types are unchanged, and every catalog 0.5.2 accepted parses the same. The only change is the zod wrapper onRootSchema.shape.archive, described below. The maintainer accepted it as a patch on 2026-10-15, since zod schema internals are not public API.The README also drops
@moq/netfrom the publish list.@moq/netonreleasebuilds byte-identical to the published 0.4.3:diff -rof the npm tarball against areleasebuild matches, excluding sourcemaps andjsr.json.That release's
just test wire-compat --remeasureis expected to delete thecatalog-archiveplanned break. No other quest asked this question.Public API / wire impact: none (quest doc only). Nothing is bumped or published here.
Backwards-compatibility audit:
@moq/hangonorigin/release(b88ed60) vs npm 0.5.2What changed.
npm pack @moq/hang@0.5.2unpacked into an empty scratch directory, thenjs/hangbuilt from agit archiveoforigin/release(bun run build).diff -rof the two packages, ignoring sourcemaps andjsr.json, shows only three hunks:catalog/root.js:archive: z.optional(ArchiveSchema)becamearchive: z.catch(z.optional(ArchiveSchema), undefined).catalog/root.d.ts: that field's schema type is now wrapped inZodMiniCatch<...>.package.json:@moq/net^0.4.2became^0.4.3. 0.4.3 is already on npm, andjs/nethas no commits onreleaseafter it was published.No other
.jsor.d.tsfile differs. Onrelease,js/hanghas one commit since the 0.5.2 bump (#4795): #5520.Exports and signatures: one accepted change. No export was added, removed or renamed.
RootSchema.shape.archivechanged fromZodMiniOptional<typeof ArchiveSchema>toZodMiniCatch<ZodMiniOptional<...>>. Its runtimedef.typealso changed from"optional"to"catch". This breaks code that reaches into the field's schema internals, which the maintainer accepted for a patch:const a: z.ZodMiniOptional<typeof ArchiveSchema> = RootSchema.shape.archivecompiles against 0.5.2 and fails with TS2322.RootSchema.shape.archive.def.innerType.shape.trackfails with TS2339 and throws at runtime.This field is the whole type-level surface change; every other
.d.tsis byte-identical. The parsed data types are unchanged: a type-equality assertion undertsc --noEmitshows thatz.infer(the exportedRoot) andz.inputare identical. A deliberately wrong assertion fails the same check.Catalogs 0.5.2 accepted still parse the same. A differential bun test ran in the
releasesnapshot (script below). It compares the 0.5.2 schema, rebuilt asz.extend(RootSchema, { archive: z.optional(ArchiveSchema) })from the dist diff above, against thereleaseschema on 22 catalogs:rs/hangfixture, every media section, clock,track-form archives with and without a store, unknown root sections, foreigntext, and unknown containers. All 14 givetoStrictEqualoutput, the same own keys (archiveabsent stays absent) and identical JSON.archiveare now accepted witharchiveundefined and every other section unchanged. These aremain'stimelinesfixture, atimelinesarchive, an invalid store URL, a string archive and a null archive. This is the intended fix, and it matches Rusthang0.21.14'sDefaultOnErroron the same field. These outputs carry an ownarchive: undefinedkey, which JSON drops.The 0.5.2-era
root.test.ts(from #4795) also ran against thereleasesource. 13 of its 14 tests pass. The only failure is "an invalid store URL is refused", the rejection #5520 deliberately removed.Nothing produced is rejected by released readers.
@moq/hang's change is parse-only and its other output is byte-identical, so it emits nothing new. A catalog it now tolerates can only losearchiveif re-serialized.archiveis optional in every@moq/hangthat has it, and in Rusthang0.21.x (Option,DefaultOnErrorsince 0.21.14).releaseis@moq/publish'sCatalogProducer. It omitsclockwhen the page's wall clock is before 2020, where 0.5.2 threw fromu53.clockhas beenz.optionalin@moq/hangsince it was added (feat(hang)!: one continuous broadcast clock at the catalog root #3675). Rusthang0.21.0 through 0.21.14 declare it#[serde(default)] Option(0.21.0 testsclock_stays_off_the_wire_when_absent).Packages published alongside.
@moq/watch0.6.2 and@moq/publish0.5.2 depend on@moq/hang^0.5.2, so they pick up the patch automatically.@moq/room0.2.1 depends on^0.5.1and picks it up the same way.@moq/hangschema use isCatalog.RootSchemapassed as a schema (watch'sbroadcast.ts). None of them touchesarchive, and the inferred types are unchanged.releasesnapshot, the hang (222), watch (253), publish (162) and room (19) test suites pass, including the differential test.@moq/watchand@moq/publishbuild and publint cleanly.@moq/watch's only change since 0.6.2 is a dev dependency (esbuild to rolldown, fix(js): bundle worklets in-process so no esbuild service outlives the build (release backport) #5354), so it needs no republish.Differential test (run from js/hang/src/catalog in a release snapshot)
🤖 Generated with Claude Code