Skip to content

quest: track remaining published smoke failures - #5580

Merged
kixelated merged 3 commits into
mainfrom
codex/smoke-failure-quests
Oct 15, 2026
Merged

kixelated merged 3 commits into
mainfrom
codex/smoke-failure-quests

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The October 15 Smoke run has failures beyond the nightly fixture regressions fixed in #5579. They need durable owners without duplicating the known linker wait, nightly workload verification, or broader IETF conformance work.

Approach

Create four independently completable quests:

  • Release execution: published Go and JS catalog readers accept the current Rust publisher's live catalog. A release-line patch may satisfy this; it does not gate m1 or authorize a breaking cut.
  • m1: retain jsDelivr request/response evidence and fix any reproduced first-party cause.
  • m1: reproduce and fix minimal Moxygen announce-subscribe, then remove its continue-on-error exception.
  • m1: attribute optional public relay failures and split concrete first-party bugs into focused fixes or quests.

Each records the observed run, what remains unknown, and the constraints against skips, exchange retries, and widened timeouts.

Scope decision

The maintainer requested: "fix them or make quests".

  • ✅ Fix the confirmed nightly test defects and quest the remaining release-dependent or unresolved smoke work.
  • Existing linker, nightly verification, and IETF extension quests retain their current scope.

Impact

  • Public API and wire: none. Quest documents only.

Validation

just check passes in the separate quest worktree, including the full quest graph, Markdown, and GitHub workflow checks.

Alternatives

Publishing packages or changing peer compatibility without the relevant release or protocol diagnosis would exceed the evidence. One large smoke-fix quest would tie independent outcomes together.

Follow-ups

The four quests carry the remaining work; no new upstream posts or package publication are performed here.

(Written by GPT-6)

Co-Authored-By: Codex <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 15, 2026 17:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:05:21.322715Z 87e5d6f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 92527e9b-ee3a-46bd-b573-cd7e53748ff4
📥 Commits

Reviewing files that changed from the base of the PR and between 42a5796 and 87e5d6f.

📒 Files selected for processing: 2
  • quest/m1/README.md
  • quest/m2/release/catalog-readers.md
🚧 Files skipped from review as they are similar to previous changes: 1
  • quest/m1/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The pull request adds required quests for three smoke-run investigations: jsDelivr failures, Moxygen announce-subscribe interoperability, and optional public-relay failures. It also adds a release checklist item and a quest to verify that released Go and JavaScript clients accept the current Rust publisher’s live catalog.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 87e5d

This change adds quest and release-checklist documentation, with no concrete product or operational regression identified. It is ready to merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: tracking unresolved published smoke failures through quests.
Description check Passed The description directly explains the smoke failures, the four quests, scope, validation, and follow-ups.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 42a5796.

No actionable bugs found in these plans. Separating CDN evidence capture, minimal Moxygen interop, public-peer attribution and publication keeps each outcome independently verifiable. The plans correctly avoid treating optional green workflow status as interop success or guessing a CDN root cause without failed-response evidence.

The catalog-reader publication plan agrees with #5485, #5520 and the current compatibility exception. Keeping installed-artifact verification under release execution, with an earlier release-line patch allowed, avoids making publication an m1 prerequisite.

Verification: static review limited to moq-dev/moq. Linked moq-dev/smoke runs and CDN observations are outside this review's repository scope and were not independently verified. No tests, builds or release actions executed.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged latest main (clean, no conflicts). quest check (480 documents) and just check pass on the merged tree.
  • Aligned quest/m2/release/catalog-readers.md with quest: publish @moq/hang in the next 0.17 patch #5590, which landed after this PR was opened: the next 0.17 patch (owned by /quest/m0/release-22/README.md) already publishes @moq/hang with the tolerant parser, so this quest now verifies installed artifacts and advances only what that patch does not cover.
  • The OpenAI review of the previous head had no findings; CodeRabbit left no inline findings. The new commit is a one-paragraph quest wording change.
  • No public API or wire impact; quest documents only.

Enabling auto-merge.

(Written by Opus 5.5)

@kixelated
kixelated enabled auto-merge October 15, 2026 23:02
@kixelated
kixelated added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 9f1f7d1 Oct 15, 2026
6 checks passed
@kixelated
kixelated deleted the codex/smoke-failure-quests branch October 15, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant