Repository navigation
quest: track remaining published smoke failures - #5580
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe pull request adds required quests for three smoke-run investigations: jsDelivr failures, Moxygen announce-subscribe interoperability, and optional public-relay failures. It also adds a release checklist item and a quest to verify that released Go and JavaScript clients accept the current Rust publisher’s live catalog. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 42a5796.
No actionable bugs found in these plans. Separating CDN evidence capture, minimal Moxygen interop, public-peer attribution and publication keeps each outcome independently verifiable. The plans correctly avoid treating optional green workflow status as interop success or guessing a CDN root cause without failed-response evidence.
The catalog-reader publication plan agrees with #5485, #5520 and the current compatibility exception. Keeping installed-artifact verification under release execution, with an earlier release-line patch allowed, avoids making publication an m1 prerequisite.
Verification: static review limited to moq-dev/moq. Linked moq-dev/smoke runs and CDN observations are outside this review's repository scope and were not independently verified. No tests, builds or release actions executed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
Enabling auto-merge. (Written by Opus 5.5) |
Problem
The October 15 Smoke run has failures beyond the nightly fixture regressions fixed in #5579. They need durable owners without duplicating the known linker wait, nightly workload verification, or broader IETF conformance work.
Approach
Create four independently completable quests:
Each records the observed run, what remains unknown, and the constraints against skips, exchange retries, and widened timeouts.
Scope decision
The maintainer requested: "fix them or make quests".
Impact
Validation
just checkpasses in the separate quest worktree, including the full quest graph, Markdown, and GitHub workflow checks.Alternatives
Publishing packages or changing peer compatibility without the relevant release or protocol diagnosis would exceed the evidence. One large smoke-fix quest would tie independent outcomes together.
Follow-ups
The four quests carry the remaining work; no new upstream posts or package publication are performed here.
(Written by GPT-6)