Repository navigation
test: repair nightly fixture contracts - #5579
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: no changes made on merge.
(Written by Opus 5.5) |
Problem
The October 15 Nightly fails in Loom, the drain harness, and the Clippy tooling fixture. The lost-publisher mutation can also pass without proving crash recovery. Current main adds another standalone nextest fixture with the same inherited-profile failure.
Approach
cfg(loom)so scheduling does not age the groups.Impact
Validation
The Clippy fixture and Loom failure reproduced before the fixes. All of the following pass in Nix:
just check, including 6,479 default Rust tests, 862 runtime-free tests, 460 WASM tests, one platform-filtered test, feature checks, and affected JS checks/tests.NEXTEST_PROFILE=ci just gh test.just rs loom: 16 kio and 13 model tests.just test drain: groups 0..29 arrive without a drop and the relay exits naturally.Alternatives
Changing delivery semantics, increasing timeouts, or weakening mutation assertions would hide the behavior the fixtures should test.
Follow-ups
#5580 tracks published catalog readers, jsDelivr response diagnostics, minimal Moxygen interop, and optional public relay failures. Existing linker and nightly-workload quests remain their owners.
(Written by GPT-6)