Skip to content

test: repair nightly fixture contracts - #5579

Merged
kixelated merged 1 commit into
mainfrom
codex/nightly-fixtures
Oct 15, 2026
Merged

kixelated merged 1 commit into
mainfrom
codex/nightly-fixtures

Conversation

@kixelated

@kixelated kixelated commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The October 15 Nightly fails in Loom, the drain harness, and the Clippy tooling fixture. The lost-publisher mutation can also pass without proving crash recovery. Current main adds another standalone nextest fixture with the same inherited-profile failure.

Approach

  • Give standalone nextest fixtures their own default profile instead of inheriting a CI profile they do not define.
  • Request backlog explicitly in the two-group Loom model and freeze its wall clock under cfg(loom) so scheduling does not age the groups.
  • Match the relay's current natural-drain completion log, preserving rejection of a forced drain.
  • Keep publisher handles alive until remote withdrawal is observed in the crash drill. Dropping a Connection cancels its task asynchronously, so dropping the broadcast immediately could send a clean unannounce first.

Impact

  • Public API and wire: none. The clock change applies only to Loom builds; production behavior is unchanged.

Validation

The Clippy fixture and Loom failure reproduced before the fixes. All of the following pass in Nix:

  • just check, including 6,479 default Rust tests, 862 runtime-free tests, 460 WASM tests, one platform-filtered test, feature checks, and affected JS checks/tests.
  • NEXTEST_PROFILE=ci just gh test.
  • just rs loom: 16 kio and 13 model tests.
  • just test drain: groups 0..29 arrive without a drop and the relay exits naturally.
  • Corrected lost-publisher drill, loopback and impaired lanes. Its sensitivity mutation fails with the expected missing-announcement message after explicitly rebuilding the mutated moq-net crate.

Alternatives

Changing delivery semantics, increasing timeouts, or weakening mutation assertions would hide the behavior the fixtures should test.

Follow-ups

#5580 tracks published catalog readers, jsDelivr response diagnostics, minimal Moxygen interop, and optional public relay failures. Existing linker and nightly-workload quests remain their owners.

(Written by GPT-6)

Co-Authored-By: Codex <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 15, 2026 17:32
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bebfcec0-aba4-4db1-897a-b2874c7071b1
📥 Commits

Reviewing files that changed from the base of the PR and between 0fc7977 and c49965c.

📒 Files selected for processing: 6
  • rs/moq-net/src/model/clock.rs
  • rs/moq-net/tests/loom.rs
  • rs/moq-relay/tests/drills.rs
  • sh/rs/select.test.py
  • sh/rs/test-lints.test.py
  • test/drain/run.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T17:34:54.867604Z c49965c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: no changes made on merge.

  • Mergeable against main, required CI green, Codex review finished with no findings (thumbs-up). CodeRabbit was rate-limited.
  • Checked the drain harness string against rs/moq-relay/src/relay.rs: drain ended with no established sessions; exiting is logged only for the live: 0, forced: 0 tally, so a forced drain is still rejected.
  • The Loom-only wall() freeze is gated all(loom, not(test)), so production and unit-test clocks are unchanged.
  • Follow-ups remain tracked in quest: track remaining published smoke failures #5580.

(Written by Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit b958bcd Oct 15, 2026
13 checks passed
@kixelated
kixelated deleted the codex/nightly-fixtures branch October 15, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant