Repository navigation
fix(moq-tokio): grant qmux sessions the QUIC stream limit - #5609
Conversation
qmux grants a peer 100 concurrent streams by default, and moq-lite holds one open per subscription, so a WebSocket, tcp://, tls:// or unix:// peer past 100 subscriptions waits on stream credit forever with nothing erroring. Configure every qmux builder with the same 10,000 streams QUIC grants, through the session config qmux 0.6.3 added to its builders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: aad0be1.
No actionable findings in this repository-scoped review. One private config helper reaches the production WebSocket, TCP, TLS and Unix dial/accept paths, including TLS-name override and upgraded sockets. The TCP regression checks both endpoints' bidi/uni credit while retaining open streams. Sharing the existing QUIC default is simpler than duplicating per-transport constants.
Verification limits: static inspection of moq-dev/moq only. No tests or builds run. High-stream-count regression coverage is TCP-only; other paths were checked by their constructor wiring. The qmux dependency's internal buffering and config-application semantics were outside this review, so the increased transport concurrency is not a complete backend resource/security audit.
|
The one red check, TS validation, failed (Written by Claude Opus 5.5) |
|
Merge summary: no code changes from the merge pass.
Enabling auto-merge on (Written by Opus 5.5) |
Problem
qmux grants a peer 100 concurrent streams by default, and moq-tokio uses that default for every qmux transport: the WebSocket fallback,
tcp://,tls://andunix://, on both the dial and accept sides. moq-lite holds a stream open per subscription, so a peer that subscribes to more than about 100 tracks over one of these sessions stalls: every later SUBSCRIBE waits on MAX_STREAMS credit forever, and nothing errors. The same peer over QUIC gets 10,000 (quic::DEFAULT_MAX_STREAMS).Approach
qmux 0.6.3 lets every builder take a session config (moq-dev/web-transport#426). A crate-private
qmux_config()grantsquic::DEFAULT_MAX_STREAMSin each direction, and every qmux builder in moq-tokio takes it:ws::{Client, Upgraded}inwebsocket,tcp::Configandtls::{Client, Server}intcp, anduds::Configinunix. qmux's own default stays at 100.The grant is fixed rather than following
--quic-max-streams; that setting stays QUIC-only.Impact
initial_max_streams_*of 10,000 instead of 100, matching QUIC. No new frames or parameters.qmux0.6.2 to 0.6.3 (the workspace requirement moves to0.6.3, the first release with the builder config).Validation
tcp::tests::sessions_grant_a_thousand_open_streamsdials a moq-tokio TCP listener and has each end open 1,000 bidi and 1,000 uni streams that stay open. Credit is checked withnow_or_never, so the test needs no timer. With the old grant it fails: "client stalled on stream credit after opening 100 stream pairs".just checkpasses locally.Follow-ups
releasestill locks qmux 0.5.2. A backport needs a qmux 0.5.x carrying the builder config (feat(qmux): take a session config on every transport builder (0.5) web-transport#427), which is not published yet.@moq/qmuxclients keep qmux's JS default of 100.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)