Skip to content

test(relay): a failed drill names a shaper that stopped forwarding - #5935

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/test-flakes-2/drill-shaper-failure
Oct 19, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/test-flakes-2/drill-shaper-failure

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Quest: quest/m1/test-flakes-2/drill-shaper-failure.md (deleted here, and removed from the epic's Required).

Problem

When a drill's shaper stops forwarding mid-run, its clients just time out. Drop for Path printed only the shaper's counters, and only Path::verify() (called at the very end of a drill) reported the shaper's error. So the CI log showed subscriber: no status change within 10s, wanted Connected and nothing else. That is how #5796 hid.

Fix

Drop for Path now prints Shaper::verify()'s verdict instead of bare counters. Every drill calls Path::verify() at its end, which takes the shaper, so this Drop branch only runs when a drill fails first. When the shaper stopped, the verdict leads with the shaper stopped forwarding: <cause>. Otherwise it prints the same counters as before, plus any impairment that never acted.

Reproduction

I temporarily made the shaper's reply task fail after 20 datagrams and ran relay_killed_mid_group_aborts_then_resumes::loopback:

  • Before: shaper: up: 62 packets, ... then the panic subscriber: no status change within 10s, wanted Connected. Nothing names the shaper.
  • After: shaper: the shaper stopped forwarding: sabotaged for the repro (up: 63 packets, ...) before the same panic.

Regression test

None landed. Testing this would mean a test-only hook in moq-shaper to force a failure, plus capturing stdout from a Drop. That is a lot of new surface for a diagnostic print. The repro above is the proof.

Choice made without asking

Drop reuses verify() instead of adding an accessor to moq-shaper that returns only the failure. Reusing it adds no API. The cost: a drill that fails early may also print that some impairment never acted. That is true, and labeled as such, but it is not the reason the drill failed.

Checks

  • just check: pass (580 tests, including all 14 drills)
  • quest check: pass

API / wire impact

None. Test-only change in rs/moq-relay/tests/drills.rs.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 19, 2026 00:54
Path's Drop printed only the shaper's counters, so a shaper that stopped
mid-drill surfaced only as a client status timeout. It now prints the
shaper's verify verdict, which leads with why forwarding stopped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T08:02:08.022604Z b85ea47 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46128d37-c3b7-4926-8be5-056691e8dc1d
📥 Commits

Reviewing files that changed from the base of the PR and between ad87ad3 and b85ea47.

📒 Files selected for processing: 3
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/drill-shaper-failure.md
  • rs/moq-relay/tests/drills.rs
💤 Files with no reviewable changes: 2
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/drill-shaper-failure.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Walkthrough

When a drill path is dropped with a remaining shaper, Path::drop now verifies the shaper and prints its statistics on success or its formatted error on failure. The related quest document and its Required-list entry were removed.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to b85ea

The change improves drill-failure diagnostics, and the removed quest is no longer required or referenced. No concrete merge-blocking risk remains beyond normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: failed drills now identify the shaper that stopped forwarding.
Description check Passed The description directly explains the shaper-forwarding failure, the diagnostic change in Drop for Path, the reproduction, testing, and impact.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution timed out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: on a drill failure, Drop for Path now prints Shaper::verify()'s verdict, so a shaper that stopped forwarding is named in the CI log instead of hiding behind client timeouts. Test-only change in rs/moq-relay/tests/drills.rs; no API or wire impact. The quest file is deleted and removed from its epic.

Decisions: the maintainer accepted reusing verify() in Drop (no new moq-shaper accessor), at the cost of an early failure possibly also listing impairments that never acted. No regression test, per the description; the manual repro is the proof.

Reviews: Codex (no findings, plus thumbs-up) and CodeRabbit (no actionable comments) both cover head b85ea47. CI is green. Enqueuing.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit d2dedc9 Oct 19, 2026
9 checks passed
@kixelated
kixelated deleted the quest/m1/test-flakes-2/drill-shaper-failure branch October 19, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant