Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions quest/m1/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ Public API: none. Wire: none.
- [gst redial port](/quest/m1/test-flakes-2/gst-redial-port.md) - the moq-gst redial tests never lose their relay's port to `AddrInUse`
- [js/net local close](/quest/m1/test-flakes-2/js-local-close.md) - the draft-17 locally closed track test holds under load
- [WASM refused track](/quest/m1/test-flakes-2/wasm-refused-track.md) - the refused-track case passes and fails on its refusal, not a timeout
- [Drill shaper failure](/quest/m1/test-flakes-2/drill-shaper-failure.md) - a drill whose shaper stopped says so directly

## Related

- [Controlled time](/quest/m1/time/README.md) - the systemic fix these rules ask for: every crate on a controlled clock
Expand Down
18 changes: 0 additions & 18 deletions quest/m1/test-flakes-2/drill-shaper-failure.md

This file was deleted.

9 changes: 7 additions & 2 deletions rs/moq-relay/tests/drills.rs
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,14 @@ fn seed(lane: Lane) -> u64 {

impl Drop for Path {
fn drop(&mut self) {
// A drill that failed before `verify` still reports what the path did.
// A drill that failed before `verify` still reports what the path did,
// including a shaper that stopped forwarding, which the drill itself
// only sees as a client timing out.
if let Some(shaper) = &self.shaper {
println!("shaper: {}", shaper.stats());
match shaper.verify() {
Ok(stats) => println!("shaper: {stats}"),
Err(err) => println!("shaper: {err:#}"),
}
}
}
}
Expand Down
Loading