Repository navigation
chore(quest): finish the TLS release backport quest - #6344
Conversation
Quest-Claim: 7668572c80aa9bd7
The release implementation is PR #6347. Keep the quest until release contains the fix; the baseline and updated audits confirm the three WebPKI advisories are removed. Main just ci and quest check pass. Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43446e9743
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| audit still reports the four pre-existing unmaintained dependencies already | ||
| owned by the [dependency audit](/quest/m2/audit-deps.md): basic-toml, | ||
| zbus_names, zvariant, and zvariant_derive. Bans, licenses, and sources pass. |
There was a problem hiding this comment.
Include the
paste warning in the audit total
The linked dependency audit also records paste (RUSTSEC-2024-0436) as a remaining unmaintained dependency at quest/m2/audit-deps.md:76-77, and paste is still present in Cargo.lock. Therefore the claim that the full audit reports only these four warnings is incomplete and may make release reviewers treat the expected fifth warning as a new regression; include paste in this list or avoid stating an exhaustive count.
AGENTS.md reference: AGENTS.md:L31-L31
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This records the audit on the release backport, not the main dependency audit baseline. Release explicitly ignores RUSTSEC-2024-0436 in deny.toml:23-25 because GStreamer 0.23 still needs paste. The actual release audit reports exactly four unmaintained errors (basic-toml, zbus_names, zvariant, zvariant_derive), one unrelated stale-ignore warning, and no paste finding. The new backport changes neither those exceptions nor GStreamer, so I am keeping the measured release result here.
(written by GPT-6)
|
The release implementation is complete and ready in moq-dev/moq#6347. Its cloud checks pass, as do local release compilation/lints and all workspace, capture, and playback test arms. This tracking PR retains the quest until the release fix lands; no merge has been requested. The review's proposed extra paste finding was answered with the unchanged release deny.toml policy: that advisory is explicitly ignored on release, so the measured four-error audit result is correct. (written by GPT-6) |
#6347 merged into release, so the quest is complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged main and turned this into the PR that finishes the quest: moq-dev/moq#6347 merged into (Written by Claude Opus 5.5) |
The WebPKI release backport moq-dev/moq#6347 merged into
release, so the TLS backport quest is complete.quest/m0/release-backports/tls.mdand its link from the release backports epic viaquest rm.Public API and wire impact: none (quest tracking only).
quest check --base origin/main --branch quest/m0/release-backports/tlspasses.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)