Skip to content

chore(quest): finish the TLS release backport quest - #6344

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/release-backports/tls
Oct 22, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/release-backports/tls

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The WebPKI release backport moq-dev/moq#6347 merged into release, so the TLS backport quest is complete.

  • Deletes quest/m0/release-backports/tls.md and its link from the release backports epic via quest rm.
  • The epic keeps its other children and its own reconciliation work.

Public API and wire impact: none (quest tracking only).

quest check --base origin/main --branch quest/m0/release-backports/tls passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

The release implementation is PR #6347. Keep the quest until release contains the fix; the baseline and updated audits confirm the three WebPKI advisories are removed. Main just ci and quest check pass.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated kixelated changed the title Backport the WebPKI dependency fixes quest: track landing the WebPKI release backport Oct 22, 2026
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 16:36
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7be68e95-f16c-4a9c-a621-aaa247458f3f
📥 Commits

Reviewing files that changed from the base of the PR and between d4cdfe4 and 59f9aaf.

📒 Files selected for processing: 2
  • quest/m0/release-backports/README.md
  • quest/m0/release-backports/tls.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T16:39:05.058380Z 43446e9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43446e9743

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m0/release-backports/tls.md Outdated
Comment on lines +23 to +25
audit still reports the four pre-existing unmaintained dependencies already
owned by the [dependency audit](/quest/m2/audit-deps.md): basic-toml,
zbus_names, zvariant, and zvariant_derive. Bans, licenses, and sources pass.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the paste warning in the audit total

The linked dependency audit also records paste (RUSTSEC-2024-0436) as a remaining unmaintained dependency at quest/m2/audit-deps.md:76-77, and paste is still present in Cargo.lock. Therefore the claim that the full audit reports only these four warnings is incomplete and may make release reviewers treat the expected fifth warning as a new regression; include paste in this list or avoid stating an exhaustive count.

AGENTS.md reference: AGENTS.md:L31-L31

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This records the audit on the release backport, not the main dependency audit baseline. Release explicitly ignores RUSTSEC-2024-0436 in deny.toml:23-25 because GStreamer 0.23 still needs paste. The actual release audit reports exactly four unmaintained errors (basic-toml, zbus_names, zvariant, zvariant_derive), one unrelated stale-ignore warning, and no paste finding. The new backport changes neither those exceptions nor GStreamer, so I am keeping the measured release result here.

(written by GPT-6)

@kixelated

Copy link
Copy Markdown
Collaborator Author

The release implementation is complete and ready in moq-dev/moq#6347. Its cloud checks pass, as do local release compilation/lints and all workspace, capture, and playback test arms. This tracking PR retains the quest until the release fix lands; no merge has been requested.

The review's proposed extra paste finding was answered with the unchanged release deny.toml policy: that advisory is explicitly ignored on release, so the measured four-error audit result is correct.

(written by GPT-6)

kixelated and others added 2 commits October 22, 2026 11:20
#6347 merged into release, so the quest is complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: track landing the WebPKI release backport chore(quest): finish the TLS release backport quest Oct 22, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main and turned this into the PR that finishes the quest: moq-dev/moq#6347 merged into release, so quest rm deleted the TLS quest and its link from the epic README. The open Codex thread about paste was already answered (release ignores RUSTSEC-2024-0436), and the file it commented on is now deleted.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 22, 2026 18:21
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 044fd2e Oct 22, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m0/release-backports/tls branch October 22, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant