Skip to content

fix(tls): backport WebPKI distrust updates to release - #6347

Merged
kixelated merged 1 commit into
releasefrom
codex/release-webpki
Oct 22, 2026
Merged

kixelated merged 1 commit into
releasefrom
codex/release-webpki

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Release accepts certificate paths through compromised emSign intermediate keys. Existing native clients and relays validate peer certificates through the affected WebPKI packages.

Approach

Backport the three locked versions already on main: rustls-webpki 0.103.16, webpki-roots 1.0.10, and webpki-root-certs 1.0.10. Every other lockfile package and dependency edge is unchanged.

These address RUSTSEC-2026-0382, RUSTSEC-2026-0381, and RUSTSEC-2026-0383.

Impact

  • No public API, MoQ wire, or package version changes.
  • Certificate verification rejects the distrusted intermediate keys, and bundled roots remove the affected emSign root.

Alternatives

The broad main dependency update also changes GStreamer and is outside this focused backport.

Validation

  • Before: the advisory audit reports all three WebPKI vulnerabilities. After: all three are gone; dependency trees resolve the fixed versions, including the all-platform root-certs consumer.
  • just rs audit still reports four pre-existing unmaintained dependencies, already tracked in the dependency audit quest: basic-toml, zbus_names, zvariant, and zvariant_derive. Bans, licenses, and sources pass. Release's existing paste exception is unchanged.
  • All 5,662 workspace tests pass (11 skipped), with two test threads and no retries. The first overloaded run failed three completion tests against their wall-clock budgets. The unchanged release baseline also passes those three; no production behavior, assertion, or deadline was changed.
  • just ci check origin/release passes, including workspace, documentation, TLS feature combinations, WASM, capture, io_uring, media feature contracts, Nix, and repository lints.
  • The remaining test-gate arms pass: 387 capture tests (3 skipped) and 133 playback tests. All commands ran in the Nix development shell with two build/test workers for the final test runs.

Follow-ups

Main quest tracking keeps the backport quest accurate until this release PR lands. No new quests or package upgrades are included.

(written by GPT-6)

Update only rustls-webpki and the two WebPKI root bundles to the fixed versions already on main. Clears RUSTSEC-2026-0381, RUSTSEC-2026-0382, and RUSTSEC-2026-0383 without changing published APIs or wire formats.

Co-Authored-By: GPT-6 <noreply@openai.com>
kixelated added a commit that referenced this pull request Oct 22, 2026
The release implementation is PR #6347. Keep the quest until release contains the fix; the baseline and updated audits confirm the three WebPKI advisories are removed. Main just ci and quest check pass.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 17:18
@kixelated

Copy link
Copy Markdown
Collaborator Author

Implemented the focused backport without unrelated dependency changes. The three WebPKI advisories reproduce on release and disappear with this lockfile; four pre-existing unmaintained-dependency audit errors remain tracked separately.

Local release checks are complete: compile/lint gate passes; 5,662 workspace, 387 capture, and 133 playback tests pass. The initial overloaded workspace run hit three completion-test deadlines; the final two-thread run passes without changing code, assertions, or timeouts. The unchanged release baseline also passes those three tests.

No API/wire changes or package version bumps. The main tracking PR keeps the quest until this release fix lands. Ready for review; nothing merged.

(written by GPT-6)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T17:20:02.654149Z 9a1afa2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated merged commit dc948ae into release Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the codex/release-webpki branch October 22, 2026 18:19
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged into release after a clean Codex review of this head and green release checks; maintainer picked the merge in the quest-complete run.

(Written by Claude Opus 5.5)

kixelated added a commit that referenced this pull request Oct 22, 2026
#6347 merged into release, so the quest is complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated added a commit that referenced this pull request Oct 22, 2026
All three children landed on release (#6347, #6349, #6355) with
green release CI, and the release-plz PR carries them, so the epic's
reconciliation work is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant