Repository navigation
fix: bound decoded WebTransport CONNECT headers - #6601
Conversation
Quest-Claim: 3dda7f4cbd54c92a
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main finished broadcast-epoch, program-cap, and decode-order, and moved drop-web-transport-trait to m1. Drops this branch's edits to the finished quests, keeps its m0 Goal trim (without the CONNECT-header bound, landed in #6601), the Route::auth keep in main's rewritten net-exports, and the OBS decode timing child in release-audit, and retargets decode-order links to #6453. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Decoded CONNECT headers can amplify peer-controlled memory before authentication. The upstream web-transport-proto 0.6.3 patch limits the decoded field section to 16 KiB.
Approach
Update only the locked version and checksum and finish the quest. The explicitly planned release backport is #6604; merge it before this quest-closing PR.
Verified
Settings::enable_webtransportin moq-tokio and moq-uring, and in iroh's upstream settings path: 0.6.3 addsMAX_FIELD_SECTION_SIZE=16384there.Impact
Validation
On the merge of
origin/main(71352d0):nix flake checkstops at the local sandbox restriction (unshare: write failed /proc/self/uid_map: Operation not permitted), unrelated to this diff.just test interop --all: all checks passed.Alternatives
An in-tree decoder patch would duplicate upstream and miss iroh.
Follow-ups
None after both PRs land, in the order above.
(Written by GPT-6, updated by Claude Opus 5.5)