Skip to content

fix: bound decoded WebTransport CONNECT headers - #6601

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/web-transport-proto-0.6.3
Oct 24, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/web-transport-proto-0.6.3

Conversation

@kixelated

@kixelated kixelated commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Decoded CONNECT headers can amplify peer-controlled memory before authentication. The upstream web-transport-proto 0.6.3 patch limits the decoded field section to 16 KiB.

Approach

Update only the locked version and checksum and finish the quest. The explicitly planned release backport is #6604; merge it before this quest-closing PR.

Verified Settings::enable_webtransport in moq-tokio and moq-uring, and in iroh's upstream settings path: 0.6.3 adds MAX_FIELD_SECTION_SIZE=16384 there.

Impact

  • Public MoQ API and MoQ wire schemas: unchanged.
  • Upstream HTTP/3: SETTINGS advertises the field section bound, and CONNECT field sections above 16 KiB are refused.

Validation

On the merge of origin/main (71352d0):

  • Rust tests in scope: 9872 passed; capture: 523 passed; play/cli: 226 passed.
  • Rust lints, quest check, ts-paths, markdown, shell, large-file, TOML, and GitHub tooling checks/tests passed.
  • nix flake check stops at the local sandbox restriction (unshare: write failed /proc/self/uid_map: Operation not permitted), unrelated to this diff.
  • just test interop --all: all checks passed.
  • The release backport's full local check/test gates passed.
  • No new moq-side test, as the quest explicitly relies on upstream decoder tests.

Alternatives

An in-tree decoder patch would duplicate upstream and miss iroh.

Follow-ups

None after both PRs land, in the order above.

(Written by GPT-6, updated by Claude Opus 5.5)

kixelated and others added 2 commits October 23, 2026 17:40
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated kixelated changed the title Take web-transport-proto 0.6.3 fix: bound decoded WebTransport CONNECT headers Oct 24, 2026
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 00:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T07:49:58.293581Z b5c61f0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7163bca0-5106-4439-92e1-92bfc022ad04
Commits

Reviewing files that changed from the base of the PR and between f52848d and b5c61f0.

Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 4
  • quest/m0/README.md
  • quest/m0/web-transport-proto-0.6.3.md
  • quest/m1/release-audit/README.md
  • quest/m2/drop-web-transport-trait.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit 6f4e086 Oct 24, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/web-transport-proto-0.6.3 branch October 24, 2026 09:21
kixelated added a commit that referenced this pull request Oct 24, 2026
Main finished broadcast-epoch, program-cap, and decode-order, and moved drop-web-transport-trait to m1. Drops this branch's edits to the finished quests, keeps its m0 Goal trim (without the CONNECT-header bound, landed in #6601), the Route::auth keep in main's rewritten net-exports, and the OBS decode timing child in release-audit, and retargets decode-order links to #6453.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant