Skip to content

fix: bound decoded WebTransport CONNECT headers (release) - #6604

Merged
kixelated merged 2 commits into
releasefrom
fix/release-web-transport-proto-0.6.3
Oct 24, 2026
Merged

kixelated merged 2 commits into
releasefrom
fix/release-web-transport-proto-0.6.3

Conversation

@kixelated

@kixelated kixelated commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Before authentication, decoded CONNECT headers can amplify peer-controlled memory. web-transport-proto 0.6.3 bounds the decoded field section to 16 KiB.

Approach

Backport #6601 as the quest planned: change only web-transport-proto's version and checksum in Cargo.lock. Release uses enable_webtransport directly in moq-uring and through web-transport-moq 1.3.5 and web-transport-iroh 0.7.0, so SETTINGS carries the enforced decoder bound.

Merge this release backport before the quest-closing main PR.

Impact

  • Public MoQ API and MoQ wire schemas: unchanged.
  • Upstream HTTP/3: SETTINGS advertises MAX_FIELD_SECTION_SIZE=16384; CONNECT field sections above the bound are refused.

Alternatives

An in-tree decoder patch would duplicate upstream and miss iroh.

Validation

  • Release just ci check origin/release and just ci test origin/release both passed, including isolated transport/media feature checks.
  • Rust suites: 5667 default, 387 capture, and 133 play tests passed.
  • No new moq-side test, as the quest explicitly relies on upstream decoder tests.

Follow-ups

None.

(Written by GPT-6)

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 01:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T07:07:15.539098Z 3ef8652 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

Release moved (#6598 landed), so this head merges origin/release in; the PR diff is still only the web-transport-proto lock bump.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 3ef865231d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated enabled auto-merge October 24, 2026 07:07
@kixelated
kixelated merged commit f3c640a into release Oct 24, 2026
11 checks passed
@kixelated
kixelated deleted the fix/release-web-transport-proto-0.6.3 branch October 24, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant