Repository navigation
fix: bound decoded WebTransport CONNECT headers (release) - #6604
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before authentication, decoded CONNECT headers can amplify peer-controlled memory. web-transport-proto 0.6.3 bounds the decoded field section to 16 KiB.
Approach
Backport #6601 as the quest planned: change only web-transport-proto's version and checksum in Cargo.lock. Release uses
enable_webtransportdirectly in moq-uring and through web-transport-moq 1.3.5 and web-transport-iroh 0.7.0, so SETTINGS carries the enforced decoder bound.Merge this release backport before the quest-closing main PR.
Impact
MAX_FIELD_SECTION_SIZE=16384; CONNECT field sections above the bound are refused.Alternatives
An in-tree decoder patch would duplicate upstream and miss iroh.
Validation
just ci check origin/releaseandjust ci test origin/releaseboth passed, including isolated transport/media feature checks.Follow-ups
None.
(Written by GPT-6)