Repository navigation
quest: narrow the release shutdown backport to its remaining publishes - #6634
Conversation
Quest-Claim: 562ae8ea0e358352
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-backport # Conflicts: # quest/m0/README.md # quest/m0/hls-admission-backport.md
# Conflicts: # quest/m0/README.md
The drain() backport and moq-ffi, Swift, and Kotlin have shipped. What remains is publishing Python moq-rs 0.5.2 and Dart moq 0.1.1 from release, which the maintainer runs in the combined patch cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8b9d748
No actionable bugs found in the two changed quest files. Narrowing the completed code backport to the remaining Python/Dart publications is a sensible simplification; the explicit maintainer-only cut and separate Python retry paths make the remaining work clear. The documented triggers and versions agree with the GitHub workflow definitions and release-branch manifests inspected.
Verification limits: static GitHub review only; no tests, builds, publishing workflows, or external registry checks were run. Registry publication status is not independently verified.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a quest-only rewrite (2 Markdown files, no code) that narrows quest/m0/ffi-shutdown-backport.md to the publishes that remain after the code backport landed.
- Retitled and re-scoped the quest —
# [S] Backport draining shutdown and the qmux stream limit to releasebecomes# [XS] Publish the release line's drain() wrappers; the Goal is now Pythonmoq-rs0.5.2 on PyPI and Dartmoq0.1.1 on pub.dev, and the Plan records what already shipped plus the two open Python paths and the Dart tag path. - Updated the
quest/m0/README.mdbullet to the new title and one-line description.
I verified the cited facts rather than taking them on trust: #6642 (base release) is the drain()/qmux backport and touched py/moq-rs/** and dart/moq/**; #7421 and #7026 match their stated titles. The release branch carries moq-rs 0.5.2 and dart/moq 0.1.1 (main has 0.6.0 / 0.1.0) with rs/moq-ffi/Cargo.toml at 0.4.20, and release-py.yml has no workflow_dispatch with the exact push paths the quest names. moq-dart-v0.1.0 is the only moq-dart-v* tag, moq-ffi-v0.4.20 exists, and PyPI's latest moq-rs is 0.5.1 — all consistent with the quest's "remaining" framing. quest/m2/release/dart-publish.md exists and matches the described unproven path.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
|
Landing summary (
(Written by Claude Opus 5.5) |
|
quest land removed this pull request from the queue: the batch check failed (exit 100). Checking http-cache v1.0.0-alpha.8
Checking pipewire v0.10.1
Compiling proc-macro2-diagnostics v0.10.1
Checking moq-sock v0.2.0 (/work/rs/moq-sock)
Checking fs-err v3.3.1
Checking p384 v0.14.0
Checking p256 v0.14.0
Checking arboard v3.7.0
Checking reqwest-middleware v0.5.2
Checking web-transport-trait v0.5.2
Checking moq-auth v0.2.1 (/work/rs/moq-auth)
Checking axum v0.8.9
Checking axum-server v0.8.0
Checking egui-wgpu v0.36.2
Checking http-cache-reqwest v1.0.0-alpha.9
Checking egui-winit v0.36.2
Compiling duplicate v2.0.1
Checking eframe v0.36.2
Checking egui_dock v0.21.1
Checking cpal v0.18.2
Checking moq-json v0.5.8 (/work/rs/moq-json)
Checking moq-loc v0.2.19 (/work/rs/moq-loc)
Checking qmux v0.7.0 (/work/rs/qmux)
Checking hang v0.21.11 (/work/rs/hang)
Checking moq-stats v0.2.12 (/work/rs/moq-stats)
Checking moq-tokio v0.19.23 (/work/rs/moq-tokio)
Checking moq-mux v0.10.11 (/work/rs/moq-mux)
Checking moq-relay v0.17.2 (/work/rs/moq-relay)
Checking moq-audio v0.1.10 (/work/rs/moq-audio)
Checking moq-scene v0.1.0 (/work/rs/moq-scene)
Checking moq-studio v0.1.0 (/work/rs/moq-studio)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 07s
info: running `cargo clippy --locked --tests --all-features -- -D warnings` on moq-wasm (50/51)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s
info: running `cargo clippy --locked --tests --all-features -- -D warnings` on uniffi-bindgen (51/51)
Compiling getrandom v0.4.3
Compiling winnow v1.0.4
Compiling uniffi_internal_macros v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling serde v1.0.229
Compiling libc v0.2.191
Checking indexmap v2.14.2
Compiling fs-err v3.3.1
Compiling askama_parser v0.16.1
Compiling basic-toml v0.1.10
Checking nom v7.1.3
Compiling scroll_derive v0.12.1
Checking tempfile v3.27.0
Checking smawk v0.3.3
Compiling askama_derive v0.16.1
Checking serde_json v1.0.154
Checking weedle2 v5.0.0 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling toml_parser v1.1.3+spec-1.1.0
Checking textwrap v0.16.4
Checking uniffi_pipeline v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Checking scroll v0.12.0
Checking uniffi_meta v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling askama_macros v0.16.1
Compiling toml_datetime v1.1.1+spec-1.1.0
Checking plain v0.2.3
Compiling toml v1.1.6+spec-1.1.0
Checking clap_builder v4.6.7
Checking uniffi_udl v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Checking goblin v0.8.2
Checking cargo_metadata v0.23.1
Checking askama v0.16.1
Checking uniffi_core v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Checking clap v4.6.7
Checking uniffi_bindgen v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling uniffi_macros v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Checking uniffi v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Checking uniffi-bindgen v0.1.0 (/work/rs/uniffi-bindgen)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.79s
mbx[cache]: object cache: 1219 hits, 0 misses, 209 not looked up; 0 B downloaded, 0 B uploaded, 408.1 MiB stored locally
mbx[cache]: 10m 13s session; 17m 18s estimated compiler time avoided (summed across compilations)
mbx[cache]: 209 compilations had no usable prior inputs or matching prediction for a lookup
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: 2.3 TiB in every checkout, 2.3 TiB on disk. arithmetic declined to comment.
ci: test rs failed
ci: seconds per module
614 check rs
307 test rs (failed)
1262 check rs_shapes
237 check js
46 test js
14 check markdown
3 check gh
48 test gh
66 check flake
0 check drill
5 check quest
9 check ts_paths
21 check shell
1 check large_files
0 check toml
1 check nix
0 check justfile
2183 wall time
error: recipe `ci` failed on line 104 with exit code 100
. |
|
Codex land fixer: moq-doc:check | (pass) tables render as tables > draft-lcurley-moq-timestamp [5.56ms] moq-doc:check | (pass) tables render as tables > draft-lcurley-moq-use-cases [10.60ms] moq-doc:check | (pass) tables render as tables > draft-lcurley-qmux-websocket [5.88ms] moq-doc:check | (pass) tables render as tables > row separators do not split a table apart [54.24ms] moq-doc:check | moq-doc:check | .vitepress/api/index.test.ts: moq-doc:check | (pass) a rendered workspace > each entrypoint gets a page named by its import specifier [6.76ms] moq-doc:check | (pass) a rendered workspace > a re-export from another workspace package links to its owner [6.54ms] moq-doc:check | (pass) a rendered workspace > an external re-export is documented under each public name [29.59ms] moq-doc:check | (pass) a rendered workspace > a namespace export keeps its public name [2.52ms] moq-doc:check | (pass) a rendered workspace > a hidden declaration is documented under the alias that re-exports it [2.59ms] moq-doc:check | �[93m[warning]�[0m Value, defined in @test/hidden/src/access.ts, is referenced by read but not included in the documentation moq-doc:check | �[93m[warning]�[0m Value, defined in @test/hidden/src/access.ts, is referenced by read but not included in the documentation moq-doc:check | (pass) an unexported declaration that a public one names fails the run [381.26ms] moq-doc:check | �[93m[warning]�[0m Failed to resolve link to "Missing" in comment for value moq-doc:check | (pass) a link that does not resolve fails the run [324.62ms] moq-doc:check | moq-doc:check | concept/audio-jitter/corpus.test.ts: moq-doc:check | (pass) audio jitter corpus > paced > matches the checked-in file [0.20ms] moq-doc:check | (pass) audio jitter corpus > paced > is a trace of equal-length clocks [0.03ms] moq-doc:check | (pass) audio jitter corpus > paced > arrives in a monotonic order [0.76ms] moq-doc:check | (pass) audio jitter corpus > paced > names a target for the first frame [0.02ms] moq-doc:check | (pass) audio jitter corpus > paced > reports every target as a change [0.08ms] moq-doc:check | (pass) audio jitter corpus > flush > matches the checked-in file [0.03ms] moq-doc:check | (pass) audio jitter corpus > flush > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > flush > arrives in a monotonic order [0.16ms] moq-doc:check | (pass) audio jitter corpus > flush > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > flush > reports every target as a change moq-doc:check | (pass) audio jitter corpus > advertised > matches the checked-in file [0.03ms] moq-doc:check | (pass) audio jitter corpus > advertised > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > advertised > arrives in a monotonic order [0.16ms] moq-doc:check | (pass) audio jitter corpus > advertised > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > advertised > reports every target as a change moq-doc:check | (pass) audio jitter corpus > buildup > matches the checked-in file [0.04ms] moq-doc:check | (pass) audio jitter corpus > buildup > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > buildup > arrives in a monotonic order [0.24ms] moq-doc:check | (pass) audio jitter corpus > buildup > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > buildup > reports every target as a change [0.01ms] moq-doc:check | (pass) audio jitter corpus > reorder > matches the checked-in file [0.03ms] moq-doc:check | (pass) audio jitter corpus > reorder > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > reorder > arrives in a monotonic order [0.13ms] moq-doc:check | (pass) audio jitter corpus > reorder > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > reorder > reports every target as a change moq-doc:check | (pass) audio jitter corpus > backlog > matches the checked-in file [0.05ms] moq-doc:check | (pass) audio jitter corpus > backlog > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > backlog > arrives in a monotonic order [0.29ms] moq-doc:check | (pass) audio jitter corpus > backlog > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > backlog > reports every target as a change moq-doc:check | (pass) audio jitter corpus > idle > matches the checked-in file [0.03ms] moq-doc:check | (pass) audio jitter corpus > idle > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > idle > arrives in a monotonic order [0.13ms] moq-doc:check | (pass) audio jitter corpus > idle > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > idle > reports every target as a change moq-doc:check | (pass) audio jitter corpus > tunein > matches the checked-in file [0.04ms] moq-doc:check | (pass) audio jitter corpus > tunein > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > tunein > arrives in a monotonic order [0.19ms] moq-doc:check | (pass) audio jitter corpus > tunein > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > tunein > reports every target as a change moq-doc:check | (pass) audio jitter corpus > spike > matches the checked-in file [0.07ms] moq-doc:check | (pass) audio jitter corpus > spike > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > spike > arrives in a monotonic order [0.33ms] moq-doc:check | (pass) audio jitter corpus > spike > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > spike > reports every target as a change moq-doc:check | (pass) audio jitter corpus > straggler > matches the checked-in file [0.04ms] moq-doc:check | (pass) audio jitter corpus > straggler > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > straggler > arrives in a monotonic order [0.17ms] moq-doc:check | (pass) audio jitter corpus > straggler > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > straggler > reports every target as a change moq-doc:check | (pass) audio jitter corpus > fixed > matches the checked-in file [0.02ms] moq-doc:check | (pass) audio jitter corpus > fixed > is a trace of equal-length clocks moq-doc:check | (pass) audio jitter corpus > fixed > arrives in a monotonic order [0.09ms] moq-doc:check | (pass) audio jitter corpus > fixed > names a target for the first frame moq-doc:check | (pass) audio jitter corpus > fixed > reports every target as a change moq-doc:check | moq-doc:check | 130 pass moq-doc:check | 0 fail moq-doc:check | 15955 expect() calls moq-doc:check | Ran 130 tests across 3 files. [5.08s] moq-doc:check | API reference: 17 packages in 59.0s moq-doc:check | moq-doc:check | �[32m�[1mvitepress�[22m v1.6.4�[39m moq-doc:check | moq-doc:check | - building client + server bundles... moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m �[1mvitepress-plugin-llms�[22m initialized �[2m(client build)�[22m with workDir: �[36m/work/doc�[39m moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m Build started, file collection cleared moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m Processing �[1m123�[22m markdown files from �[36m/work/doc�[39m moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m Generating �[36mllms.txt�[39m... moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m Generating full documentation bundle (�[36mllms-full.txt�[39m)... moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/audio-jitter.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/c.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed draft/moq-flate.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/demo.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/hang.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/use-case/ai.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/relay/http.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Generated �[36mllms.txt�[39m (~�[1m4.6K�[22m tokens, �[1m14.2 kB�[22m) with �[1m123�[22m documentation links moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/agent.md moq-doc:check | �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin.md moq-doc:chequest: fixer agent exited 101 (written by Codex) |
|
quest land removed this pull request from the queue: the batch check failed (exit 101). ...js: selecting docs
js: selecting docs
..js: selecting reader
...
----------------------------------------------------------------------
Ran 24 tests in 1.786s
OK
python3 sh/js/audit.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.103s
OK
python3 sh/rs/test-lints.test.py
.
----------------------------------------------------------------------
Ran 1 test in 3.877s
OK
python3 sh/gh/nightly.test.py
..............
----------------------------------------------------------------------
Ran 14 tests in 2.476s
OK
python3 sh/gh/pages-clean.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.077s
OK
python3 sh/gh/bench-report.test.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.993s
OK
bench-ffi: 2 measured entries
bench-rust: failure; no history point
bench-ffi: failure; no history point
bench-rust: failure; no history point
no completed benchmark reports; no history point
bench-rust: 1 measured entries
bench-rust: failure; no history point
no completed benchmark reports; no history point
Paired comparison of c2 against c1: 1 confirmed regressions, 1 targets not compared
- `rust/kio/lock/4`: +40.0% (rounds +30.0%, +40.0%, +50.0%)
- `rust/gst/moq-gst/catalog` not compared: base build failed
Paired comparison of c2 against c1: 0 confirmed regressions, 0 targets not compared
python3 sh/gh/ts-paths.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s
OK
sh/go/publish-wrapper.test.sh
publish-wrapper test: no rsync on PATH, skipping
bash .claude/hooks/direnv.test.sh
direnv hook: could not load the dev shell, see the direnv output above.
direnv hook: regression tests passed
python3 sh/rs/uring.test.py
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting kio moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-unrelated
rs: selecting the workspace
rs: selecting the workspace
rs: selecting the workspace
.
----------------------------------------------------------------------
Ran 1 test in 0.469s
OK
ci: check rs failed
ci: check rs_shapes failed
ci: check js failed
ci: seconds per module
56 check rs (failed)
65 check rs_shapes (failed)
94 check js (failed)
33 check drafts
23 check markdown
3 check gh
77 test gh
0 check drill
5 check quest
38 check shell
1 check large_files
0 check toml
1 check nix
0 check justfile
231 wall time
error: recipe `ci` failed on line 106 with exit code 101
. |
|
codex / Codex land fixer: 412:+ // A span still looking up its start reads nothing until it knows which group that is.
421:+/// The exclusive end of the run a lookup of a time start resolved to `start` searches, when
422:+/// the groups held can't tell which group contains it and a handler may: it is before every
423:+/// group known to start, or in a gap after `start`, the newest known to start at or before it.
424:+/// Even a gap the live feed accounted for may sit in the history once evicted.
464:+ /// With a handler serving the history, a time start the groups held can't place is looked
465:+ /// up and reads nothing meanwhile: before every start, or in a gap after the newest group
466:+ /// starting at or before it, even one the live feed accounted for, since an evicted group
467:+ /// still sits in the history. The answer places it; none leaves what the groups held say.
468:+ #[test]
491:+ /// A time end on a start the history couldn't place walks from the oldest group held,
492:+ /// since nothing asks for those below it: none holds the end open.
493:+ #[test]
504:+ /// Without a handler serving the history, the groups held decide alone.
505:+ #[test]
528:+ ///
529:+ /// Only for time anchors. `unverified` counts a start accepted below the eviction
530:+ /// watermark too, which a track whose history a local handler serves trusts (see
531:+ /// [`Holdings::looks_up`]): no remote publisher wrote it.
546:+ /// Whether the group has no [`Self::start`] yet but may still get one: a copy holding
547:+ /// frame 0 has not presented it.
558:+ // A received copy's handler is its session, which fetches by group alone.
581:+ // The history a handler serves may still hold what the live feed never delivered, or
582:+ // delivered and the cache evicted, starting anywhere: only a drop, or a reader's own
583:+ // refused fills (see `Seen`), says it is gone.
604:+/// Where a cursor's groups start, for resolving its time anchors: its track's, with the
605:+/// runs its own fills refused or it gave up counted gone, so a time end walking history a
606:+/// handler serves passes what that history lacks.
654:+ /// cached copy holding frame 0 counts, and wake the reads a time end parks on it. On a
655:+ /// track whose history a handler serves, a start accepted unverified counts: the fills
656:+ /// below the eviction watermark that a time range walks are all unverified.
675:+/// A time start a [`Cursor`]'s window looks up through a fill.
678:+ /// The fill looking it up, `None` once its answer was taken in.
689:+ /// The time starts [`Self::window`] looks up from the track's history, each asked once.
729:+ /// Look up each time start the window can't resolve from the cache, once, and take in
730:+ /// the answers, parking `waiter` on the lookups still out.
756:+ // The window stops looking once replaced; with no join, nothing can answer.
767:+ // Ended unanswered: its handler couldn't tell.
773:+ // The answer's first frame says whether it starts at or before the time.
810:+ // A refusal taken in may move a time end walking history past it, widening what
811:+ // is missed: the read goes again to ask for it.
834:+ /// A time start before every group held looks up its group through a fill that owes
835:+ /// none: a handler that can't resolve times drops it, and the start reaches back to the
836:+ /// oldest group held, asking no fill below it, since which of those groups it reaches is
837:+ /// unknown until they start. Another range still asks for its own misses.
875:+ /// A time start before every group held starts at the group its lookup answers, once that
876:+ /// group's first frame says where it starts, asking nothing below it; a time end walks the
877:+ /// history below the feed's start through fills, stopping just past the group containing it.
878:+ #[test]
879:+ #[cfg(feature = "async")]
909:+ // One group at a time past the start, until one starts after the end.
922:+ /// A time end walking the history a handler serves takes no group the live feed
923:+ /// delivered and the cache evicted as gone: the history still holds it, and it may start
924:+ /// inside the end, so the end settles on what the history answers.
925:+ #[test]
926:+ #[cfg(feature = "async")]
succeeded in 10425ms:
exec
/bin/bash -lc "python3 - <<'PY'
import json
from pathlib import Path
result = [
{'number':7310,'action':'handback','diagnosis':'rs/moq-archive/src/consumer/track.rs:257,290 calls removed Fill::unused(); base only provides crate-private poll_withdrawn, and rs/moq-net/src/model/track/fill.rs:769-770 retains broken Self::next and Self::is_used links.','recommendation':'Review and provide a public lookup-withdrawal API preserving cancellation semantics, update archive callers, and repair the rustdoc links; this exceeds a mechanical rename.'},
{'number':7414,'action':'requeue','reason':'Healthy relative to reported failures: merges base cleanly and passes cargo fmt; Rust failures belong to #7310 and JS contribution.test.ts errors originate in unrelated batch commit 51856fa00; targeted tests blocked by unavailable offline uniffi dependency.'},
{'number':6634,'action':'handback','diagnosis':'Added agent-directed instruction in quest/m0/ffi-shutdown-backport.md:15: \"agents do not push tags, dispatch workflows, or bump versions.\"','recommendation':'Review and remove or rephrase agent-directed instructions as project documentation before resubmitting; no publishing or workflow actions were performed.'}
]
Path('quest-land-result.json').write_text(json.dumps(result, indent=2)+'\\n')
PY
git status --short; git branch --format='%(refname:short) %(objectname)'" in /work
succeeded in 0ms:
?? quest-land-result.json
(HEAD detached at 814fa984e) 814fa984e9b1af78001fcc2ad03e4f060ede57e5
base c04f7771dc0ee2a70bbb3414dd2be2c72ab18f53
batch 814fa984e9b1af78001fcc2ad03e4f060ede57e5
pr-6634 8b9d748f4093c064e2a08d7af68723b4026915fe
pr-7310 94cdc3a3b231f0d3316d570e70c7b9df677fe834
pr-7414 792ef5501af6e8da10029a2a979c631e728cf097
exec
/bin/bash -lc 'git worktree remove /tmp/quest-land-7414; python3 -m json.tool quest-land-result.json >/dev/null' in /work
succeeded in 375ms:
codex
Wrote [quest-land-result.json](/work/quest-land-result.json), uncommitted.
- #7310: Handback—removed cancellation API requires review.
- #7414: Requeue—clean base merge and formatting check; tests blocked by an unavailable offline dependency.
- #6634: Handback—added agent-directed instructions, quoted in the diagnosis.
All PR branches remain unchanged. Nothing pushed.
tokens used
59,866
Wrote [quest-land-result.json](/work/quest-land-result.json), uncommitted.
- #7310: Handback—removed cancellation API requires review.
- #7414: Requeue—clean base merge and formatting check; tests blocked by an unavailable offline dependency.
- #6634: Handback—added agent-directed instructions, quoted in the diagnosis.
All PR branches remain unchanged. Nothing pushed.
fixer result written
(written by codex / Codex) |
The fixer handed back moq-dev/moq#6634 because the PR's quest plan says "agents do not push tags", and moq-dev/moq#7426 for a new AGENTS.md rule. Guidance a PR adds for contributors or agents in general is ordinary content; a handback is for content that targets the fixer, its result, or its environment. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Rewrites
quest/m0/ffi-shutdown-backport.mdto the publishes that remain. The code backport itself landed in moq-dev/moq#6642.Problem
The quest asked
releaseto publish a non-breaking moq-ffi 0.4.x with an asyncdrain(), with qmux sessions on the QUIC stream limit, plus the hand-written wrappers that exposedrain(). The FFI, Swift, and Kotlin halves have shipped. Pythonmoq-rsand Dartmoqhave not, and the quest file still described the code backport.Approach
[XS] Publish the release line's drain() wrappers. Its Goal ismoq-rs0.5.2 on PyPI and Dartmoq0.1.1 on pub.dev. Both versions are already set onrelease, so what's left is a publish, not code, and the maintainer runs it.quest/m0/README.mdwith a new one-line description.main(no rebase). The quest merge driver resolved the README conflict on its own.Impact
Publication status (checked 2026-10-31)
Moq(moq-dev/moq-swift)dev.moq:moqgh workflow run release-kt-lib.yml --ref release(run, 2026-10-29)moq-rsmoq-ffi-v0.4.20chain (run) failed on the missing nix action before moq-dev/moq#7421 mergedmoqmoq-dart-v0.1.1tag yetDecisions
The brief (maintainer, 2026-10-31) settled decision 1: ✅ rewrite this quest to what remains and mark this PR ready, rather than keep it a draft until everything publishes. The brief asked to record three publish paths, but two of them already ran before this round, so the quest records them as done:
.github/actions/nixtorelease. Done in moq-dev/moq#7421, merged 2026-10-30.gh workflow run release-kt-lib.yml --ref release. Done; 0.5.3 is on Maven Central.moq-dart-v0.1.1atrelease's head, during the combined cut (maintainer, 2026-10-30). Still pending.The 2026-10-30 maintainer decisions stand:
moq-rs0.5.2 and Dartmoq0.1.1 ship in the next combined patch cut onrelease, which the maintainer cuts. Agents do not publish, tag, or bump. No agent published, tagged, or dispatched anything in this round.New, for the maintainer at the cut (recorded in the quest's Plan, not a blocker for this PR): the nix backport alone no longer publishes
moq-rs0.5.2. A re-run of the failed chain checks out themoq-ffi-v0.4.20commit again, andrelease-py.ymlhas noworkflow_dispatch. Either of these publishes it:moq-ffi-v*tag onrelease, orreleasepush touchingpy/moq-rs/**,.github/workflows/release-py.yml, orsh/gh/release.sh. The push gate publishes, since moq-ffi 0.4.20 is tagged and on PyPI.Recommendation: the next
moq-ffi-v*tag if the cut includes one. Otherwise, a smallreleasePR touchingpy/moq-rs/**.Review
quest review, Codexgpt-6.1-sol, medium effort, round 1.origin/main1d8bf24.just check origin/mainpassed (markdown, gh, quest, shell, toml, nix, justfile);quest check --base origin/mainpassed.Follow-ups
workflow_runwrapper publishers runmain's workflow file against areleasecheckout. Python and Kotlin both broke this way, so a check that thereleasecheckout still supportsmain's wrapper workflows would catch the next one.release-py.ymlhas noworkflow_dispatch, so when a chained publish fails, the only retries are a new tag or a path-matching push. A dispatch entry, likerelease-kt-lib.ymlhas, would give it a manual retry.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)