Skip to content

ci: backport the nix action to release for Release Py - #7421

Merged
kixelated merged 1 commit into
releasefrom
backport/nix-action
Oct 30, 2026
Merged

kixelated merged 1 commit into
releasefrom
backport/nix-action

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

workflow_run runs the default branch's workflow file. Release Py starts when Release Py FFI completes for a moq-ffi-v* tag, so main's release-py.yml runs against the tag's release checkout. main's copy uses ./.github/actions/nix, which release does not have. That is why Release Py failed for moq-ffi-v0.4.19, and why Python moq-rs 0.5.2 is still unpublished (moq-dev/moq#6634, decision 2).

Approach

Copy main's .github/actions/nix/action.yml to release unchanged. The action installs Nix with accept-flake-config = true and names no cache of its own. On release it picks up the Cachix substituter that release's flake.nix names.

That was the only gap. No other main workflow with a workflow_run trigger uses a local action that release lacks. Each ./.github/actions/* they use was checked against origin/release.

Impact

  • Publishes nothing on merge. The only release push trigger that reacts to this path is Release Go, which runs on every push and skips when the mirror is unchanged. release-py.yml is untouched, so its own push trigger does not fire.
  • At the combined cut, the moq-ffi-v0.4.20 tag (release is already at 0.4.20) chains Release Py FFI into main's Release Py, which can now build and publish moq-rs 0.5.2. The maintainer cuts the release; this PR bumps nothing.

Validation

  • nix develop -c just check origin/release: passed (actionlint and the workflow coverage checks included).

Review

Codex gpt-6.1-sol, medium effort, via quest review --base origin/release, head c1fa24d902, round 1: no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

`workflow_run` runs main's release-py.yml against the release tag's checkout,
and main's copy uses ./.github/actions/nix, which release lacked. The action
only accepts the flake's own nixConfig, so on release it substitutes from the
Cachix cache release's flake names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T20:36:49.006438Z c1fa24d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: this copies main's .github/actions/nix to release unchanged, so main's Release Py can build against a release tag checkout. It publishes nothing on merge. Python moq-rs 0.5.2 goes out with the maintainer's combined cut, through the moq-ffi-v0.4.20 tag (see moq-dev/moq#6634). Local just check origin/release, quest check, and a Codex review of c1fa24d902 all passed with no findings.

(Written by Claude Opus 5.5)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: c1fa24d

No actionable bugs found. The unchanged backport of main's composite Nix action is a suitably minimal fix: main's Release Py workflow checks out the release-tag commit before resolving the local action, and this action accepts the release flake's existing Cachix configuration without duplicating its cache settings. No additional abstraction or workflow changes appear necessary for this fix.

Verification: static inspection of the patch, main's action and Release Py caller, and the release checkout's workflow and flake configuration. I did not run tests, install Nix, or execute the release/publishing workflow.

@kixelated
kixelated merged commit af61a27 into release Oct 30, 2026
19 checks passed
@kixelated
kixelated deleted the backport/nix-action branch October 30, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant