Repository navigation
ci: backport the nix action to release for Release Py - #7421
Conversation
`workflow_run` runs main's release-py.yml against the release tag's checkout, and main's copy uses ./.github/actions/nix, which release lacked. The action only accepts the flake's own nixConfig, so on release it substitutes from the Cachix cache release's flake names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: this copies (Written by Claude Opus 5.5) |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: c1fa24d
No actionable bugs found. The unchanged backport of main's composite Nix action is a suitably minimal fix: main's Release Py workflow checks out the release-tag commit before resolving the local action, and this action accepts the release flake's existing Cachix configuration without duplicating its cache settings. No additional abstraction or workflow changes appear necessary for this fix.
Verification: static inspection of the patch, main's action and Release Py caller, and the release checkout's workflow and flake configuration. I did not run tests, install Nix, or execute the release/publishing workflow.
Problem
workflow_runruns the default branch's workflow file. Release Py starts when Release Py FFI completes for amoq-ffi-v*tag, somain'srelease-py.ymlruns against the tag'sreleasecheckout.main's copy uses./.github/actions/nix, whichreleasedoes not have. That is why Release Py failed formoq-ffi-v0.4.19, and why Pythonmoq-rs0.5.2 is still unpublished (moq-dev/moq#6634, decision 2).Approach
Copy
main's.github/actions/nix/action.ymltoreleaseunchanged. The action installs Nix withaccept-flake-config = trueand names no cache of its own. Onreleaseit picks up the Cachix substituter thatrelease'sflake.nixnames.That was the only gap. No other
mainworkflow with aworkflow_runtrigger uses a local action thatreleaselacks. Each./.github/actions/*they use was checked againstorigin/release.Impact
releasepush trigger that reacts to this path is Release Go, which runs on every push and skips when the mirror is unchanged.release-py.ymlis untouched, so its own push trigger does not fire.moq-ffi-v0.4.20tag (releaseis already at 0.4.20) chains Release Py FFI intomain's Release Py, which can now build and publishmoq-rs0.5.2. The maintainer cuts the release; this PR bumps nothing.Validation
nix develop -c just check origin/release: passed (actionlint and the workflow coverage checks included).Review
Codex
gpt-6.1-sol, medium effort, viaquest review --base origin/release, headc1fa24d902, round 1: no findings.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)