Repository navigation
ci: gate release PRs behind one Release gate context on release - #6733
Conversation
Backports #6154 onto release's own workflow set, so the release ruleset can require `Release gate` now instead of after the next cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: a353e96
No actionable bugs found against the current release base. Consolidating path-selected workflows behind one failure-propagating required context is a sensible adaptation; existing PR dry-run conditions remain effective through workflow_call, and caller permissions cover current nested jobs.
Integration note: when combining this with #6730, add actions: read to the Kotlin and Swift wrapper calls in release-gate.yml, matching their new ffi-release jobs.
Verification limits: static review and GitHub status inspection only. Scope completed but selected checks were still running or queued; I did not run tests or verify the ruleset change.
Gate release-go-ffi on the shared FFI paths that #6730 added to its removed pull_request trigger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23744b773c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 23744b7
The prior #6730 integration warning is now an active blocker after merging release: .github/workflows/release-gate.yml:283–293 must grant contents: read and actions: read to Kotlin and Swift wrapper calls, matching their new ffi-release jobs. Confirmed the existing identical finding #6733 (comment) rather than duplicating inline.
The consolidated gate remains sensible; added shared-FFI paths preserve Go dry-run coverage. No additional actionable bugs found in this update.
Verification: static comparison against previous review and current release base; no tests run locally. Release gate https://github.com/moq-dev/moq/actions/runs/40209900715 reports startup_failure at this head.
#6730 added ffi-release jobs that read upstream run jobs, and a called workflow cannot raise the caller's token permissions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: f4d6319
The permission blocker #6733 (comment) is fixed: both Kotlin and Swift wrapper calls grant contents: read and actions: read, matching nested publisher-check jobs. This is a minimal, scoped fix. No new actionable bugs found.
Verification: static comparison against last reviewed 23744b7; no tests run locally. Runtime workflow success remains unverified.
Problem
The release ruleset should require one
Release gatecontext besideCheck(quest/m0/ci/release-gates.md).release-gate.ymllanded onmainin moq-dev/moq#6154, but a release PR runs the workflows merged withrelease, so the context cannot be required untilreleasecarries it. The maintainer chose to backport it now rather than wait for the next cut (2026-10-22).Approach
A straight cherry-pick of moq-dev/moq#6154 conflicts in nearly every file:
releasepredates themain-side CI split and lacks Features, C++, TS, io_uring, Video, X11, moq.sh, OSS Scanner, and Runner VM. So this ports the same design onto the workflowsreleasehas:release-gate.ymlruns on every release PR. ItsScopejob diffs withdorny/paths-filter(same pinned SHA asmain) and calls each workflow whose paths match; theRelease gatejob fails when any call or the scope failed or was cancelled, and passes skips.pull_requesttrigger and theirclosedguards, and gainworkflow_callwhere missing. Their path lists move verbatim into the gate's filter; a local script confirmed each filter equals the removedpaths.release, rather than always called as onmain. Swift exists only onreleaseand is called like the rest.id-token: writefor Interop, Dart, JS;contents: writefor Dart FFI). No secrets are passed: none of these workflows read one on a PR.alert.yml,nightly.yml,obs.yml, andsh/obs/compile.shthat pointed at the per-workflow filters now point at the gate.This PR adds the gate, so it runs
Release gateon itself.Impact
Release gate(GitHub Actions, integration 15368) to release ruleset 24392632 besideCheck, then edits the title of each open release PR soeditedreruns the gate.release-gate.yml); takemain's side throughout.Merged with #6730
releaseafter moq-dev/moq#6730 dropped Go FFI's restoredpull_requesttrigger and moved its two new paths (release-shared-ffi.yml,sh/gh/ffi*) into the gate'srelease-go-ffifilter.contents: readandactions: read, which ci: build shared FFI artifacts once on release (backport #5549) #6730'sffi-releasejobs need (the gate hitstartup_failurewithout it).Alternatives
main's file: rejected by the maintainer on 2026-10-22.main'srelease-gate.ymlverbatim: it calls nine workflowsreleasedoes not have, so every run would fail at startup.sh/gh/queue.test.ts:releasehas neither it nor the policy it encodes, and the cut brings both.Checks
just check: pass (actionlint, alert coverage, check-runs)just gh check: passneedsentry line up; no workflow butcheck.ymlandrelease-gate.ymltakespull_request; each filter matches the removedpathsexactly.Follow-ups
None.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code