Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/alert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ on:
workflow_run:
# Matched by workflow `name:`, not filename. Every workflow that can run
# outside a pull request belongs here; the pull-request-only ones (Check,
# Android) are omitted so they don't spawn a skipped Alert run on every
# push to every PR. `just gh check` enforces both halves of that.
# Release gate, and what only it calls, like Android) are omitted so they
# don't spawn a skipped Alert run on every push to every PR. `just gh check`
# enforces both halves of that.
#
# Swift, OBS, and Platform are here despite also running on pull requests:
# Swift warms its own Rust cache on `main`, and OBS and Platform build every
# merge to `main` and `dev`. Those push runs are nobody's check, so a break in them
# would otherwise go unseen. The cost is a skipped Alert run per pull
# request.
# would otherwise go unseen.
workflows:
- apt-repo
- Cache
Expand Down
33 changes: 5 additions & 28 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,38 +11,16 @@ name: Android
# recipe is still `just rs android`, so a local run and this one compile the
# same thing, and rust-toolchain.toml still pins the compiler.
#
# Narrow trigger, like wasm.yml. The filter is moq-video's in-repo dependency
# graph (`cargo metadata`, normal dependencies), plus the files that decide how
# it is built. A crate added to that graph has to be added here too.
# Narrow trigger, like wasm.yml. release-gate.yml's filter is moq-video's
# in-repo dependency graph (`cargo metadata`, normal dependencies), plus the
# files that decide how it is built. A crate added to that graph has to be
# added there too.

permissions:
contents: read

on:
pull_request:
# `closed` is here only so merging/closing a PR cancels its in-flight run
# via the concurrency group below; the job itself is skipped on close.
types: [opened, synchronize, reopened, closed]
paths:
- "rs/moq-video/**"
- "rs/moq-mux/**"
- "rs/moq-net/**"
- "rs/moq-nvenc/**"
- "rs/moq-loc/**"
- "rs/moq-msf/**"
- "rs/moq-json/**"
- "rs/moq-binary/**"
- "rs/moq-flate/**"
- "rs/moq-pattern/**"
- "rs/hang/**"
- "rs/kio/**"
- "rs/justfile"
- "justfile"
- ".cargo/config.toml"
- "Cargo.toml"
- "Cargo.lock"
- "rust-toolchain.toml"
- ".github/workflows/android.yml"
workflow_call:

concurrency:
group: android-${{ github.ref }}
Expand All @@ -54,7 +32,6 @@ env:
jobs:
android:
name: Android
if: github.event.action != 'closed'
# x86_64 rather than the arm runners check.yml uses: GitHub documents the
# Android SDK and NDK as preinstalled on this image.
runs-on: ubuntu-24.04
Expand Down
13 changes: 1 addition & 12 deletions .github/workflows/audio-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,7 @@ name: Audio quality
# consumer and rings on a simulated clock, so they are deterministic and take
# seconds, unlike the browser rows, which stay in nightly.yml.
on:
pull_request:
paths:
- "js/watch/**"
# The container consumer decides what a replay delivers, waits for, and skips, on the
# groups, tracks, and signals underneath it.
- "js/hang/**"
- "js/net/**"
- "js/signals/**"
- "test/audio-quality/**"
- "test/lib/**"
- "test/justfile"
- ".github/workflows/audio-quality.yml"
workflow_call:

concurrency:
group: audio-quality-${{ github.ref }}
Expand Down
17 changes: 2 additions & 15 deletions .github/workflows/interop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,8 @@ on:
# Nightly: catch an interop regression in the current tree before a user does.
schedule:
- cron: "0 8 * * *"
# On PRs that touch the harness itself, so a change to the interop test is
# validated before it merges. Source regressions still surface nightly.
pull_request:
paths:
- "test/lib/**"
- "test/interop/**"
# The TS/IRD compliance harness runs in the same job (see below).
- "test/ts/**"
# The interop job also depends on the recipe that invokes it and the
# workspace membership that links the JS clients to source.
- "test/justfile"
- "package.json"
# The Go client builds against the modules this script stages.
- "sh/go/**"
- ".github/workflows/interop.yml"
# release-gate.yml, on PRs that touch the harness.
workflow_call:

concurrency:
group: interop-${{ github.ref }}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ name: Nightly
# different reason: it compiles the workspace at feature sets that share almost
# no artifacts with the default one, which is several minutes of duplicate work
# that a PR gate can't justify for how rarely it catches something. `obs` is
# diff-independent because its PR-time counterpart can't be: obs.yml has to
# name the paths that can break an external link to libmoq.a, and no list of
# paths covers every one of them (see the comment there).
# diff-independent because its PR-time counterpart can't be: release-gate.yml's
# OBS filter has to name the paths that can break an external link to
# libmoq.a, and no list of paths covers every one of them (see obs.yml).
#
# The `release-*` jobs are diff-independent because the release workflows only
# ever run on a tag: a change that compiles under plain cargo can still break a
Expand Down Expand Up @@ -150,8 +150,8 @@ jobs:

# The OBS plugin and libmoq's C fixtures are the only things that link
# libmoq.a from outside cargo, so a stale `rs/libmoq/native-libs/*.txt`
# breaks them and nothing else. obs.yml lists the inputs that can do that,
# but a list of paths can't be complete: a build script emitting
# breaks them and nothing else. release-gate.yml's OBS filter lists the
# inputs that can do that, but a list of paths can't be complete: a build script emitting
# `cargo::rustc-link-lib` needs no manifest change, and widening that
# filter to `rs/**` would run a link on nearly every PR. Being
# diff-independent, this run covers whatever the filter misses, at the
Expand Down
32 changes: 7 additions & 25 deletions .github/workflows/obs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ name: OBS
# A list of paths still can't be complete here -- a vendored C source or a
# .cargo/config.toml could do it too -- and `rs/**` would run this on nearly
# every PR, which is the cost that removed the Windows and macOS gates (#2600).
# So this filter covers the likely inputs at PR time, and pushes to `main` and
# `dev` rebuild on any Rust or plugin change to cover the rest. nightly.yml also
# So release-gate.yml's filter covers the likely inputs at PR time, and pushes
# to `main` and `dev` rebuild on any Rust or plugin change to cover the rest. nightly.yml also
# runs the Linux recipe diff-independently.

permissions:
Expand All @@ -60,36 +60,19 @@ on:
- "flake.nix"
- "flake.lock"
- ".github/workflows/obs.yml"
pull_request:
# `closed` is here only so merging/closing a PR cancels its in-flight run
# via the concurrency group below; the job itself is skipped on close.
types: [opened, synchronize, reopened, closed]
paths:
- "cpp/obs/**"
- "sh/obs/**"
- "rs/libmoq/**"
- "doc/lib/c/**"
- "doc/lib/samples.sh"
- "rs/**/Cargo.toml"
- "rs/**/build.rs"
- "Cargo.toml"
- "Cargo.lock"
- "rust-toolchain.toml"
- "flake.nix"
- "flake.lock"
- ".github/workflows/obs.yml"
# Pull requests, through release-gate.yml.
workflow_call:

# Keyed and cancelled like platform.yml: a merged PR's `closed` run must not
# cancel the push run it triggers, and `main` merges faster than a push run
# finishes, so pushes queue rather than cancel.
# Keyed and cancelled like platform.yml: a PR's run must not cancel a push run,
# and `main` merges faster than a push run finishes, so pushes queue rather
# than cancel.
concurrency:
group: obs-${{ github.event_name }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
name: OBS
if: github.event.action != 'closed'
runs-on: ubuntu-24.04-arm
timeout-minutes: 60

Expand Down Expand Up @@ -136,7 +119,6 @@ jobs:
# comes from buildspec.json at configure time, same as a tag build.
release:
name: OBS (${{ matrix.name }})
if: github.event.action != 'closed'
runs-on: ${{ matrix.os }}
timeout-minutes: 60
strategy:
Expand Down
22 changes: 3 additions & 19 deletions .github/workflows/platform.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,25 +36,11 @@ on:
- "justfile"
- "sh/**"
- ".github/workflows/platform.yml"
pull_request:
# `closed` is here only so merging/closing a PR cancels its in-flight run
# via the concurrency group below; the jobs themselves are skipped on close.
types: [opened, synchronize, reopened, closed]
paths:
- "rs/**"
- ".cargo/**"
- "Cargo.toml"
- "Cargo.lock"
- "rust-toolchain.toml"
- "justfile"
- "sh/**"
- ".github/workflows/platform.yml"
# Pull requests, through release-gate.yml.
workflow_call:

concurrency:
# Keyed by event, so a merged pull request's `closed` run can't cancel the push
# run it triggers. Pull requests key by number rather than ref, since a merged
# PR's `closed` run can report the base branch as its ref instead of the PR's
# merge ref, and then wouldn't cancel the PR's in-flight run.
# Keyed by event, so a pull request's run can't cancel a push run.
group: platform-${{ github.event_name }}-${{ github.event.pull_request.number || github.ref }}
# Pushes queue instead: `main` merges faster than these jobs finish, so
# cancelling meant almost no push run ever reported. Actions keeps only the
Expand All @@ -64,7 +50,6 @@ concurrency:
jobs:
windows:
name: Windows
if: github.event.action != 'closed'
runs-on: windows-latest
timeout-minutes: 60

Expand Down Expand Up @@ -96,7 +81,6 @@ jobs:

macos:
name: macOS
if: github.event.action != 'closed'
runs-on: macos-latest
timeout-minutes: 60

Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/release-dart-ffi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,6 @@ on:
# workflow this way so a broken build surfaces before the tag is cut.
workflow_call:
workflow_dispatch:
# Packaging changes only, like the other FFI release workflows. A change to
# the moq-ffi sources is covered on every platform by cheaper gates: check.yml
# compiles it and regenerates the Dart bindings, platform.yml and swift.yml
# compile it for macOS, Windows, and iOS, and nightly runs this full matrix.
pull_request:
paths:
- ".github/workflows/release-dart-ffi.yml"
- ".github/workflows/release-ffi.yml"
- "dart/moq_ffi/**"
- "sh/dart/**"
- "rs/moq-ffi/build.sh"

permissions:
contents: read
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/release-dart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@ on:
push:
tags:
- "moq-dart-v*"
pull_request:
paths:
- ".github/workflows/release-dart.yml"
- "dart/moq/**"
- "sh/dart/**"
# Dry-run: check the source package, publish nothing. Only a tag push
# publishes; release-gate.yml calls this on pull requests.
workflow_call:

permissions:
contents: read
Expand Down
Loading
Loading