Repository navigation
fix(ci): let the Kotlin wrapper publish after Release FFI - #7026
Conversation
Quest-Claim: 2806da0d52898582
`inputs.dry-run` is null outside workflow_call, so the publish job's `cancel-in-progress` evaluated to '' and failed the job on the first shared FFI release (moq-ffi-v0.4.19). Compare against `true` explicitly. The first shared release verified the rest: every wrapper saw its publisher under the workflow_run token, and the Go and Swift wrappers published from the shared artifacts. Delete the verification quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
WalkthroughThe release workflow now uses per-ref concurrency for pull requests and explicit dry runs, with cancellation enabled in those cases. Other runs use the shared publish group without cancellation. The CI plan and C++ FFI quest no longer reference the first shared FFI release, and its release-verification quest has been removed. Priority: Merge Risk:
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit c16738d3d40420d8385e26d9f01baf65b2673b24.
No actionable bugs found. The explicit boolean comparison makes cancel-in-progress false when the reusable-workflow input is absent, while retaining cancellation and per-ref grouping for PRs and typed dry-runs. Real publishing runs remain serialized, and the upstream trust/version gates are unchanged.
Direction: this is a suitably narrow fix rather than another publication path. Verification: static inspection of the workflow, input declaration, publication conditions and quest cleanup. I did not run actionlint or Actions, or independently verify the reported releases; the corrected workflow_run path remains untested by this review.
|
Merge summary: merged (Written by Claude Opus 5.5) |
Verifies the first shared FFI release and fixes the one failure it found.
Summary
moq-ffi-v0.4.19is the first tag cut after the backport moq-dev/moq#6730, and itsRelease FFIrun succeeded: each target built once, and the Go, Kotlin and Swift FFI packagers reused those artifacts (their own build and bindings jobs were skipped). No standaloneRelease Go/Kotlin/Swift FFIruns fired for the tag.Wrappers, triggered by
workflow_run:moq-dev/moq-go@v0.7.19moq-dev/moq-swift@0.5.2dev.moq:moq:0.5.3FFI packages:
moq-dev/moq-go-ffi@v0.4.19andmoq-dev/moq-swift-ffi@0.4.19are tagged;dev.moq:moq-ffi:0.4.19was submitted to Maven Central ("Deployment is being published") and was still propagating when checked.Fix:
inputs.dry-runis null outsideworkflow_call, so thepublishjob'scancel-in-progress: ${{ github.event_name == 'pull_request' || inputs.dry-run }}evaluated to''. moq-dev/moq#6038 introduced it onmainonly;release's copy predates the input, butworkflow_runalways runsmain's file. Comparing againsttruemakes null false. It is the onlycancel-in-progressthat readsinputs.The quest is deleted, with its links.
Impact
No public API or wire impact. CI only.
Checks
just checkandactionlintpass. Theworkflow_runpath cannot run before merge; the nextmoq-ffi-v*tag exercises it.Decisions
Settled by the maintainer in a /quest-complete session:
dev.moq:moq:0.5.3now, rather than waiting for the nextmoq-ffi-v*tag.dev.moq:moq-ffi:0.4.19was confirmed on Maven Central, thengh workflow run release-kt-lib.yml --ref releasewas dispatched: run 40904381781 succeeded. Its guard sawdev.moq:moq:0.5.3: exists=false, and "Publish to Maven Central" uploaded the bundle (deployment74e4a934-e248-4735-89eb-09e02e732175, "Deployment is being published to Maven Central"). The fixedworkflow_runpath is still unexercised until the next tag.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code