Skip to content

fix(ci): let the Kotlin wrapper publish after Release FFI - #7026

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/ci/nightly-ffi-reuse
Oct 30, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/ci/nightly-ffi-reuse

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Verifies the first shared FFI release and fixes the one failure it found.

Summary

moq-ffi-v0.4.19 is the first tag cut after the backport moq-dev/moq#6730, and its Release FFI run succeeded: each target built once, and the Go, Kotlin and Swift FFI packagers reused those artifacts (their own build and bindings jobs were skipped). No standalone Release Go/Kotlin/Swift FFI runs fired for the tag.

Wrappers, triggered by workflow_run:

Wrapper Publisher seen Result
Release Go yes published moq-dev/moq-go@v0.7.19
Release Swift lib yes published moq-dev/moq-swift@0.5.2
Release Kotlin lib yes, decided to publish dev.moq:moq:0.5.3 failed: "Error when evaluating 'concurrency' for job 'publish'"

FFI packages: moq-dev/moq-go-ffi@v0.4.19 and moq-dev/moq-swift-ffi@0.4.19 are tagged; dev.moq:moq-ffi:0.4.19 was submitted to Maven Central ("Deployment is being published") and was still propagating when checked.

Fix: inputs.dry-run is null outside workflow_call, so the publish job's cancel-in-progress: ${{ github.event_name == 'pull_request' || inputs.dry-run }} evaluated to ''. moq-dev/moq#6038 introduced it on main only; release's copy predates the input, but workflow_run always runs main's file. Comparing against true makes null false. It is the only cancel-in-progress that reads inputs.

The quest is deleted, with its links.

Impact

No public API or wire impact. CI only.

Checks

just check and actionlint pass. The workflow_run path cannot run before merge; the next moq-ffi-v* tag exercises it.

Decisions

Settled by the maintainer in a /quest-complete session:

  1. Publish dev.moq:moq:0.5.3 now, rather than waiting for the next moq-ffi-v* tag. dev.moq:moq-ffi:0.4.19 was confirmed on Maven Central, then gh workflow run release-kt-lib.yml --ref release was dispatched: run 40904381781 succeeded. Its guard saw dev.moq:moq:0.5.3: exists=false, and "Publish to Maven Central" uploaded the bundle (deployment 74e4a934-e248-4735-89eb-09e02e732175, "Deployment is being published to Maven Central"). The fixed workflow_run path is still unexercised until the next tag.
  2. No follow-up quest to verify the fix on the next tag; a wrong fix fails loudly there.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 27, 2026 23:36
`inputs.dry-run` is null outside workflow_call, so the publish job's
`cancel-in-progress` evaluated to '' and failed the job on the first
shared FFI release (moq-ffi-v0.4.19). Compare against `true` explicitly.

The first shared release verified the rest: every wrapper saw its
publisher under the workflow_run token, and the Go and Swift wrappers
published from the shared artifacts. Delete the verification quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title First shared FFI release fix(ci): let the Kotlin wrapper publish after Release FFI Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 29, 2026 15:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T00:20:52.045364Z 8b14110 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Walkthrough

The release workflow now uses per-ref concurrency for pull requests and explicit dry runs, with cancellation enabled in those cases. Other runs use the shared publish group without cancellation. The CI plan and C++ FFI quest no longer reference the first shared FFI release, and its release-verification quest has been removed.

Priority: Normal

Merge Risk: Minimal · up to 8b141

The release concurrency fix is mergeable, with no remaining actionable risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the change: a CI fix so the Kotlin wrapper publishes after Release FFI. The objectives say the fix compares inputs.dry-run with true so cancel-in-progress no longer evaluates to an emp…
Description check Passed The description states the purpose: verify the first shared FFI release and fix the failure it exposed. It explains the failing Kotlin wrapper run, the null inputs.dry-run cause, the one-line fix in t…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a CI fix so the Kotlin wrapper publishes after Release FFI. The objectives say the fix compares inputs.dry-run with true so cancel-in-progress no longer evaluates to an empty string in the release-kt-lib publish job. The title matches the main change and is specific, so the check passes.

Full details: Description check

Explanation

The description states the purpose: verify the first shared FFI release and fix the failure it exposed. It explains the failing Kotlin wrapper run, the null inputs.dry-run cause, the one-line fix in the release-kt-lib publish job, the deleted quest, the testing done, and a manual Kotlin publish run. It relates directly to the changeset, so the check passes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit c16738d3d40420d8385e26d9f01baf65b2673b24.

No actionable bugs found. The explicit boolean comparison makes cancel-in-progress false when the reusable-workflow input is absent, while retaining cancellation and per-ref grouping for PRs and typed dry-runs. Real publishing runs remain serialized, and the upstream trust/version gates are unchanged.

Direction: this is a suitably narrow fix rather than another publication path. Verification: static inspection of the workflow, input declaration, publication conditions and quest cleanup. I did not run actionlint or Actions, or independently verify the reported releases; the corrected workflow_run path remains untested by this review.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: merged main (6f3f2e4) into the branch to clear the conflict; the merge needed no hand resolution, so the OpenAI review of c16738d (no findings) and Codex's thumbs-up still cover it. quest check --base origin/main passes. Decisions were settled in the /quest-complete session (see PR body); no follow-ups. Queuing 8b14110.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 30, 2026 00:20
@kixelated
kixelated added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 9a1cafb Oct 30, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/ci/nightly-ffi-reuse branch October 30, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant