Skip to content

refactor(net): limit IETF publishers to one-group history - #7204

Merged
kixelated merged 11 commits into
mainfrom
quest/m1/ietf-publisher-one-group
Oct 30, 2026
Merged

kixelated merged 11 commits into
mainfrom
quest/m1/ietf-publisher-one-group

Conversation

@kixelated

@kixelated kixelated commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Serving moq-transport ranges requires authoritative knowledge of every group. Limit our publishers to one-group history while preserving subscriber range requests. A refused fill can lose FETCH_HEADER on reset, so the old subscriber fill slot could permanently block later widening.

Approach

  • Rust and JS refuse multi-group FETCH before FETCH_OK, retain one-group and joining-head responses, and serve draft-22 fills only for the largest group's head. Unsupported fills reset their own stream; FILL_TIMEOUT is accepted and ignored, including zero.
  • Remove publisher range paths, private model helpers, and JS timeout machinery. Adapt subscriber range-response tests to scripted upstreams and narrow publisher fixtures and benchmarks. Retain the JS End of Range codec.
  • Give each widening fill its own receive state. Atomically retire an unidentified predecessor, preserve active head ownership, and reject delayed headers belonging to superseded requests.
  • Merge current main, remove its newly added multi-group fill eviction test with the unsupported path, and remove the completed quest and its links.

Impact

  • Public API: no supported API changes. The hidden fuzz::fill_groups benchmark hook is removed with its private implementation.
  • Wire: multi-group FETCH gets NOT_SUPPORTED; unsupported fills reset after FETCH_HEADER without ending SUBSCRIBE; FILL_TIMEOUT is ignored. Object layouts and version negotiation are unchanged.
  • Subscriber range FETCH and multi-group fill request shapes remain unchanged. The ownership fix adds no wire fields or negotiation changes.

Alternatives

Keep authoritative range-serving machinery, or change subscriber requests to individual groups. Both contradict the settled scope. Permanently blocking widening after an unidentifiable reset is also rejected.

Decisions settled

  • ✅ Under the user's /afk authorization, adopt the draft's recommended narrow subscriber fill-ownership fix. Keep range requests unchanged.
  • ✅ Keep compatibility pin remeasurement with moq-dev/moq#7061.

Validation

  • Reproduced draft22_updates_both_bounds_across_cached_groups at 5b2485fb4749dbed31e13eb9229b694d3956a5a7 before code changes: final live group was None instead of Some(6). The unchanged case now passes.
  • All 3,139 enabled moq-net tests passed; 12 skipped. Includes delayed initial/update headers and an old handler waiting for REQUEST_OK.
  • JS publisher/FETCH: 134 passed. Net TypeScript, examples, benchmarks, Biome, Rust formatting, quest validation, and diff checks passed.
  • just ci passed, including 8,986 Rust tests (96 skipped), all selected JS checks/tests, feature extremes, isolated boundaries, docs, and repository tooling.
  • just test interop --all passed in full: all nine Rust/JS protocol tests, every language client, authorization controls, finished streams, tails, compression, and resets.
  • Both ran with the pinned Nix toolchain and BASH_ENV disabled after the local Cargo-cache wrapper failed with Argument list too long.
  • Compatibility preflight confirms stale planned pins: moq-cli 0.14.8 versus published 0.14.9. Pins are unchanged; remeasurement stays with the existing PR above.
  • The earlier JS fill benchmark completed its cached-groups × subscribers sweep.

Follow-ups

No new quests. Compatibility remeasurement remains with its existing PR.

(Written by GPT-6.1 Sol)

kixelated and others added 3 commits October 28, 2026 22:12
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated kixelated changed the title Our moq-transport publishers serve at most one group refactor(net): limit IETF publishers to one-group history Oct 29, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Design change: Under the user’s AFK authorization, extend the settled publisher-only scope to the recommended narrow subscriber fill-ownership fix. Range FETCH and multi-group fill requests remain unchanged.

Reproduced at 5b2485fb4749dbed31e13eb9229b694d3956a5a7: draft22_updates_both_bounds_across_cached_groups fails with None instead of live group Some(6) after the second widening. A reset can discard FETCH_HEADER and leave the old fill pending forever.

Each widening now reserves its own fill state and retires a pending predecessor atomically. A delayed initial header, a retired update header, or a handler already waiting on an old answer cannot claim the new slot. An identified stream writing or holding a head retains ownership until handoff. No message fields, object layouts, or version negotiation change. Compatibility pin remeasurement remains with moq-dev/moq#7061.

(Written by GPT-6.1 Sol)

kixelated and others added 4 commits October 29, 2026 07:46
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 29, 2026 15:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T00:49:45.556281Z 8dd3592 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 27caa7a

No confirmed actionable functional bugs found. The one-group publisher scope is implemented without removing subscriber range reception; wider FETCH requests are refused before FETCH_OK and unsupported fills fail on their own stream. Per-request fill state prevents retired headers from taking a newer slot, while Active/Ready heads still defer a competing widening. Removing publisher-only range/timeout machinery is consistent with the documented scope; ignored FILL_TIMEOUT and reduced historical recovery are intentional compatibility trade-offs, not unchanged behavior.

Nonblocking coverage recommendations:

  • Retain js/net/src/ietf/publisher.test.ts's deleted “subscriber max age and REQUEST_UPDATE preserve omitted preferences” test. That behavior remains supported and is unrelated to removing range serving.
  • Add a case where the live tail is already parked on an unidentified fill when a widening supersedes it, then deliver the replacement fill and subsequent tail objects. The new delayed-header cases do not establish this ordering's behavior.

Verification limits: GitHub-only static review of publisher/subscriber changes, removed model helpers, and relevant tests, with independent Rust subscriber and JS publisher passes. No builds, tests, interop runs, compatibility remeasurement or benchmarks executed; reported results were not independently reproduced.

(Written by OpenAI)

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3a56952d-08f9-4ed6-bb56-f6943f88d864
Commits

Reviewing files that changed from the base of the PR and between 27caa7a and 8dd3592.

Files selected for processing: 24
  • doc/concept/standard.md
  • js/net/bench/fills.ts
  • js/net/src/ietf/fetch.test.ts
  • js/net/src/ietf/publisher.test.ts
  • js/net/src/ietf/publisher.ts
  • quest/m1/README.md
  • quest/m1/ietf-epoch-cut.md
  • quest/m1/ietf-publisher-one-group.md
  • quest/m1/ietf-publisher-unknown-range.md
  • quest/m1/ietf-tracks-refuse.md
  • quest/m1/interop-coverage/js-ietf-fetch.md
  • quest/m1/subscribe-ranges/README.md
  • quest/m2/ietf-hole-marker.md
  • rs/moq-net/benches/session/mod.rs
  • rs/moq-net/src/fuzz.rs
  • rs/moq-net/src/ietf/publisher.rs
  • rs/moq-net/src/ietf/subscriber.rs
  • rs/moq-net/src/model/resume.rs
  • rs/moq-net/src/model/track.rs
  • rs/moq-net/src/model/track/fill.rs
  • rs/moq-net/src/test_interop.rs
  • rs/moq-net/tests/integration/route_change.rs
  • rs/moq-net/tests/integration/subscribe_ranges.rs
  • rs/moq-net/tests/integration/warm_backfill.rs

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 66fb60af-98de-468c-baf6-4403db2e63d4
Commits

Reviewing files that changed from the base of the PR and between 66bdbb9 and 27caa7a.

Files selected for processing: 24
  • doc/concept/standard.md
  • js/net/bench/fills.ts
  • js/net/src/ietf/fetch.test.ts
  • js/net/src/ietf/publisher.test.ts
  • js/net/src/ietf/publisher.ts
  • quest/m1/README.md
  • quest/m1/ietf-epoch-cut.md
  • quest/m1/ietf-js-join.md
  • quest/m1/ietf-publisher-one-group.md
  • quest/m1/ietf-tracks-refuse.md
  • quest/m1/interop-coverage/js-ietf-fetch.md
  • quest/m1/subscribe-ranges/README.md
  • quest/m2/ietf-hole-marker.md
  • rs/moq-net/benches/session/mod.rs
  • rs/moq-net/src/fuzz.rs
  • rs/moq-net/src/ietf/publisher.rs
  • rs/moq-net/src/ietf/subscriber.rs
  • rs/moq-net/src/model/resume.rs
  • rs/moq-net/src/model/track.rs
  • rs/moq-net/src/model/track/fill.rs
  • rs/moq-net/src/test_interop.rs
  • rs/moq-net/tests/integration/route_change.rs
  • rs/moq-net/tests/integration/subscribe_ranges.rs
  • rs/moq-net/tests/integration/warm_backfill.rs
Files with no reviewable changes: 8
  • quest/m1/ietf-epoch-cut.md
  • quest/m1/ietf-tracks-refuse.md
  • rs/moq-net/src/fuzz.rs
  • quest/m1/README.md
  • quest/m1/ietf-publisher-one-group.md
  • rs/moq-net/src/model/track/fill.rs
  • rs/moq-net/src/model/resume.rs
  • rs/moq-net/src/model/track.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

Rust and JavaScript publishers now limit FETCH and draft-22 fills to one group. They refuse unsupported multi-group requests and accept but ignore FILL_TIMEOUT. Rust subscriber fill updates now track request ownership and reject delayed fill headers for superseded requests. Tests, benchmarks, integration coverage, and documentation now reflect these behaviors.

Priority: Normal

Merge Risk: Minimal · previous review 27caa

This change limits IETF publishers to one-group history and gives each subscriber fill update its own ownership state. The review found no concrete merge-blocking issue. Normal CI and interop checks remain the final gate.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: limiting IETF publisher history to one group.
Description check Passed The description directly explains the one-group history restriction, subscriber ownership fix, wire behavior, implementation scope, and validation results.
Docstring Coverage Passed Docstring coverage is 86.67% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentati…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 86.67% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 15 functions across 9 files. (7 skipped: 5 unsupported, 2 too large.)

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

kixelated and others added 2 commits October 29, 2026 17:47
Resolve conflicts: keep the one-group FETCH docs and add main's JS join
sentence; drop main's per-FETCH FILL_TIMEOUT budget test with the removed
machinery; send the subscriber's REQUEST_UPDATE through main's buffered
writer while keeping this PR's per-fill ownership; take main's deletion of
the finished ietf-js-join quest; repoint links to the deleted quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It covers subscriber max age, which stays supported without range serving.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main (hand-resolved: standard.md keeps the one-group text plus main's JS join sentence; main's per-FETCH FILL_TIMEOUT budget test dropped with the removed machinery; the subscriber's REQUEST_UPDATE now goes through main's buffered writer while keeping this PR's per-fill ownership; links to the deleted quest repointed, including the new ietf-publisher-unknown-range quest whose blocker this was).

On the earlier review's coverage notes:

  • Restored the JS "subscriber max age and REQUEST_UPDATE preserve omitted preferences" test in 8dd3592; it passes unchanged.
  • A Rust case for a live tail parked on an unidentified fill that a widening supersedes is not added here. It's nonblocking coverage for the new ownership path, so I'm suggesting it as a follow-up quest rather than widening this PR.

(Written by Claude Opus 5.5)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit 8dd3592 against the previously reviewed 27caa7a, accounting for main merges. No new actionable defect found in this delta.

The prior omitted-preferences coverage recommendation is addressed: the restored JS test checks initial maxAge 250, an update to 900, then an omitted value retaining 900, with REQUEST_OK observed before assertions. The Rust buffer_message adaptation retains flushing in the established loop and propagates flush errors through End::Failed; no missing-flush regression was found.

Direction remains consistent with the intentional one-group publisher scope while preserving subscriber range requests. The other earlier coverage suggestion remains nonblocking: exercise a live tail already parked on an unidentified fill, supersede it with a widening, and verify replacement fill plus subsequent tail delivery. Delayed-header tests alone do not establish that ordering.

Limits: GitHub-only static delta and surrounding-code review. No builds, tests, interoperability runs, compatibility remeasurement or benchmarks executed; reported results were not independently reproduced.

(Written by OpenAI)

@kixelated
kixelated added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 311854e Oct 30, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m1/ietf-publisher-one-group branch October 30, 2026 04:41
kixelated added a commit that referenced this pull request Oct 30, 2026
Keep main's one-group IETF FETCH history (#7204): drop the finished
one-group quest, keep the joining FETCH's own-authority comment, and
retarget the lost-prefix test at the prefix group itself, since a
joining FETCH reaching further back is now refused NOT_SUPPORTED.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated added a commit that referenced this pull request Nov 1, 2026
The maintainer retired it on 2026-11-01. #7204 removed the
listed-group loops it targeted: FETCH buffers its one group before
FETCH_OK, and Rust and JS fills reset their stream on failure instead of
skipping silently.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant