Skip to content

fix(quic): sync quinn fixes through 2697de1e - #7287

Merged
moq-bot[bot] merged 4 commits into
mainfrom
quest/m1/quinn-sync
Nov 1, 2026
Merged

moq-bot[bot] merged 4 commits into
mainfrom
quest/m1/quinn-sync

Conversation

@kixelated

@kixelated kixelated commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-quic is a hard fork of quinn, so cargo-deny cannot see quinn fixes. This is the first recurring sync since the fork point 7616e6b2. The Plan named three upstream fixes missing from the ledger.

Approach

Checked quinn main through 2697de1e, 0.11.x through 4b84837d, and quinn's security advisories. Every advisory was published by 2026-09-30, which the fork point already covers.

  • f233510c (a disabled idle timeout abandons accepts): does not apply. The fork's stale-accept check (rs/moq-quic/src/endpoint.rs:577) uses handshake_timeout, a plain Duration that cannot be disabled.
  • 6c69f9f4 (stop credits a reset stream twice): already held. Recv::unread_credit credits only what the reset still owes, and stop_after_reset_credits_once tests it.
  • 623a0369 (specific IPv6 endpoints made dual-stack): production binds already had the fix in moq_sock::bind (moq-dev/moq#5339). The driver tests' bind helper still had the old logic. It now calls moq_sock::bind::udp, and upstream's specific_v6_addr test is ported. The bug only shows on Windows, and the Windows CI job runs this test.
  • 2697de1e (read_datagrams) is a new feature, not a fix, so it is skipped. The others in the range were dependency bumps or are already in the ledger.

The README ledger lists all three fixes and records where the next sync starts.

Since this PR opened, moq-dev/moq#7422 moved the quest to quest/m1/vendor-sync/quinn.md under the vendor-sync epic. That epic now handles recurrence and adds a2c55b36 (Apple IPv4 source address, macOS-only) and a check of the quinn#2481 BBR3 PR. The merge from main follows the newer layout. It drops this PR's quest/m2/quinn-sync.md and its m2 link, and rewrites quest/m1/vendor-sync/quinn.md down to what's left: a2c55b36, the quinn#2481 check, and judging read_datagrams. It also records the new last-checked commits and what this run learned.

Choices made without asking:

  • New upstream features are skipped. Under the vendor-sync Plan, read_datagrams is judged for /quest-plan in the remaining run.
  • a2c55b36 is left to the remaining run, not ported here. It touches only Apple code paths in moq_sock::udp, which can't be tested on this Linux host.

Impact

None: no public API or wire change. The only code change is in tests.

Alternatives

Fixing the old dual-stack logic inside the driver's test helper in place, instead of reusing moq_sock::bind::udp. That would keep a second copy of socket setup that could drift again.

Follow-ups

None.

Review

Codex, gpt-6.1-sol, medium effort (quest review --base origin/main, new session on the merge). Reviewed head 976bf742245f2dadfb6e50001d23485ee81037bf, round 1: no findings. An earlier round on 4ee50ec5 (gpt-6-astra, --deep) also had no findings.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 29, 2026 22:55
Quest-Claim: 67b46f3f2239c1ed
Record f233510c and 6c69f9f4 as already held or not applying, and port
623a0369's specific_v6_addr test with the driver tests binding through
moq_sock::bind. Roll the recurring quest into m2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title moq-quic has every quinn fix it needs fix(quic): sync quinn fixes through 2697de1e Oct 30, 2026
@kixelated
kixelated marked this pull request as ready for review October 30, 2026 06:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T06:42:44.754951Z 4ee50ec Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 4ee50ec5a043a38b74f642baf5d1a4409af100c2.

No actionable bugs found in the inspected sync. Reusing moq_sock::bind::udp removes duplicated socket setup, preserves wildcard dual-stack behavior and keeps a specific IPv6 address v6-only; the added connection test exercises the affected driver path. The newly documented dispositions match the inspected fork code: accept staleness uses the non-optional handshake timeout, and reset-stream stop credit uses the remaining reliable-size obligation.

Direction is sound: distinguish already-held/inapplicable fixes from new ports, record exact upstream checkpoints, and carry the recurring audit forward behind the release cut rather than importing unrelated features.

Verification limits: GitHub-only static review of the diff, upstream commit range and relevant fork code, with an independent pass. No tests, Windows runs or builds were executed. This is not an exhaustive security-advisory or cross-platform correctness certification; author-reported validation was not independently reproduced.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e05a696-84b5-4015-bc94-1141c3c92392
Commits

Reviewing files that changed from the base of the PR and between 4ee50ec and 71f6853.

Files selected for processing: 3
  • quest/m1/vendor-sync/quinn.md
  • rs/moq-quic/README.md
  • rs/moq-tokio/src/quic/driver/tests.rs

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 88b3605c-0687-458d-a1e8-051d8e1d2399
Commits

Reviewing files that changed from the base of the PR and between 1c733a0 and 4ee50ec.

Files selected for processing: 5
  • quest/m1/README.md
  • quest/m2/README.md
  • quest/m2/quinn-sync.md
  • rs/moq-quic/README.md
  • rs/moq-tokio/src/quic/driver/tests.rs
Files with no reviewable changes: 1
  • quest/m1/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Walkthrough

The required Quinn synchronization task moved from the M1 list to the M2 list. The sync plan now uses the last checked upstream commits as baselines and records updated scope, lessons, and release timing. The upstream tracking list records additional Quinn changes and checked revisions. The UDP binding helper now uses moq_sock::bind::udp, and the tests add an IPv6 localhost client/server connection case.

Merge Risk: Minimal · previous review 4ee50

No concrete merge-blocking risk is established by this change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: syncing Quinn fixes through commit 2697de1e.
Description check Passed The description directly explains the Quinn sync, the reviewed fixes, the test change, and the follow-up quest updates.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)

Finishing Touches
Fix failing CI checks
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing via /quest-merge.

  • Head 4ee50ec5a043a38b74f642baf5d1a4409af100c2 is unchanged. Its ## Review record (Codex, round 1, no findings) names this head, and Codex, CodeRabbit, and the OpenAI review comment found nothing either.
  • The failing check job (run 41014723493) is optional and isn't caused by this PR. It was a quest land queue check that stopped at jq: command not found on the runner, before any tests ran, and its plan didn't include this PR.
  • quest check --base origin/main --branch quest/m1/quinn-sync passes against main 1ea4b1a2, and the head merges cleanly into it.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 05:12
@moq-bot
moq-bot Bot disabled auto-merge October 31, 2026 12:58
@moq-bot moq-bot Bot removed the quest:merge label Oct 31, 2026
@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

quest land removed this pull request from the queue: Conflicts with the base: quest/m2/quinn-sync.md
.

@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Codex land fixer: fixer crashed (exit 101); run /quest-iterate. Recommendation: run /quest-iterate before picking it again.

     # refs can deploy to.
-    environment: publish
+    environment: bot
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
merged
  result 100644 7c05faf4c9e5f74340793c0a8b56f54578ab3f64 .github/workflows/smoke.yml
  our    100644 c3e66ca17a0f37621d88c70418005bd38844cacf .github/workflows/smoke.yml
@@ -492,7 +492,7 @@
       contents: read
       packages: read
     # The published client image and moq-dev relay both follow Git HEAD. Building
-    # the Rust relay is the long pole; the 12 protocol cases are bounded and quick.
+    # the Rust relay is the long pole; the protocol cases are bounded and quick.
     timeout-minutes: 45
 
     steps:
@@ -523,10 +523,6 @@
           dirname "$shim" >> "$GITHUB_PATH"
 
       - name: Moxygen interoperability
-        # Current moq-dev HEAD negotiates successfully but fails moxygen's
-        # announce-subscribe case. Keep the full diagnostic visible without
-        # failing the job; remove this once that protocol mismatch is fixed.
-        continue-on-error: true
         run: just moxygen
 
   interop-runner:
@@ -559,8 +555,9 @@
           path: runner-upstream
           persist-credentials: false
 
-      # Any failed pair or setup step fails the job. A complete run still writes
-      # its report first, since a failing run is the one worth looking at.
+      # Only moq-dev clients against this checkout's relay gate the job, plus any
+      # setup step; the other pairs are reported only. A complete run still
+      # writes its report first, since a failing run is the one worth looking at.
       - name: Run upstream Docker matrices
         run: just runner "$GITHUB_WORKSPACE/runner-upstream" "$GITHUB_WORKSPACE/interop-runner-report"
 
merged
  result 100644 76a091624d168b9ab060bcfb766bc7a6605055ac .github/workflows/ts.yml
  our    100644 5d97604def1612ec78cb3deb0b0359e69fcc2d49 .github/workflows/ts.yml
@@ -20,8 +20,8 @@
   ts:
     name: TS validation
     runs-on: ubuntu-latest
-    # `main` and its merge queue write the Rust cache; see .github/actions/rust-cache.
-    environment: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/gh-readonly-queue/main/')) && 'cache-write' || '' }}
+    # Hosted `main` jobs write the Rust cache; see .github/actions/rust-cache.
+    environment: ${{ github.ref == 'refs/heads/main' && 'cache-write' || '' }}
     timeout-minutes: 60
     steps:
       - name: Checkout
merged
  result 100644 052326a850059a2e8a39f78dbf9ece18ea9fa3db .github/workflows/wasm.yml
  our    100644 a2d96cbf5c531b44577f072288598800001f8a9f .github/workflows/wasm.yml
@@ -42,11 +42,10 @@
 jobs:
   wasm:
     name: WASM
-    # ARM64 like check.yml; the harness builds the relay natively, which the
-    # merge queue's Check and Test publish.
+    # ARM64 like check.yml; the harness builds the relay natively.
     runs-on: ubuntu-24.04-arm
-    # `main` and its merge queue write the Rust cache; see .github/actions/rust-cache.
-    environment: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/gh-readonly-queue/main/')) && 'cache-write' || '' }}
+    # Hosted `main` jobs write the Rust cache; see .github/actions/rust-cache.
+    environment: ${{ github.ref == 'refs/heads/main' && 'cache-write' || '' }}
     timeout-minutes: 60
 
     steps:
merged
  result 100644 d03b0c48c1d581d732eb57eac1a67ad0679ff580 .github/workflows/x11.yml
  our    100644 7d01aaa79e4ecec746271bda00a186bf367859f9 .github/workflows/x11.yml
@@ -16,8 +16,8 @@
   capture:
     name: SHM and GetImage
     runs-on: ubuntu-24.04-arm
-    # `main` and its merge queue write the Rust cache; see .github/actions/rust-cache.
-    environment: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/gh-readonly-queue/main/')) && 'cache-write' || '' }}
+    # Hosted `main` jobs write the Rust cache; see .github/actions/rust-cache.
+    envi
thread 'codex-main' (74) panicked at /rustc/48a229ceaefd4985c50990b14116b6d856af0985/library/std/src/io/stdio.rs:1166:9:
failed printing to stderr: Resource temporarily unavailable (os error 11)
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: std::io::stdio::_eprint
   3: <codex_exec::event_processor_with_human_output::EventProcessorWithHumanOutput as codex_exec::event_processor::EventProcessor>::process_server_notification
   4: codex_exec::run_exec_session::{closure#0}
   5: <tracing::instrument::Instrumented<codex_exec::run_exec_session::{closure#0}> as core::future::future::Future>::poll
   6: codex_exec::run_main::{closure#0}
   7: codex::cli_main::{closure#0}
   8: <tokio::runtime::park::CachedParkThread>::block_on::<codex_arg0::run_main_with_arg0_guard<codex::main::{closure#0}, codex::main::{closure#0}::{closure#0}>::{closure#0}>
   9: tokio::runtime::context::runtime::enter_runtime::<<tokio::runtime::scheduler::multi_thread::MultiThread>::block_on<codex_arg0::run_main_with_arg0_guard<codex::main::{closure#0}, codex::main::{closure#0}::{closure#0}>::{closure#0}>::{closure#0}, core::result::Result<(), anyhow::Error>>
  10: <tokio::runtime::runtime::Runtime>::block_on::<codex_arg0::run_main_with_arg0_guard<codex::main::{closure#0}, codex::main::{closure#0}::{closure#0}>::{closure#0}>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
quest: fixer agent exited 101

(written by Codex)

Main moved quinn-sync into the vendor-sync epic, which now owns recurrence.
Drop the PR's m2/quinn-sync.md and rewrite quest/m1/vendor-sync/quinn.md to
the remainder: a2c55b36, the quinn#2481 BBR3 check, and judging read_datagrams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged origin/main to clear the conflict. moq-dev/moq#7422 had moved this quest into quest/m1/vendor-sync/quinn.md, and that epic now handles recurrence. So the merge drops quest/m2/quinn-sync.md and rewrites the vendor-sync child down to what's left: a2c55b36, the quinn#2481 BBR3 check, and judging read_datagrams.

The failing check job was the land queue's prefix runner (jq: command not found), which is infrastructure and not this PR's. just rs check and moq-tokio's quic::driver tests pass locally on the merge. Codex review of 976bf742 found nothing. Landing.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 15:15
@moq-bot
moq-bot Bot disabled auto-merge November 1, 2026 00:16
@moq-bot moq-bot Bot removed the quest:merge label Nov 1, 2026
@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

quest land removed this pull request from the queue: the batch check failed (exit 1).

 * [new tag]             docker-v1                   -> docker-v1
 * [new tag]             github-show                 -> github-show
 * [new tag]             push                        -> push
 * [new tag]             v0.10.0                     -> v0.10.0
 * [new tag]             v0.11.0                     -> v0.11.0
 * [new tag]             v0.12.0                     -> v0.12.0
 * [new tag]             v0.13.0                     -> v0.13.0
 * [new tag]             v0.13.1                     -> v0.13.1
 * [new tag]             v0.14.0                     -> v0.14.0
 * [new tag]             v0.14.1                     -> v0.14.1
 * [new tag]             v0.15.1                     -> v0.15.1
 * [new tag]             v0.16.0                     -> v0.16.0
 * [new tag]             v0.17.0                     -> v0.17.0
 * [new tag]             v0.18.0                     -> v0.18.0
 * [new tag]             v0.19.0                     -> v0.19.0
 * [new tag]             v0.19.1                     -> v0.19.1
 * [new tag]             v0.19.2                     -> v0.19.2
 * [new tag]             v0.19.3                     -> v0.19.3
 * [new tag]             v0.19.4                     -> v0.19.4
 * [new tag]             v0.19.5                     -> v0.19.5
 * [new tag]             v0.19.6                     -> v0.19.6
 * [new tag]             v0.20.0                     -> v0.20.0
 * [new tag]             v0.21.0                     -> v0.21.0
 * [new tag]             v0.21.1                     -> v0.21.1
 * [new tag]             v0.22.0                     -> v0.22.0
 * [new tag]             v0.23.0                     -> v0.23.0
 * [new tag]             v0.24.0                     -> v0.24.0
 * [new tag]             v0.24.1                     -> v0.24.1
 * [new tag]             v0.24.2                     -> v0.24.2
 * [new tag]             v0.24.3                     -> v0.24.3
 * [new tag]             v0.25.0                     -> v0.25.0
 * [new tag]             v0.25.1                     -> v0.25.1
 * [new tag]             v0.25.2                     -> v0.25.2
 * [new tag]             v0.25.3                     -> v0.25.3
 * [new tag]             v0.26.0                     -> v0.26.0
 * [new tag]             v0.26.1                     -> v0.26.1
 * [new tag]             v0.27.0                     -> v0.27.0
 * [new tag]             v0.27.1                     -> v0.27.1
 * [new tag]             v0.27.2                     -> v0.27.2
 * [new tag]             v0.27.3                     -> v0.27.3
 * [new tag]             v0.28.0                     -> v0.28.0
 * [new tag]             v0.28.1                     -> v0.28.1
 * [new tag]             v0.28.2                     -> v0.28.2
 * [new tag]             v0.28.3                     -> v0.28.3
 * [new tag]             v0.29.0                     -> v0.29.0
 * [new tag]             v0.29.1                     -> v0.29.1
 * [new tag]             v0.29.2                     -> v0.29.2
 * [new tag]             v0.29.3                     -> v0.29.3
 * [new tag]             v0.29.4                     -> v0.29.4
 * [new tag]             v0.29.5                     -> v0.29.5
 * [new tag]             v0.30.0                     -> v0.30.0
 * [new tag]             v0.31.0                     -> v0.31.0
 * [new tag]             v0.31.1                     -> v0.31.1
 * [new tag]             v0.31.2                     -> v0.31.2
 * [new tag]             v0.32.0                     -> v0.32.0
 * [new tag]             v0.32.1                     -> v0.32.1
 * [new tag]             v0.32.2                     -> v0.32.2
 * [new tag]             v0.4.0                      -> v0.4.0
 * [new tag]             v0.5.0                      -> v0.5.0
 * [new tag]             v0.6.0                      -> v0.6.0
 * [new tag]             v0.6.1                      -> v0.6.1
 * [new tag]             v0.7.0                      -> v0.7.0
 * [new tag]             v0.7.1                      -> v0.7.1
 * [new tag]             v0.7.2                      -> v0.7.2
 * [new tag]             v0.8.0                      -> v0.8.0
 * [new tag]             v0.9.0                      -> v0.9.0
derivation evaluated to /nix/store/nvij27kw5rh5323b8idz8whhaqn49kc4-moq-relay-0.17.2.drv
checking derivation packages.x86_64-linux.default...
derivation evaluated to /nix/store/8njiymqk67rqxixlszn9734gjq417l0f-moq-all.drv
checking derivation packages.x86_64-linux.uniffi-bindgen-dart...
derivation evaluated to /nix/store/1v1hdl7dhiwdis0y2lmh6vjx149is362-uniffi-bindgen-dart-0.3.1-kixelated.6+v0.32.0.drv
checking derivation packages.x86_64-linux.uniffi-bindgen-cpp...
derivation evaluated to /nix/store/im9pz4z9gbnxq8cgg736sqc7d5y07nc3-uniffi-bindgen-cpp-0.11.0-kixelated.7+v0.32.2.drv
checking derivation packages.x86_64-linux.moq...
derivation evaluated to /nix/store/smqzfr9i5yz34lx7plmp7cf7jkha5myb-moq-cli-0.14.2.drv
checking derivation packages.x86_64-linux.moq-cli...
derivation evaluated to /nix/store/hv61q4ncyjdmv18plpyi91gajc3k7n0z-moq.drv
checking derivation packages.x86_64-linux.moq-bench...
derivation evaluated to /nix/store/wgx1wsmlph9lv0if39k3xla0xi826gcx-moq-bench-0.0.1.drv
checking derivation packages.x86_64-linux.moq-boy...
error: interrupted by the user
ci: test gh failed
ci: seconds per module
   295  check py
    57  test py
   526  check rs
   195  test rs
   230  check rs_shapes (cancelled)
   418  check c
   364  check cpp
    63  check obs_compile
   406  check js
    67  test js
    28  check markdown
     4  check gh
    27  test gh (failed)
   154  check kt
    18  check flake (cancelled)
   952  wall time
error: recipe `ci` failed on line 107 with exit code 1

.

@kixelated
kixelated enabled auto-merge (squash) November 1, 2026 00:24
@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

codex / Codex land fixer: PR was picked again while fixing; keeping the newer pick. Recommendation: run /quest-iterate before picking it again.

-
-## Goal
-
-moq-mux parses and builds avcC and hvcC records with `mp4_atom::Avcc` and
-`mp4_atom::Hvcc`, already its dependency, instead of about 330 hand-written
-lines, or a comment at the hand-written code names the input mp4-atom
-mishandles.
-
-## Plan
-
-Found by the 2026-10-19 dependency audit. `rs/moq-mux/src/codec/h264/mod.rs`
-has `Avcc::parse`, `build_avcc`, `catalog_avcc`, `avcc_params`, and
-`read_param_sets`; `codec/h265/mod.rs` has `build_hvcc` and `hvcc_params`.
-The tests already check them against mp4-atom. The fMP4 importer decodes an
-`mp4_atom::Avcc`, re-encodes it, and re-parses it with the hand-written parser
-(`container/fmp4/import.rs`, `init_h264`), while its H.265 path reads the
-`mp4_atom::Hvcc` fields directly.
-
-Check first for a leniency reason, such as how mp4-atom handles the
-high-profile extension or a short record from a real encoder; keep the
-hand-written path only for a reproduced case and test it. `moq_mux` exports
-`codec::h264::Avcc`, so replacing or removing it is a breaking change;
-prefer keeping the type and changing only how it is
-filled when that is simpler. No wire change.
-
-## Related
-
-- [H.264 parsing with maintained crates](/quest/m2/h264-reader.md) - the SPS side of the same codec config
diff --git a/quest/m2/README.md b/quest/m2/README.md
index f93399e86..4e19cf61d 100644
--- a/quest/m2/README.md
+++ b/quest/m2/README.md
@@ -218,7 +218,6 @@ lite-07; bitrate enforcement is not part of this release.
 
 - [Task supervision](/quest/m2/task-supervision.md) - the auth decider loop, stats publisher, and moq-tokio's token and WebSocket internals are supervised like #5447's tasks
 - [Auth serve bound address](/quest/m2/auth-serve-bound-addr.md) - `moq auth serve` logs the port it actually bound
-- [RTMP client reports a publish or play error](/quest/m2/rtmp-client-error.md) - a refused publish or play surfaces its reason
 - [H.264 parsing with maintained crates](/quest/m2/h264-reader.md) - moq-mux parses SPS VUI with h264-reader and shares one bit reader across codec config parsers
 - [avcC and hvcC through mp4-atom](/quest/m2/mp4-atom-config.md) - moq-mux stops hand-writing the decoder config records its mp4-atom dependency already parses
 - [Relay metrics through prometheus-client](/quest/m2/relay-prometheus-client.md) - `/metrics` renders through the maintained client with the same series
diff --git a/quest/m2/rtmp-client-error.md b/quest/m2/rtmp-client-error.md
deleted file mode 100644
index e50058d8e..000000000
--- a/quest/m2/rtmp-client-error.md
+++ /dev/null
@@ -1,16 +0,0 @@
-# [XS] RTMP client reports a publish or play error
-
-## Goal
-
-`moq_rtmp::Client` returns a server's `_error` on publish or play with its
-code and description, as it already does on connect. Today the `_error` has
-no outstanding transaction, so the session raises
-`UnknownTransactionResultReceived`, `dial.rs` ignores it, and the client ends
-with "rtmp server closed before publish was accepted" once the server closes.
-
-## Plan
-
-Match the publish and play `_error` in `rs/moq-rtmp`'s client and surface it
-through `dial.rs`. Test against a server that answers a publish with `_error`
-and one that answers a play with `_error`, asserting the code and description
-in both.

codex
I reproduced the dispatcher failures on base: the two targeted tests pass with `CHECK_FAIL_FAST` cleared and fail with it set. The test harness inherits that gate setting. No PR-specific fix is indicated, so I’ll requeue all eight unchanged and record the cause.

exec
/bin/bash -lc "python3 - <<'PY'
import json, pathlib, subprocess
numbers=[7397,7401,7418,7441,7287,7256,7336,7352]
reason='healthy; batch failure is base test isolation: sh/dispatch-query.test.py inherits CHECK_FAIL_FAST from the landing gate; targeted base tests pass with it cleared'
result=[dict(number=n,action='requeue',reason=reason) for n in numbers]
p=pathlib.Path('quest-land-result.json')
p.write_text(json.dumps(result,indent=2)+'\\n')
assert len(json.loads(p.read_text()))==8
expected={7397:'1bac738fa',7401:'5f4f6db97',7418:'08201ee65',7441:'353bbd9d0',7287:'976bf7422',7256:'ec9560ca5',7336:'28b51f575',7352:'6fc4f8c90'}
for n,prefix in expected.items():
    head=subprocess.check_output(['git','rev-parse',f'pr-{n}'],text=True).strip()
    assert head.startswith(prefix),(n,head)
print('Validated 8 requeue entries and unchanged pinned branch tips.')
PY
 git status --short" in /work
 succeeded in 25ms:
Validated 8 requeue entries and unchanged pinned branch tips.
?? quest-land-result.json

codex
Wrote [quest-land-result.json](/work/quest-land-result.json): all eight PRs requeued unchanged.

The failure comes from base’s dispatcher tests inheriting `CHECK_FAIL_FAST`. Targeted tests pass with it cleared and reproduce the failure when set.

All PR branches remain intact; the result file is uncommitted.
tokens used
64,429
Wrote [quest-land-result.json](/work/quest-land-result.json): all eight PRs requeued unchanged.

The failure comes from base’s dispatcher tests inheriting `CHECK_FAIL_FAST`. Targeted tests pass with it cleared and reproduce the failure when set.

All PR branches remain intact; the result file is uncommitted.
fixer result written

(written by codex / Codex)

@moq-bot
moq-bot Bot merged commit 5eda27e into main Nov 1, 2026
1 check passed
@moq-bot
moq-bot Bot deleted the quest/m1/quinn-sync branch November 1, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant