Repository navigation
BBR3 clears congestion signals in Drain and floors its Reno probe time - #8810
Merged
Merged
Conversation
Quest-Claim: 3162aedff22dad8e
…rs its Reno probe time Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 15, 2026 11:24
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed BBR3's Drain entry and its Reno-coexistence target against the ACK pipeline order and Linux tcp_bbr.c.
- Drain entry resets the congestion signals —
enter_drainnow callsreset_congestion_signals(). Both callers are safe.check_startup_doneruns afterupdate_congestion_signals, so the loss round that ended Startup has already run its Startup adapt step, which does nothing.handle_ce's Startup arm readsinflight_latestintoinflight_longtermbefore the reset clears it. - Floored
target_inflight— the target is nowmin(max(bdp, offload_budget, min_pipe_cwnd), cwnd), which matchesbbr_target_inflight→bbr_inflight. It leaves out ProbeBW_UP's +2, which is correct because the Reno check runs in Down and Cruise.handle_inflight_too_highalso sees the floored value, as it does in Linux. - Reno round count rounds up — the count now uses
div_ceil(smss). Thereno_rounds == 0early return is gone; it can no longer be reached becausemin_pipe_cwndsets a floor of at least one packet. - Tests — two new tests cover the Drain reset and each part of the floor:
min_pipe_cwnd, the offload budget, the cwnd cap, and rounding up.
claude-opus-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes
quest/m1/bbr3-references/transitions.md(deleted).Summary
enter_draincallsreset_congestion_signals()as Linux does on Drain entry, so the loss or CE mark that ends Startup is charged once and no longer cutsbw_shortterm/inflight_shorttermagain one loss round later in Drain.target_inflightfloors the BDP atmax(bdp, offload_budget, min_pipe_cwnd)and then caps it at cwnd (Linux'sbbr_target_inflightthroughbbr_inflight).is_reno_coexistence_probe_timerounds its packet count up, and drops itsreno_rounds == 0early return, which the floor makes unreachable.Choices a review can undo
target_inflightis also read byhandle_inflight_too_high(inflight_longterm = max(tx_in_flight, target * BETA)); it now sees the floored value. Linux does the same throughbbr_target_inflight, so I changed the shared function rather than adding a Reno-only copy.offload_budget(refreshed by everyquantization_budget) rather than recomputing it, becauseis_reno_coexistence_probe_timetakes&self. It omits ProbeBW_UP's +2 SMSS, since the check runs in Down/Cruise.div_ceil);bdpitself keeps its existing rounding to nearest.Public API and wire impact
None. Behavior change inside
moq-congestion's BBR3 only.Validation
quest gate cargo test -p moq-congestionpasses (377 tests);cargo clippy --all-targetsandcargo fmtclean;quest checkok.drain_entry_clears_the_congestion_signalsfails without the reset (bw_shorttermis 2.4 MB/s, not infinite, after the next loss round in Drain) and passes with it. Newreno_probe_time_floors_a_small_bdpcovers the floor, the offload budget, the cwnd cap, and round-up. The existingtarget_inflightassertion now expects the floored value.Caused by
Models
Size: XS
Implementer: Claude, claude-sonnet-5-5, unknown effort (arm A)
Follow-ups
None.
Review
Rewritten by
quest reviewafter each round.Head: 60c030e
Base: origin/main at 23b8ba4
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1def2-bfb7-7f00-8487-1b7e1476c1d4, round 1Score: 9/10,
No actionable regressions were found; the changes are focused and include regression coverage, but builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none