Skip to content

fix(net): its own dev-dependency leaves default features off - #9091

Open
kixelated wants to merge 1 commit into
mainfrom
fix/net-self-dev-dep-no-default
Open

kixelated wants to merge 1 commit into
mainfrom
fix/net-self-dev-dep-no-default

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Nightly features fails at just rs net-features --all (run): "moq-net test dependencies must not enable async". The self dev-dependency added for the relay and test-support features left default features on, so cargo tree -e features -i moq-net shows moq-net feature "default" enabled by a dev-dependency. default is empty today, so nothing is miscompiled, but the guard rightly rejects it: a later default feature would silently leak into the no-async test build. Since net-features exits at that guard, its clippy, doc, and nextest steps never ran either.

Approach

Set default-features = false on moq-net's own dev-dependency and regenerate nix/Cargo.nix.

Impact

None: dev-dependency only, no public API or wire change.

Alternatives

Loosen the guard to allow an empty default: rejected, the guard protects against default gaining features.

Caused by

  • moq-dev/moq#8952 - added the moq-net self dev-dependency without default-features = false (found by check: Nightly features)

Validation

  • cargo tree --locked -p moq-net --no-default-features -e features -i moq-net now lists only relay and test-support.
  • quest gate just rs features with this and moq-dev/moq#9092: net-features --all and coroutines pass. The only failure was moq-relay refusals::uring_refuses_uri_setup_paths ("io_uring worker setup failed: io error") under the full parallel run on my host; it passes alone and passed in the Nightly run, so it is unrelated.
  • just check passes.

Follow-ups

None.

Models

Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 7980e99

  • Base: origin/main at 4f3ba33

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1efda-5801-7dc3-b194-1b0dcde1d150, round 1

  • Score: 10/10, The self dev-dependency and generated Nix change agree, and disabling currently absent default features leaves behavior unchanged; no builds or tests were run.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — fixes the cause at the self dev-dependency, so the default feature guard stays strict.

Reviewed changes

Reviewed the full diff (2 files).

  • rs/moq-net/Cargo.toml — adds default-features = false to the moq-net self dev-dependency.
  • nix/Cargo.nix — adds the matching usesDefaultFeatures = false; to the generated entry.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The moq-net dev-dependency now disables default features in the Cargo manifest and generated dependency configuration. The explicit relay and test-support features remain enabled.

Merge Risk: Minimal · up to 7980e

This change stops the crate's own test builds from enabling its default feature. It touches only development dependency settings, so production behavior is unaffected and the merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: it sets default-features off on moq-net's own dev-dependency, which the PR objectives and raw summary both confirm. It is specific and matches the changeset, so it passes.
Description check Passed The description states the problem (Nightly features check fails because the self dev-dependency leaves default features on), the approach (default-features = false plus regenerated nix/Cargo.nix), im…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description states the problem (Nightly features check fails because the self dev-dependency leaves default features on), the approach (default-features = false plus regenerated nix/Cargo.nix), impact, and validation. It matches the changeset closely, so it passes.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9013efc7-83f0-4e60-abe8-bb955abeef6a
Commits

Reviewing files that changed from the base of the PR and between 4f3ba33 and 7980e99.

Files selected for processing: 2

  • nix/Cargo.nix
  • rs/moq-net/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant