Skip to content

fix(json): link Consumer::poll_next, which exists without async - #9092

Open
kixelated wants to merge 1 commit into
mainfrom
fix/json-doc-link-no-async
Open

kixelated wants to merge 1 commit into
mainfrom
fix/json-doc-link-no-async

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Nightly features fails at just rs coroutines (run): cargo doc -p moq-json --no-default-features with -D warnings reports "unresolved link to Consumer::next". next is the kio::wrapper the async feature generates from poll_next, so the link only resolves with async on.

Approach

Link Consumer::poll_next, which exists in every build and is what next wraps.

Impact

None: doc comment only.

Alternatives

None worth weighing.

Caused by

  • moq-dev/moq#8907 - added the Config::delay doc linking the async-only Consumer::next (found by check: Nightly features)

Validation

  • RUSTDOCFLAGS="-D warnings" cargo doc --locked -p moq-json --no-deps --no-default-features passes.
  • quest gate just rs features with this and moq-dev/moq#9091: coroutines passes.
  • just check passes.

Follow-ups

None.

Models

Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 0cc9ae5

  • Base: origin/main at 4f3ba33

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1efd9-eeaf-7581-aacb-c8732e7514aa, round 1

  • Score: 10/10, The narrowly scoped documentation correction links to poll_next, which exists regardless of the async feature, and is ready to land.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. The doc link now targets Consumer::poll_next, which exists in every build, instead of the async-only next.

Reviewed changes

  • Doc link fix — Config::delay in rs/moq-json/src/snapshot/consumer.rs links Consumer::poll_next rather than Consumer::next, so cargo doc --no-default-features with -D warnings no longer fails.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Config::delay documentation now identifies Consumer::poll_next as the method that yields a still-needed superseded snapshot. It previously named Consumer::next.

Merge Risk: Minimal · up to 0cc9a

This is a documentation-only fix so that docs build without the async feature. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: a doc link in moq-json is corrected from Consumer::next to Consumer::poll_next, because poll_next exists without the async feature. The title matches the changeset's single…
Description check Passed The description covers the problem (a nightly features job fails with an unresolved doc link to Consumer::next), the approach (link Consumer::poll_next), the validation commands, and the commit that c…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a doc link in moq-json is corrected from Consumer::next to Consumer::poll_next, because poll_next exists without the async feature. The title matches the changeset's single main change and the stated cause.

Full details: Description check

Explanation

The description covers the problem (a nightly features job fails with an unresolved doc link to Consumer::next), the approach (link Consumer::poll_next), the validation commands, and the commit that caused the issue. It relates directly to the one-line doc change.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6600bf99-2fb5-42bc-8085-c60c85a63f23
Commits

Reviewing files that changed from the base of the PR and between 4f3ba33 and 0cc9ae5.

Files selected for processing: 1

  • rs/moq-json/src/snapshot/consumer.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant