Skip to content

quest: prove the session driver Sync within the default recursion limit - #9136

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/send-depth-ffi
Nov 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/send-depth-ffi

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Plans quest/m1/driver-sync-depth.md: prove moq_net::Driver: Send + Sync and moq-tokio's spawned session future Send within Rust's default recursion limit, and extend just rs send-depth to cover both.

On 2026-11-14 the maintainer decided in kixel-ai/rust2#809 to plan this fix here, but no quest was ever created. A 2026-11-18 run of rust2's just ffi moq-cpp at 71c6209f still overflows in both places, which blocks rust2's exporter moq pin bump.

Decisions

  • Goal (maintainer, 2026-11-18): ✅ the fix plus gating moq-tokio and Driver: Sync under the lint (rejected: the fix alone, with no gate).
  • Fix shape (maintainer, 2026-11-14, rust2#809): ✅ wrap the lite publisher's kio::Tasks<Control> so it proves Send + Sync once (rejected: record the wait only; allow the lint).

Structure

  • quest/m1/driver-sync-depth.md, [S], m1: a non-breaking fix in shipped code that a named consumer (rust2's exporter) waits on, so it is this cycle's additive work.

The confirming question said "moq's rs/moq-ffi". The overflow actually came from the facade crate rust2's exporter generates. Both need Driver: Sync, so the quest gates that bound in moq-net's send test rather than naming one crate.

Validation

quest check passes. No behavior to exercise: the change is a plan only.

Public API: none. Wire: none.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 5bf117a

  • Base: origin/main at 77dd8fe

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f12d-f3ac-7212-8a3e-c250db4b9f41, round 1

  • Score: 10/10, The change adds only a scoped quest plan, does not alter runtime behavior, and has no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b88e9e17-1757-46ef-9056-e73f027755bd
Commits

Reviewing files that changed from the base of the PR and between 77dd8fe and 5bf117a.

Files selected for processing: 1

  • quest/m1/driver-sync-depth.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — a plan-only quest that fixes the overflow at the publisher's kio::Tasks<Control> and gates it in send-depth.

Reviewed changes

Reviewed the single added file.

  • quest/m1/driver-sync-depth.md — New [S] quest for proving Driver: Send + Sync and moq-tokio's spawned future Send, and for extending sh/rs/send-depth.sh. The referenced paths (rs/moq-net/src/lite/publisher.rs:264, rs/moq-tokio/src/client.rs:703, sh/rs/send-depth.sh) exist and match the descriptions.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit f12b8ae Nov 19, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/send-depth-ffi branch November 19, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant