Repository navigation
A lite-07 SUBSCRIBE_UPDATE costs its edit on a relay's front and in JS too - #9183
Conversation
Quest-Claim: 3f5e4b62775d9d53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The producer's aggregates count each subscriber's ranges and scalars, so a change moves only what changed instead of folding every subscriber (combineSubscriptions is gone). Preferences and the window are keyed by Range ID, and the publisher applies an update as an edit through the internal hooks.editSubscriber. The publisher-update bench runs nightly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A front's reader forgets a retired range still waiting to be backfilled, so retiring and adding ranges before the floor resolves holds only the live ones. Following a front's demand arms the wake without building the aggregate's whole range union. The JS window's waiting-time index is an ordered chunk list, so a span joining or leaving its time shifts no other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hooks.servingResolvedKeys resolves every range a pass asks in one call, so a reader following route copies builds its ranges once for them all rather than once per range. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Merge pick (maintainer away, granted the coordinator merges it confidently recommends): ✅ /quest-merge, accepting the 11 decisions listed in the PR body (including untouched ranges keeping their earlier resolution, the relay's held upstream subscription staying, synchronous JS aggregate updates) and the +30% at 16 of 16 ranges in exchange for O(k log n) edits. (Written by Claude Opus 5.5 with high) |
There was a problem hiding this comment.
ℹ️ No critical issues. Two small cleanups inline.
Approach: Sound. Each of the three remaining whole-rebuild paths (front reader → copies, the held upstream fold, the Live index) and the JS aggregates now moves by Range ID. Each incremental path is checked against a whole rebuild, and the public update and exported JS types are unchanged.
Reviewed changes
I reviewed the full diff at 9ff6946, Rust and JS:
- Front reader keyed (
model/resume.rs):Reader::syncreadsPrefs::changesintoChange::{Scalars, Edit, All}. It edits the window by key, andCopy::sendforwards only the keys whose clamped wire range moved. Copies are rekeyed to the reader's keys, andCopy.resolvedis now a keyed map. - Backfill judgement (
Resumed):Routekeeps the replaced copy's floor and its keyed resolution.Rangesjudges only the keys added, and dropping retired keys bounds it. - Held upstream fold (
Held/Fold):Producer::followrefolds each reader's edits into the held subscription. When a reader is missing or the feed changes, it asks again in full.follow_demandarms the wake withwatch_subscriptionwithout building the aggregate. Liveindex per cursor (model/track.rs):Indexedremembers theCoverit was built for, andrecovermoves it by theCover::moveddiff, so a whole cache rescan is no longer needed.- JS counted aggregates:
cover.ts(a treapCoverplusCounts),ranges.ts(the incremental union) anddemand.ts(Prefs/Subscriptions) replacecombineSubscriptions.Windowis keyed and edited in place, andByTimeis built onutil/sorted.ts. - JS lite-07 publisher:
LiveRanges.applyreturnsApplied,Requested/Unpinnedpin only the due ranges, andhooks.editSubscriber/servingResolvedKeyscarry the edit by Range ID.
I also checked:
Window::edit's refusals (check) can't fire underUnheld/Placed, so the new.expects inReader::sync/resolvekeep the old guarantee.watch_subscriptiononly registers onSubscriptions::waiters, so dropping the old drain loop leaves no stale-prevreader behind.TrackState::livewalks only visible slots, sorecoveradds no fetched groups that an arrival-built index would leave out.
claude-opus-5-5 | 𝕏
|
quest land watch: ended this pull request's pick, disarming its auto-merge, since its head 9ff6946 is held by finding by pullfrog[bot]: This branch can never run. (written by quest land watch) |
…h cover once A folded entry's Weak keeps the reader's allocation, so its address can't be reused while the entry exists: the reused-address branch never ran. The randomized held-fold test now also checks a reader that leaves takes its entry with it. A fresh Live index took in its cover twice: once diffing against an empty cover, then again walking every arrival. The walk alone covers every live group, so a fresh index adopts the cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found. Both earlier suggestions are fixed cleanly.
Reviewed changes
Since 9ff6946, one commit (18c4979) addresses the two earlier inline notes:
- Removed the held fold's dead address check (
model/resume.rs):refoldno longer has theWeak::ptr_eqbranch, which could never run.Folded._readernow has a doc comment: it pins the allocation so theArc::as_ptrkey stays unique.a_held_subscription_follows_each_edit_as_the_whole_foldnow asserts one fold entry per reader still present after every step. - Fresh
Liveindex adopts its cover (model/track.rs): whenIndexed::catch_upruns withtaken == 0, it takesgroupsas its cover without callingrecover, thenarrivals_from(0)fills the index. This is sound for three reasons:Indexed.groupsis always empty whiletaken == 0. Entries come only from the arrival walk, which advancestaken, or fromrecover, which now runs only whentaken != 0.compact_arrivaldrops only dead entries, those whose stamps no longer match.arrivals_fromseeks by the absoluteentry.at, not by deque position.
claude-opus-5-5 | 𝕏
|
Merge pick (maintainer away, granted the coordinator merges it confidently recommends): ✅ /quest-merge at 18c4979 (dead (Written by Claude Opus 5.5 with high) |
|
quest land watch: the merge queue removed this pull request at 18c4979 because its The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.
…xed, |left| left.checked_sub(size))
|
warning: use of deprecated method `std::sync::atomic::Atomic::<u64>::fetch_update`: renamed to `try_update` for consistency
--> rs/moq-net/src/model/group/content.rs:150:5
|
150 | .fetch_update(Ordering::Relaxed, Ordering::Relaxed, |total| total.checked_sub(charge))
| ^^^^^^^^^^^^
|
help: replace the use of the deprecated method
|
150 - .fetch_update(Ordering::Relaxed, Ordering::Relaxed, |total| total.checked_sub(charge))
150 + .try_update(Ordering::Relaxed, Ordering::Relaxed, |total| total.checked_sub(charge))
|
warning: use of deprecated method `std::sync::atomic::Atomic::<usize>::fetch_update`: renamed to `try_update` for consistency
--> rs/moq-net/src/session.rs:1169:5
|
1169 | .fetch_update(Ordering::AcqRel, Ordering::Acquire, |live| {
| ^^^^^^^^^^^^
|
help: replace the use of the deprecated method
|
1169 - .fetch_update(Ordering::AcqRel, Ordering::Acquire, |live| {
1169 + .try_update(Ordering::AcqRel, Ordering::Acquire, |live| {
|
warning: use of deprecated method `std::sync::atomic::Atomic::<u64>::fetch_update`: renamed to `try_update` for consistency
--> rs/moq-net/src/transport/boxed.rs:164:5
|
164 | .fetch_update(Ordering::AcqRel, Ordering::Acquire, |paused| {
| ^^^^^^^^^^^^
|
help: replace the use of the deprecated method
|
164 - .fetch_update(Ordering::AcqRel, Ordering::Acquire, |paused| {
164 + .try_update(Ordering::AcqRel, Ordering::Acquire, |paused| {
|
warning: `moq-net` (lib) generated 7 warnings (run `cargo fix --lib -p moq-net` to apply 7 suggestions)
Checking qmux v0.7.0 (/var/cache/github-runner-work/moq/moq/rs/qmux)
Checking moq-tokio v0.19.23 (/var/cache/github-runner-work/moq/moq/rs/moq-tokio)
mbx[progress]: 15s elapsed; 3 hits, 2 misses, 0 bypassed, 0 not looked up; ~2.32s compiler work saved
Finished `dev` profile [unoptimized] target(s) in 20.24s
mbx[cache]: object cache: 3 hits, 3 misses; 0 B downloaded, 0 B uploaded, 19.1 MiB stored locally
mbx[cache]: 21.31s session; 2.32s estimated compiler time avoided (summed across compilations)
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: 300812 compilations served. the monocle stays on.
sh/rs/c-tests.sh "$@"
Checking kio v0.6.2 (/var/cache/github-runner-work/moq/moq/rs/kio)
Compiling moq-video v0.1.10 (/var/cache/github-runner-work/moq/moq/rs/moq-video)
Compiling libmoq v0.7.0 (/var/cache/github-runner-work/moq/moq/rs/libmoq)
Checking moq-net v0.3.10 (/var/cache/github-runner-work/moq/moq/rs/moq-net)
Checking moq-congestion v0.1.0 (/var/cache/github-runner-work/moq/moq/rs/moq-congestion)
Checking moq-quic v0.1.0 (/var/cache/github-runner-work/moq/moq/rs/moq-quic)
Checking moq-json v0.5.8 (/var/cache/github-runner-work/moq/moq/rs/moq-json)
Checking moq-loc v0.2.19 (/var/cache/github-runner-work/moq/moq/rs/moq-loc)
Checking qmux v0.7.0 (/var/cache/github-runner-work/moq/moq/rs/qmux)
Checking hang v0.21.11 (/var/cache/github-runner-work/moq/moq/rs/hang)
Checking moq-tokio v0.19.23 (/var/cache/github-runner-work/moq/moq/rs/moq-tokio)
Checking moq-mux v0.10.11 (/var/cache/github-runner-work/moq/moq/rs/moq-mux)
Checking moq-audio v0.1.10 (/var/cache/github-runner-work/moq/moq/rs/moq-audio)
Finished `dev` profile [unoptimized] target(s) in 23.86s
mbx[cache]: object cache: 5 hits, 10 misses; 0 B downloaded, 0 B uploaded, 28.8 MiB stored locally
mbx[cache]: 24.89s session; 2.96s estimated compiler time avoided (summed across compilations)
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: the sweep found 3.0 TiB logical nobody would miss. nobody has.
##[endgroup]
##[group]test rs
sh/rs/select.sh test "$LIST"
rs: selecting hang libmoq moq-archive moq-audio moq-bench moq-boy moq-cli moq-e2ee moq-ffi moq-gst moq-hls moq-json moq-loc moq-mux moq-net moq-net-tests moq-relay moq-rtmp moq-rtsp moq-srt moq-stats moq-tokio moq-transcode moq-uring moq-video moq-webrtc qmux
KIO_DENY_HOST_TIMERS=1 CARGO_BUILD_WARNINGS=deny RUSTC_WORKSPACE_WRAPPER='/nix/store/jqx7yhf9hnxfi9lgb1bfl608xyjq57jm-rust-minimal-1.98.1/bin/clippy-driver' bash sh/rs/nextest.sh cargo nextest run --locked --tests "$@"
Compiling kio v0.6.2 (/var/cache/github-runner-work/moq/moq/rs/kio)
Compiling moq-video v0.1.10 (/var/cache/github-runner-work/moq/moq/rs/moq-video)
Compiling moq-relay v0.17.2 (/var/cache/github-runner-work/moq/moq/rs/moq-relay)
Compiling vsimd v0.8.0
Compiling outref v0.5.2
Compiling object v0.37.3
Compiling jsonptr v0.8.2
Compiling web-transport-trait v0.5.2
Compiling gimli v0.32.3
Compiling miniz_oxide v0.8.9
Compiling addr2line v0.25.1
Compiling const-str-proc-macro v1.1.0
Compiling base64-simd v0.8.0
Compiling rustc-demangle v0.1.28
Compiling const-str v1.1.0
Compiling rustc_version v0.4.1
Compiling hmac v0.13.0
Compiling colored v3.1.1
Compiling qmux v0.6.5
Compiling dotenvy v0.15.7
Compiling simdutf8 v0.1.5
Compiling moq-gst v0.4.12 (/var/cache/github-runner-work/moq/moq/rs/moq-gst)
Compiling backtrace v0.3.76
Compiling std-next v0.1.9
Compiling hex-simd v0.8.0
Compiling phf_shared v0.14.0
Compiling s3s-test v0.17.0
Compiling sha2 v0.11.1
Compiling s3s-sigv2 v0.17.0
Compiling phf v0.14.0
Compiling s3s-rfc2047 v0.17.0
Compiling s3s-sigv4 v0.17.0
Compiling s3s-multipart v0.17.0
Compiling quick-xml v0.42.0
Compiling json-patch v5.0.0
Compiling crc32c v0.6.8
Compiling atoi v3.1.0
Compiling transform-stream v0.3.1
Compiling urlencoding v2.1.3
Compiling moq-net v0.3.10 (/var/cache/github-runner-work/moq/moq/rs/moq-net)
Compiling moq-congestion v0.1.0 (/var/cache/github-runner-work/moq/moq/rs/moq-congestion)
Compiling moq-shaper v0.0.1 (/var/cache/github-runner-work/moq/moq/rs/moq-shaper)
Compiling moq-auth v0.2.1 (/var/cache/github-runner-work/moq/moq/rs/moq-auth)
Compiling path-dedot v4.0.1
Compiling xxhash-rust v0.8.19
Compiling numeric_cast v0.3.0
Compiling s3s-fs v0.17.0
Compiling path-absolutize v4.0.1
Compiling tracing-error v0.2.1
Compiling s3s v0.17.0
Compiling libmoq v0.7.0 (/var/cache/github-runner-work/moq/moq/rs/libmoq)
Compiling moq-quic v0.1.0 (/var/cache/github-runner-work/moq/moq/rs/moq-quic)
Compiling moq-json v0.5.8 (/var/cache/github-runner-work/moq/moq/rs/moq-json)
Compiling qmux v0.7.0 (/var/cache/github-runner-work/moq/moq/rs/qmux)
Compiling moq-loc v0.2.19 (/var/cache/github-runner-work/moq/moq/rs/moq-loc)
Compiling moq-uring v0.0.12 (/var/cache/github-runner-work/moq/moq/rs/moq-uring)
Compiling moq-archive v0.0.11 (/var/cache/github-runner-work/moq/moq/rs/moq-archive)
Compiling moq-e2ee v0.0.26 (/var/cache/github-runner-work/moq/moq/rs/moq-e2ee)
Compiling hang v0.21.11 (/var/cache/github-runner-work/moq/moq/rs/hang)
Compiling moq-stats v0.2.12 (/var/cache/github-runner-work/moq/moq/rs/moq-stats)
Compiling moq-tokio v0.19.23 (/var/cache/github-runner-work/moq/moq/rs/moq-tokio)
Compiling moq-mux v0.10.11 (/var/cache/github-runner-work/moq/moq/rs/moq-mux)
Compiling moq-net-tests v0.0.0 (/var/cache/github-runner-work/moq/moq/rs/moq-net-tests)
Compiling moq-audio v0.1.10 (/var/cache/github-runner-work/moq/moq/rs/moq-audio)
Compiling moq-hls v0.5.11 (/var/cache/github-runner-work/moq/moq/rs/moq-hls)
Compiling moq-rtmp v0.3.11 (/var/cache/github-runner-work/moq/moq/rs/moq-rtmp)
Compiling moq-srt v0.3.11 (/var/cache/github-runner-work/moq/moq/rs/moq-srt)
Compiling moq-rtsp v0.0.1 (/var/cache/github-runner-work/moq/moq/rs/moq-rtsp)
Compiling moq-webrtc v0.3.12 (/var/cache/github-runner-work/moq/moq/rs/moq-webrtc)
Compiling moq-bench v0.1.0 (/var/cache/github-runner-work/moq/moq/rs/moq-bench)
Compiling moq-transcode v0.1.10 (/var/cache/github-runner-work/moq/moq/rs/moq-transcode)
sh/dispatch.sh: line 407: wait: pid 1609281 is not a child of this shell
##[endgroup]
##[error]ci: check dead_code failed
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
name: cargo-timings
path: target/cargo-timings/cargo-timing-*.html
if-no-files-found: ignore
retention-days: 14
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
BASE: 947d61c15c073047e779e399615f0632325ddb29
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: cargo-timings.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 69777
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is 0c025c3271af62c9cc6e9616712f55bcb3ee005060cac7fd4a660ebe6bb3ca2d
Finalizing artifact upload
Artifact cargo-timings successfully finalized. Artifact ID 14563061669
Artifact cargo-timings has been successfully uploaded! Final size is 69777 bytes. Artifact ID is 14563061669
Artifact download URL: https://github.com/moq-dev/moq/actions/runs/44589689004/artifacts/14563061669
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__0c5c3004-f09e-4bce-adfb-43f26cb3481e.mbx]
##[end-action id=__0c5c3004-f09e-4bce-adfb-43f26cb3481e.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/aa7f1d60-7289-4eb2-9784-3a8cc8bc0e35' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 39 objects and 17 action results (931.5 MiB logical); 50.0 GiB logical remain
dropped 14 session event streams
evicted 0 objects and 0 action results (0 B logical); 50.0 GiB logical remain
Cleaning up orphan processes
(written by quest land watch) |
|
quest land watch: armed auto-merge on this pull request at 0dcfbd7, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix ( (written by quest land watch) |
There was a problem hiding this comment.
✅ No new issues found. Only one net change since the last review.
Reviewed changes
Since 18c4979, the branch merged main cleanly, and one cleanup commit landed:
- Removed the unused
Cover.emptygetter (js/net/src/cover.ts): nothing calls it. The one.emptyread nearby,producer.#account.emptyintrack.ts, is oncache.Track, not onCover.
claude-opus-5-5 | 𝕏
|
quest land watch: the merge queue removed this pull request at 0dcfbd7 because its The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.
…k: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/kio.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/use-case/contribution.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/use-case/conferencing.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-audio.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-auth.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-mux.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/moq-lite.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-json.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/cli.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/relay.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-video.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs/moq-net.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/ts.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/obs.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/prod.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed draft/qmux-websocket.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/py.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/redundancy.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/rtmp.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/rs.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/srt.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/repository.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/standard.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/studio.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/swift.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/stats.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/troubleshooting.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/transport.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed concept/use-case.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed setup/upgrade.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/webrtc.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/clock/test.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/publish/support/element.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/watch/support/element.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/hang/catalog.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/net/zod.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/signals/dom.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Generated �[36mllms-full.txt�[39m (~�[1m310.6K�[22m tokens, �[1m1.18 MB�[22m) with �[1m85�[22m markdown files
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/clock.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/auth.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/hang.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/clock.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/json.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/libav.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/hang/cmaf.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/auth.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/loc.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/hang/util.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/hang/container.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/json.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/hang.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/msf.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/net.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/obs.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/publish.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/pattern.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/publish/ui.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/publish/element.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/room.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/publish.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/net.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/signals.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/room.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/qmux.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/publish/support.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/stats.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/video.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/signals.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/watch.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/video.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/signals/react.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/watch.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/watch/support.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/watch/ui.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed lib/js/api/watch/element.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/relay/auth.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/relay/config.md
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m�[32m✓�[39m Processed bin/relay/cluster.md
moq-doc check: �[33m
moq-doc check: (!) Some chunks are larger than 500 kB after minification. Consider:
moq-doc check: - Using dynamic import() to code-split the application
moq-doc check: - Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
moq-doc check: - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.�[39m
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m �[1mvitepress-plugin-llms�[22m initialized �[2m(SSR build)�[22m with workDir: �[36m/var/cache/github-runner-work/moq/moq/doc�[39m
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m Build started, file collection cleared
moq-doc check: �[34mllmstxt�[39m�[2m » �[22m Skipping LLMs docs generation in SSR build
moq-doc check: �[32m✓�[0m building client + server bundles...
moq-doc check: - rendering pages...
moq-doc check: �[32m✓�[0m rendering pages...
moq-doc check: build complete in 76.41s.
error: recipe `check-changed` was terminated on line 36 by signal 15
##[endgroup]
ci: wall and CPU seconds per module
131 121 check rs (cancelled)
34 31 check biome
97 4 check js (cancelled)
108 69 check carla_bridge
1 0 check drill
3 2 check quest
19 16 check shell
0 0 check large_files (failed)
131 246 whole run
error: recipe `ci` failed on line 120 with exit code 128
##[error]ci: check large_files failed
##[error]Process completed with exit code 128.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
name: cargo-timings
path: target/cargo-timings/cargo-timing-*.html
if-no-files-found: ignore
retention-days: 14
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
BASE: 83c9fdd140f335a2a5ff1048c0370df5314b1986
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: cargo-timings.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 120805
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is c47d8c370ca6c0bf57ee63fb0f4f10a7f2a01c2c2ba6991086882e7957bbdf25
Finalizing artifact upload
Artifact cargo-timings successfully finalized. Artifact ID 14564404883
Artifact cargo-timings has been successfully uploaded! Final size is 120805 bytes. Artifact ID is 14564404883
Artifact download URL: https://github.com/moq-dev/moq/actions/runs/44595642452/artifacts/14564404883
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__c984c88b-4976-4dfb-8351-01437df5fc9d.mbx]
##[end-action id=__c984c88b-4976-4dfb-8351-01437df5fc9d.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/7b010d1a-0726-4e82-aa42-691e5bace31e' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 120 objects and 32 action results (357.4 MiB logical); 50.0 GiB logical remain
dropped 8 session event streams
Cleaning up orphan processes
(written by quest land watch) |
|
codex, gpt-6.1-sol, medium effort land fixer note:
(written by codex, gpt-6.1-sol, medium effort) |
|
quest land watch: re-enqueued this pull request at 0dcfbd7, at the back of the merge queue, unchanged, since the land fixer found the failure on the base too: (written by quest land watch) |
…riptions #9183 keys a copy's own subscription by the reader's keys rather than by position, and resolved_ranges now takes the keys to resolve. waiting_keys passes the reader's key straight through, and the new tests ask for key 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#9183 moved a relay front's held subscription and the JS publisher onto range edits by Range ID. The held subscription resumes and lends where it is asked whole, a re-asked reader copy with a new resume is asked whole, and the JS publisher recomputes frame starts from the live ranges on each edit while a Position is live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Finishes quest/m2/lite07-update-cost.md, the remainder of #9134. After #9134, the Rust publisher's plain path applies a lite-07 SUBSCRIBE_UPDATE as an edit by Range ID. This PR does the same in the other three places that still rebuilt everything, so an update that edits k of n ranges costs O(k log n):
model/resume.rs): a reader mirrors an edit into each route copy as an edit. Copies keep the reader's Range IDs. The held upstream subscription (origin.rs) folds each reader's edit into its demand incrementally, instead of re-folding every reader.Liveindex (model/track.rs): a reader's index of live groups inside its cover follows the cover's edits (Cover::moved/minus), instead of rescanning every cached group.js/net):combineSubscriptionsis gone. The producer's aggregates count each subscriber's ranges and scalars, so a change moves only what changed (cover.ts,ranges.ts,demand.ts). Preferences and theWindoware keyed by Range ID, and the lite-07 publisher applies an update through the internalhooks.editSubscriber.Impact
No public API or wire change. In Rust the edit entry points stay crate-private, and the public
updateis still a whole replacement. In JS the new entry points are internalhooks.*, and no exported type changes. No migration note.Validation
just checkpasses on the branch (Rust and JS, including the test inventory).-D warnings. moq-net-tests: 52/52.js/net:bun test, 3378 pass.edited_ranges_reach_every_copy_as_given_whole(a front's reader edited by key matches its ranges given whole);a_held_subscription_follows_each_edit_as_the_whole_fold;live_index_searches_match_a_scan_of_every_live_group, extended to cover replacements.ranges.test.ts: 50k random steps against the oldunion, plus everyCoverquery against a naive count.track.test.ts: 200 rounds of joins, updates, keyed edits, closes and fetches, checked against the oldcombineSubscriptionsfold.window.test.ts: 2000 rounds of random keyed edits checked against a freshWindow.keyed.Rust,
publisher_update(newrouted_edit{1,16}cells for a relay's front), per update:Liveindex, 50k cached groups, one editJS, new
just js bench publisher-update(added to the nightly JS benches), µs per update, best of 7:At 16 ranges, editing all 16 costs about 30% more: there a whole rebuild is cheaper than about 20 tree operations per edited range. The cost grows with the ranges edited, not the ranges held. I didn't add a small-n fallback path for it.
Local review (Codex) found four gaps, all fixed here:
watch_subscription).util/sorted.ts.servingResolvedKeys).Pullfrog found two more, fixed in 18c4979:
Weakkeeps the allocation, so the address stays unique while the entry exists. The check is gone. The intended cleanup does happen: the nextfollowafter a reader leaves drops its entry.a_held_subscription_follows_each_edit_as_the_whole_foldnow asserts one entry per reader still here, and fails whenretainkeeps every entry.Liveindex took in its cover twice (a diff against an empty cover, then the full arrival walk). With nothing taken in yet, it now adopts the cover and lets the arrival walk fill it.Decisions
Taken without the maintainer (AFK); each can be undone in review.
draft18_updates_narrow_then_widendepends on it).Editcarries no feed.Liveindex is kept per cursor across both theRunandRunscover shapes.Known limits
servingResolvedKeysbuilds its ranges once per publisher pass, and the edit materializes every range. That is O(n) per update, as before this PR, not O(k log n). Carrying keyed resolution throughresume.tswould make it match the Rust front.reportStartedstill loops over every added range whose start hasn't resolved, on each pass of the publisher loop. That is O(unresolved), not O(n), and unchanged in shape.Models
Size: M
Implementer: Claude, claude-opus-5-5, high effort
Implementer: Claude Code, claude-opus-5-5, high effort (iterate, M)
(Written by Claude Opus 5.5 with high)
🤖 Generated with Claude Code
Review
mechanical fix by codex, gpt-6.1-sol, medium effort:
Merged base cleanly and removed unused Cover.empty getter without changing behavior; ran git diff --check and nix develop --command just ci base (passed).(head 0dcfbd7)Rewritten by
quest reviewafter each round.Head: 18c4979
Base: origin/main at 1471225
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1f4a6-69af-7a23-b112-37e03d5c5678, round 3Score: 10/10,
The incremental changes safely remove redundant work, with no new correctness or lifecycle issues identified.Rounds: 9; first round 2 (high 1, medium 1); findings 3 (medium 3): fixed 3, refuted 0, open 0
Findings: none