Repository navigation
Conversation
#8918 made every received datagram carry a timestamp, unscaled at its sequence, but the interop tail still expected none from JS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It updates the stale interop assertions to match the post-#8918 behavior, where a scale-less datagram's timestamp is Timestamp.unscaled(sequence).
Reviewed changes
Reviewed the full diff. I also checked the assertions against js/net/src/time.ts and js/net/src/datagram.ts.
- JS tail subscriber: asserts
frame.timestamp.key === BigInt(sequence).keyisbigint | undefined, anddatagram.tssets a scale-less datagram's timestamp to its sequence, so the check is correct. - Rust tail subscriber: asserts
frame.timestamp == Timestamp::unscaled(sequence)in place ofscale().is_none(). This is stricter and matches the JS side. - Rust publisher comment: no longer says the datagram carries no timestamp.
claude-sonnet-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe Rust publisher comment now describes each datagram timestamp as unscaled and carried as the Merge Risk:
|

Problem
Scheduled Interop run 44353391853 fails
datagram rust -> js-native-nodeandrust -> js-native-bunon moq-transport-18:tail.ts:225expects a received datagram's timestamp to beundefined, but it isTimestamp.unscaled(0). Since #8918 a JS datagram always carries a timestamp, unscaled at its sequence on a scale-less track (datagram.ts), so the assertion is stale. Earlier scheduled runs failed before reaching this step, so this is persistent, not flaky.Approach
Timestamp::unscaled(sequence)instead of only an absent scale.Impact
Validation
main:just test interop --tail --publishers rust --subscribers js-native-node --versions moq-transport-18fails with the nightly'sunexpected IETF timestampfor node and bun.just test interop --tail --publishers rust --subscribers rust,js-native-node,js-native-bun --versions moq-transport-18passes, including all four datagram lanes (both directions, node and bun).just cipasses.Alternatives
Caused by
Follow-ups
None.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort
(Written by Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: ed872cf
Base: origin/main at 91dc634
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1f4ce-3f02-7312-a47d-6343cb16ca93, round 1Score: 10/10,
Both updated assertions match the subscriber implementations, correcting stale interop expectations without changing runtime behavior.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none