Skip to content

quest: plan the pre-cut lite-07 and hang-04 audit's fixes - #9249

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/lite07-hang-audit
Nov 20, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/lite07-hang-audit

Conversation

@kixelated

@kixelated kixelated commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Plans the fixes that a pre-cut audit of the lite-07 and hang-04 wire changes found. The goal is that before the main to release cut publishes them, no subscription, frame, or catalog entry means something different depending on which relay or reader serves it, and the frozen wire carries no field without a caller. All four quests join m2, so the cut waits on them.

Quest Size Milestone Why m2
No relative anchors: Min Age places a live join, filled from upstream L m2 lite-07-wip wire plus a Rust, JS, and binding API break
Group Streams carry each time once: no Previous Start, the first delta from Group Start, GROUP_END's end as a delta, SKIP for shortfalls, no timestamp on scale-less frames L m2 lite-07-wip wire
A scale-less track ages by arrival, and lite-05/06 stamp its group's start in both languages M m2 lite-07-wip expiry semantics, shipped with the cut
hang-04 text: entry versions bind only -04 readers; overrun durations move to moq-hls docs S m2 hang-04's published text

The two wire quests join lite-07 finalize's Required list, which names every quest that may still change lite-07 bytes. group-end-whole.md becomes group-times.md with a new goal. late-relative-join.md is deleted, and Latest readers now joins by Min Age instead of a relative range.

Closed, with the maintainer's pick: moq-dev/moq#9198 (relative starts on a copy; nothing left to resolve) and moq-dev/moq#9221 (the bare GROUP_END, reversed).

Decisions

From a 4-round interview with the maintainer. Each quest's Plan records its own decisions; the deleted late-relative-join.md goes with the relative anchors.

  • Goal: ✅ hold the cut for these (rejected: lite-07 only, hang text later; defer all to lite-08).
  • Relative range ends: ✅ remove relative anchors entirely, as starts and ends (rejected: relative starts only; ends reported in SUBSCRIBE_OK and STARTED, as A later reader's relative start on a partial lite-07 copy reads only its groups #9198's follow-up recommended; ends inferred from accounting).
  • Live join: ✅ no start anchor plus Subscriber Min Age, and a hop fills from upstream to reach it (rejected: a Live anchor type, proved or best-effort; the draft's "never fetches"). Recorded for review: an unstated Min Age means as far back as Max Age allows, and a relay counts "not stated" as the largest when it merges readers.
  • Scale-less tracks: ✅ Max Age by arrival only; lite-05/06 stamp the group's bare start in both languages (rejected: the send time; key gaps counted as milliseconds).
  • GROUP_END: ✅ an end, as a delta from the group's highest frame timestamp (rejected: a bare whole marker, feat(net)!: lite-07's GROUP_END says only that a group is whole #9221; main's absolute End relaxed to "at or above"; a delta from the last frame). This reverses 2026-11-19.
  • Previous Start: ✅ removed, with gaps covered by End (rejected: a Previous Gap; a group finished at its successor's start). ✅ A shortfall [End, next start) is always named with SUBSCRIBE_SKIP as a discontinuity.
  • Group Start: ✅ GROUP keeps it, and the first FRAME's delta counts from it; the maintainer left this to whatever reads better (rejected: frame 0 carrying the start; counting from the previous group's last frame).
  • Scale-less frames: ✅ no Timestamp Delta (rejected: their own timestamp; a delta that must be 0). moq-transport Object IDs can't ride as frame timestamps, so the ietf Object Record keeps Skip.
  • hang-04 text: ✅ fix the entry-version scope and move the overrun EXTINF recipe to moq-hls docs (rejected: version text only; moving the whole HLS section).
  • A later reader's relative start on a partial lite-07 copy reads only its groups #9198: ✅ close with a comment (rejected: keep it open until the removal lands).
  • feat(net)!: lite-07's GROUP_END says only that a group is whole #9221: ✅ close and rewrite its quest (rejected: rework its branch; merge, then redo).

Validation

quest check: all documents ok. No code changes.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: edd3e51

  • Base: origin/main at bc9ff0d

  • Risk: low, Only quest plans and their links change, so no consumer or peer behavior breaks, and a revert fully restores the prior plans.

  • Classified: low by Codex, gpt-6.1-sol, low effort, session 01a1fa7b-bfed-72f0-a2d0-e13b052eea9c

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1fa7b-d3e8-7bc2-b8b2-190c2bd266b8, round 1

  • Score: 10/10, The plans consistently record the revised decisions without changing runtime behavior, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Relative anchors leave lite-07 and Min Age places a live join; scale-less
tracks age by arrival; Group Streams carry each time once, with GROUP_END's
end back as a delta; and hang-04's text stops overpromising on entry
versions and HLS overruns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…relative-join

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 20, 2026 19:44
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0aef3b2e-11de-4b63-87e1-5a21a949e922
Commits

Reviewing files that changed from the base of the PR and between bc9ff0d and edd3e51.

Files selected for processing: 10

  • quest/m2/README.md
  • quest/m2/hang-04-text.md
  • quest/m2/lite07-finalize.md
  • quest/m2/time-addressing/group-end-whole.md
  • quest/m2/time-addressing/group-times.md
  • quest/m2/time-addressing/late-relative-join.md
  • quest/m2/time-addressing/no-relative-anchors.md
  • quest/m2/time-addressing/scale-less-arrival.md
  • quest/m3/groups-never-overlap.md
  • quest/m4/readers-range-live.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 20, 2026 19:45

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. The PR plans the pre-cut audit's fixes as m2 quests and ties them into the lite07-finalize Required list, so the cut waits on them.

Reviewed changes: all 10 changed files, which are quest documents only.

  • New quests: no-relative-anchors.md, group-times.md, scale-less-arrival.md, and hang-04-text.md, each with its decisions and rejected alternatives recorded.
  • Replaced quests: group-end-whole.md becomes group-times.md with the reversed GROUP_END decision. late-relative-join.md is deleted along with relative anchors.
  • Cross-links: m2/README.md, lite07-finalize.md, m3/groups-never-overlap.md, and m4/readers-range-live.md point at the new quests. No stale link to a deleted file remains in the diff.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit f7d858f Nov 20, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/lite07-hang-audit branch November 20, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant