Repository navigation
Conversation
Quest-Claim: d47838916c10fea2
A resumed reader whose range starts at a time below the serving copy's resume point started at a group key equal to that time. The serving copy's floor raised the start, and the window placed it there. Now the raised start stays unplaced: a backfill asked from the time places it at the group holding it, or, when the reader already has everything under the resume point, the start places at the time itself. A backfill takes what the reader's window hands out rather than its own floor. Exhaustion checks a kept-out gap across the whole window, not only under the resume point. JS passes a 0 floor to clamping instead of treating it as none. Both resume models learn the group holding a time start, with regressions for each case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…esume-time-below-floor
The Rust drop cursor panic and the JS ordered reader's missed group both reproduce on main and fail Nightly's resume model sweep on some seeds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes quest/m1/resume-time-below-floor.md and deletes it.
A resumed reader whose range starts at a time below the serving copy's resume point now starts at the group holding that time, in Rust (
rs/moq-net/src/model/resume.rs) and JS (js/net/src/resume.ts) alike. Before, it started at a group key equal to the time.Changes
unraisedis replaced byraised. The window keeps waiting, so it reads groups at or above the time meanwhile and hands out nothing below where the range will resolve.backfill_gapsasks a backfill from the raised time, below the resume point, and the backfill resolves the start at the group holding it, as the route would for a plain reader.backfillflag) takes what the reader's window hands out rather than raising its local range to its own floor.exhaustedchecked for a gap kept out by the local floor or cap only under the resume point. It now checks the whole window, so a read stays open when an earlier copy placed the window lower than the serving copy's own ranges start. The sweep found this, and it reproduces onmain.#wirepassedcopy.floor ? copy.floor : undefinedto clamping, which treated a copy resumed at group 0 as having no floor. It now passes the floor as is. This was JS-only, found by the sweep, and reproduces onmain.resume_model.rs,resume.model.test.ts) learn the group holding a time start: once an arrival reader's range first resolves, it owes from the newest group at or below the start that every live route holds. Each oracle gains the raised case and the exhaustion case as regressions, and JS also gains the 0 floor case.Public API: none. Wire: none.
Choices made without asking
ResumeReader.tlais unchanged. It models no time anchors and no local range, so neither the raised start nor a backfill's local floor exists in it, and its copies already admit from their own floors.Validation
mainand passing here:a_time_start_under_the_resume_point_reads_the_group_holding_itanda_backfill_places_a_time_start_its_serving_copy_raised.a backfill places a time start its serving copy raised, at the group holding it.mainwithmissing groups [6]. JS passes it onmain, because its cache path already resolves that case.mainin both languages withmissing groups [0].mainwithmissing groups 1; handed out 0,2.main(including fix(moq-net): a waiting time start reads its owed group first, and a fill past the live edge reaches subscriptions #9172):just rs test -p moq-net --features async --lib: 4130 passed.bun test ./js/net/src/: 3438 passed.main.just fixproduced no diff, andjust checkpassed.Pre-existing on
main(b4496b1), so not this PR's, each with a follow-up:MOQ_RESUME_SEED2, 8, 9, 11, 14 or 16 withMOQ_RESUME_CASES=4096 just test resume-model: panics withrange start is greater than range end in BTreeMapinDropCursor::next.MOQ_RESUME_SEED=10: an ordered reader misses group 0 after a range edit.Caused by
unraised.Follow-ups
Models
Size: L
Implementer: Claude, claude-opus-5-5, high effort
(Written by Claude Opus 5.5 with high effort)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: de04137, named in full once no reviewer reports a finding
Base: origin/main at cb9cb51
Risk: medium,
Changes to Rust and JS resume behavior could cause consumers to miss groups or stall during failover and range updates, while preserving public APIs and wire formats; a revert fully undoes the change.Classified: medium by Codex, gpt-6.1-sol, low effort, session
01a1fc72-4193-7ba2-9469-2b03ce0f32deReviewer: Codex, gpt-6.1-sol, xhigh effort
Session:
01a1fc72-57cb-7621-8a98-83bb6ea7f436, round 1Score: 5/10,
The head needs rework because relative-end resolution, delayed backfill retention, and skipped-range completion can leave bounded reads pending indefinitely.Rounds: 1; first round 3 (medium 3); findings 3 (medium 3): fixed 0, refuted 0, open 3
Findings, open until the next round settles them:
rs/moq-net/src/model/resume.rs:1883:Preserve the serving copy's relative end when backfilling a startrs/moq-net/src/model/resume.rs:939:Apply the below-floor exception to backfill retentionrs/moq-net/src/model/resume.rs:2630:Exclude settled skips from the out-of-bounds gap check