Repository navigation
fix(net): a time start under the resume point reads the group holding it #9278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kixelated
wants to merge
10
commits into
main
Choose a base branch
from
quest/m1/resume-time-below-floor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,225
−101
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0743cec
chore(quest): claim quest/m1/resume-time-below-floor.md
kixelated 8d990cd
fix(net): a time start under the resume point reads the group holding it
kixelated 343df69
Merge branch 'main' of https://github.com/moq-dev/moq into quest/m1/r…
kixelated de04137
quest: plan the resume model sweep failures found on main
kixelated c5a5127
fix(net): a raised start keeps its relative end, its backfill, and si…
kixelated 7bed524
fix(net): a resumed read's kept-out gaps are judged per range
kixelated 4998fdc
fix(net): keep main's exhaustion check, and plan its rewrite as a fol…
kixelated 477bb30
fix(net): a raised start keeps a relative end placed while its copy's…
kixelated f69af4d
fix(net): a backfill's groups wait for the window, and a front forwar…
kixelated da2eeb1
fix(net): a backfill's group waits only when no placed range holds it
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Record placement before freezing clean-end coverage.
If a range starts at time 7 and resolves to group 6,
#endCleancan run beforeplace(). It recordscarriedwithholding === undefined, so it excludes group 6. Later,owed()uses the expanded range but filters it through that earliercarriedset. The model can therefore accept a clean end that omitted group 6.Record the holding group before the clean-end snapshot. Keep groups completed after that snapshot excluded.