Skip to content

Pullfrog reviews have what their checks need - #779

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/pullfrog-setup
Nov 19, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/pullfrog-setup

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/pullfrog-setup.md: deletes it.

Summary

Pullfrog's Claude credential reset, so I re-dispatched one run per repository on main (prompt: run just check and just test, report failures, missing tools or variables, and the time of the steps before the agent). All four runs reached the agent and finished.

Repository Run Nix installer PATH step just check / just test
moq-dev/studio 44473168965 6 s 113 s bare: fail at --features cargo steps (PKG_CONFIG_PATH unset); through nix develop: pass
moq-dev/web-transport 44473177222 8 s 77 s bare check: fails building boring-sys (LIBCLANG_PATH, LD_LIBRARY_PATH unset); through nix develop: both pass (959 s, 733 s)
moq-dev/quest 44473181103 9 s 209 s check passes (9 s); test fails only on 26 systemd-scope tests, since the agent's sandboxed shell has no user bus
kixel-ai/rust2 44473173364 9 s 191 s on main both select only lint (1 s); --all needs RUST2_TS_TOOLCHAIN and NIX_LDFLAGS, and passes inside nix develop

No tool is missing: quest, just, Rust, and the rest of each dev shell's tools are on PATH. What the agents hit is the limit the quest already recorded: Pullfrog's shell keeps PATH but not other dev-shell variables, so nix develop --command is the way to anything needing them, and it works in every repository.

Decisions

  • ✅ Tell agents to run just through nix develop --command where the bare shell lacks variables (rejected: exporting the dev shell's variables through GITHUB_ENV, since the quest's Plan records Pullfrog's shell dropping them, it can only be tried after merging to main because the pullfrog environment admits only main, and nix develop already passes in every repository). Opened moq-dev/studio#210 and kixel-ai/rust2#872, one AGENTS.md line each; web-transport's AGENTS.md already says it.
  • ✅ Leave the quest repository's own just test systemd failures alone (rejected: a REVIEW.md or prompt edit, which would need a quest eval run and is outside this quest). They are sandbox-only and CI runs the full suite; the reviewer's runs found just check passes and the failing files.
  • ✅ Finish the quest, since no tool or variable is missing before the agent starts. The setup steps took 6 to 9 s (Nix installer) and 77 to 209 s (PATH step) in these runs.

Validation

just check and just test pass; quest check --base origin/main passes. The four runs above are the evidence.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, high effort (iterate, XS, arm A)

(Written by Claude Sonnet 5.5 with high effort)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: b8da0d4

  • Base: origin/main at 00c72eb

  • Risk: low, Deleting a plan under quest/ changes nothing users, customers, or other repositories rely on, and a revert fully restores it.

  • Classified: low by Codex, gpt-6.1-sol, low effort, session 01a1f2c3-9f59-7a62-a0f3-22cc9e16bfa8

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f2c3-b1d9-7ec1-80c1-76ac0a066679, round 1

  • Score: 10/10, The change only removes a completed quest document, with no remaining references or executable code changes and no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1f2c3-b1d3-73f3-9466-4c653b5ef514, round 1

  • Score: 10/10, The change only removes the completed Pullfrog setup quest, with no remaining references or executable behavior changes, so it is ready to land as is.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 17, 2026 16:33
Quest-Claim: d1dbd275aa19470a
…l reset

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…cks pass

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 19, 2026 07:45
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aaf718f6-18c3-4d7c-8e6a-36db257e302b
Commits

Reviewing files that changed from the base of the PR and between 00c72eb and b8da0d4.

Files selected for processing: 1

  • quest/m0/pullfrog-setup.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 19, 2026 07:45

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the full diff, a single deleted file.

  • Delete quest/m0/pullfrog-setup.md — removes the finished quest document. All its remaining and waiting items are covered by the PR's recorded runs, and no references to it remain in the repository.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit ec9e581 Nov 19, 2026
17 checks passed
@kixelated
kixelated deleted the quest/m0/pullfrog-setup branch November 19, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant