Skip to content

docs(agents): run just through nix develop outside the dev shell - #210

Merged
kixelated merged 2 commits into
mainfrom
docs/pullfrog-nix-develop
Nov 19, 2026
Merged

kixelated merged 2 commits into
mainfrom
docs/pullfrog-nix-develop

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Pullfrog's dispatched run on main (see moq-dev/quest#779) found just check and just test fail in its job. The "Put the dev shell's tools on PATH" step in .github/workflows/pullfrog.yml exports the dev shell's PATH but not its variables (PKG_CONFIG_PATH, NIX_LDFLAGS, ...), so builds that link system libraries cannot find them. Run through nix develop --command, they pass.

Approach

One line in AGENTS.md, beside "Run just ci before every push": outside the dev shell, such as in Pullfrog's job, run just as nix develop --command just ....

Impact

  • Agent instructions only. No user-visible change, no public API or wire impact.

Alternatives

  • Export the dev shell's variables too, not just PATH, in the workflow step. Rejected: the step comes from the shared Pullfrog workflow standard (dotfiles' repo-settings), not this repo, and handing the agent more of the shell's environment widens what that hardened step sets up; nix develop --command gives the exact dev shell on demand.
  • Fold this into the existing nix develop --command quest ... line. Kept separate: quest is missing from PATH entirely outside the dev shell, a different failure, and that line sits with the quest instructions agents read first.

Follow-ups

None.

Validation

  • nix print-dev-env --json lists PKG_CONFIG_PATH, NIX_LDFLAGS, NIX_CFLAGS_COMPILE, and LIBCLANG_PATH among the shell's variables, so the named examples are real.
  • Reproduced the failure mode the line describes: with only the dev shell's /nix/store PATH entries (as the workflow step builds it) in a clean env, pkg-config --exists libpipewire-0.3 exits 1; nix develop --command pkg-config --exists libpipewire-0.3 exits 0.
  • Docs only; no other behavior to exercise.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, high effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: bc8852f

  • Base: origin/main at 5ae83b0

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f475-3b5c-7e81-9ceb-5a7c954e96c6, round 1

  • Score: 10/10, The documentation-only change correctly directs commands through the development shell so library-discovery variables are available, with no actionable defects found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1f475-3b5c-7202-bd20-ab24119e4692, round 1

  • Score: 10/10, The focused documentation change matches the repository's Nix development environment and introduces no identifiable defect.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 849fe7a8-c60b-4bb0-a184-7a1bd614b69a
Commits

Reviewing files that changed from the base of the PR and between bc8852f and ad8dff6.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

AGENTS.md adds guidance to run just through nix develop --command when required environment variables, such as PKG_CONFIG_PATH or NIX_LDFLAGS, are unavailable outside the development shell.

Merge Risk: Minimal · previous review bc885

This documentation-only change tells agents running outside the dev shell to use nix develop --command for just. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the docs change to AGENTS.md: running just through nix develop --command outside the dev shell. The raw summary says the single-line AGENTS.md addition covers exactly this guidance, so…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains a docs-only change to AGENTS.md. It gives the problem, the approach, the impact, alternatives, and validation steps. It matches the changeset, so the check passes.
Full details: Title check

Explanation

The title names the docs change to AGENTS.md: running just through nix develop --command outside the dev shell. The raw summary says the single-line AGENTS.md addition covers exactly this guidance, so the title matches the main change. It uses a conventional docs(agents) prefix, which is acceptable.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4dc2d6f8-0d5d-49c5-81f3-5ad23a7d806e
Commits

Reviewing files that changed from the base of the PR and between c104a26 and bc8852f.

Files selected for processing: 1

  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: a one-line docs addition to AGENTS.md telling agents to run just through nix develop --command outside the dev shell. No behavioral surface.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated enabled auto-merge (squash) November 19, 2026 21:04
@kixelated
kixelated merged commit db7aa7c into main Nov 19, 2026
3 checks passed
@kixelated
kixelated deleted the docs/pullfrog-nix-develop branch November 19, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant