Repository navigation
chore(deps): update kio requirement from 0.5.4 to 0.6.2 in the cargo group across 1 directory #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6846530
chore(deps): update kio requirement
dependabot[bot] 2054a0a
Merge remote-tracking branch 'origin/main' into dependabot/cargo/carg…
kixelated 2016398
fix(quiche): box the open_bi header state for kio 0.6
kixelated 7421c75
Merge main into dependabot/cargo/cargo-bbdd180c4b
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the nominal type accepted by the public
SessionAccept::poll_accept_uniandpoll_accept_bimethods (rs/web-transport-iroh/src/session.rs:570and:650-653) fromkio0.5'sWaiterto the semver-incompatible 0.6 type. Because the iroh crate does not re-exportkio, a downstream poll-based consumer must depend on it directly; after an otherwise compatible web-transport-iroh update, Cargo can retain its 0.5 dependency alongside this new 0.6 dependency and the waiter argument will no longer type-check. Thechore(deps)commit metadata normally requests only a patch release, and the configured semver checker does not detect changed parameter types, so this upgrade needs breaking-change metadata or insulation of the public API before release.AGENTS.md reference: AGENTS.md:L61-L62
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining the iroh part of this.
poll_accept_uniandpoll_accept_biare methods onH3SessionAccept, which is a private struct (struct H3SessionAcceptinrs/web-transport-iroh/src/session.rs). Downstream code can't reach them. In web-transport-iroh,kioshows up only in private code, so the kio bump doesn't change its public API.The broader point is fair for quiche, quinn, and noq. They
pub use kio;and take&kio::Waiterin their publicSessionAcceptpoll methods, so moving to kio 0.6 is semver-visible there. The PR description already notes this. Per the maintainer's direction, this PR doesn't touch versions or release metadata, and the bump is settled when the release-plz release PR is reviewed. I'll flag your point that cargo-semver-checks may not catch a changed foreign type, so that review should confirm a minor bump for those three crates.(Written by Claude Opus 5.5)