Skip to content

chore(deps): update kio requirement from 0.5.4 to 0.6.2 in the cargo group across 1 directory - #415

Merged
kixelated merged 4 commits into
mainfrom
dependabot/cargo/cargo-bbdd180c4b
Oct 14, 2026
Merged

kixelated merged 4 commits into
mainfrom
dependabot/cargo/cargo-bbdd180c4b

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This bumps kio from 0.5.4 to 0.6.2 in the iroh, noq, quiche, and quinn backends. It also adapts web-transport-quiche to kio's larger Waiter.

Why clippy failed

kio 0.6 added a parked: [AtomicU64; 8] registration record (64 bytes) to Waiter, which made Park bigger. Every ez::SendStream and ez::RecvStream holds a Parked, so both streams grew too. OpenBi::Header holds one of each, which pushed it to 264 bytes or more. That's past clippy's large_enum_variant threshold, and Idle carries nothing. OpenUni::Header holds only one stream, so it stays under the threshold.

Changes

  • Merged main into the branch (no conflicts).
  • rs/web-transport-quiche/src/connection.rs: OpenBi::Header now holds a Box<OpenBiHeader>, so the idle state that every session clone carries stays small. The async Connection::open_bi path is unchanged and doesn't allocate. The extra allocation happens only on the poll::Session::poll_open_bi path, once per opened stream, next to the Arcs that opening a stream already creates.

kio 0.6 API impact on other backends

kio 0.6.0 removed kio::time, kio::tokio, Deadline, and Sleep, and added Task/Tasks and Unused. No crate in this workspace uses the removed items. The Waiter, Park, Fan, WaiterList, and wait APIs that the backends rely on are source-compatible. just check and just test pass locally on 0.6.2.

Public API / wire compatibility

None on the wire. OpenBi is private. kio is re-exported from quiche, quinn, and noq, so moving to 0.6 is a semver-visible change for anyone who names kio types through those re-exports. release-plz will pick that up.

Decisions

These were made by an unattended agent, which took the recommended option each time.

How should the large_enum_variant failure be resolved?

  • ✅ Box the OpenBi::Header payload (recommended: fixes it where the size lives, and the allocation only hits the poll-trait path)
  • Box only recv, as clippy suggests (asymmetric, and saves the same amount)
  • #[allow(clippy::large_enum_variant)] (hides the size cost from every session clone)
  • Shrink ez streams by boxing their Parked (adds an allocation for every AsyncRead/AsyncWrite user, which is a wider change)

Rebase or merge main?

  • ✅ Merge (recommended: no force-push over dependabot's commit; dependabot stops rebasing either way once someone else pushes)
  • Rebase and force-push

Add a size regression test?

  • ✅ No (recommended: the CI clippy step already enforces the threshold, and a byte-count assertion would be an arbitrary acceptance criterion)
  • Add a size_of::<OpenBi>() assertion

Follow-ups

  • Consider whether kio's Waiter should keep its 64-byte parked record inline. It now adds about 64 bytes to every parked stream handle in each backend.

Original dependabot description

Updates the requirements on kio to permit the latest version.
Updates kio to 0.6.2

Release notes

Sourced from kio's releases.

libmoq v0.6.2

What's Changed

Full Changelog: moq-dev/moq@libmoq-v0.6.1...libmoq-v0.6.2

Commits

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Oct 3, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8a55422

[P1] Adapt the quiche state size alongside the kio upgrade — rs/web-transport-quiche/Cargo.toml:29. The new requirement resolves to kio 0.6.2 in this PR's CI; its larger Waiter/Park is embedded in the stream handles, making OpenBi::Header at rs/web-transport-quiche/src/connection.rs:112–120 at least 264 bytes. Consequently cargo clippy --workspace --all-targets --all-features -- -D warnings fails with clippy::large_enum_variant, and the test step is skipped. Reduce the enum's inline payload (for example, box the Header state) or explicitly justify a targeted lint allowance, then rerun check and tests. Evidence: https://github.com/moq-dev/web-transport/actions/runs/37141051942/job/111255390277

Direction: updating all four backends together is sensible, but the dependency-only change is incomplete until this integration blocker is addressed.

Verification: inspected the complete four-file diff, relevant waiter/stream code, upstream kio changelog and waiter layout, and current CI logs. CI's workspace/all-targets/all-features cargo check passed; Clippy failed; tests did not run. No local build or runtime tests performed.

@dependabot dependabot Bot changed the title chore(deps): update kio requirement from 0.5.4 to 0.6.1 in the cargo group chore(deps): update kio requirement from 0.5.4 to 0.6.2 in the cargo group across 1 directory Oct 7, 2026
@dependabot
dependabot Bot force-pushed the dependabot/cargo/cargo-bbdd180c4b branch from 8a55422 to 89f72fc Compare October 7, 2026 18:55
Updates the requirements on [kio](https://github.com/moq-dev/moq) to permit the latest version.

Updates `kio` to 0.6.2
- [Release notes](https://github.com/moq-dev/moq/releases)
- [Commits](moq-dev/moq@kio-v0.5.4...kio-v0.6.2)

---
updated-dependencies:
- dependency-name: kio
  dependency-version: 0.6.1
  dependency-type: direct:production
  dependency-group: cargo
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/cargo-bbdd180c4b branch from 89f72fc to 6846530 Compare October 9, 2026 20:43
kixelated and others added 2 commits October 14, 2026 14:43
kio 0.6 added a 64-byte registration record to Waiter, so every
ez::SendStream and ez::RecvStream (each carrying a Parked) grew. That
pushed OpenBi::Header past clippy's large_enum_variant threshold. Box the
stream pair so idle session clones stay small.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T22:58:54.792336Z 7421c75 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2016398684

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

http = "1"
iroh = { version = "1", default-features = false, features = ["fast-apple-datapath"] }
kio = "0.5.4"
kio = "0.6.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Mark the public kio upgrade as breaking

This changes the nominal type accepted by the public SessionAccept::poll_accept_uni and poll_accept_bi methods (rs/web-transport-iroh/src/session.rs:570 and :650-653) from kio 0.5's Waiter to the semver-incompatible 0.6 type. Because the iroh crate does not re-export kio, a downstream poll-based consumer must depend on it directly; after an otherwise compatible web-transport-iroh update, Cargo can retain its 0.5 dependency alongside this new 0.6 dependency and the waiter argument will no longer type-check. The chore(deps) commit metadata normally requests only a patch release, and the configured semver checker does not detect changed parameter types, so this upgrade needs breaking-change metadata or insulation of the public API before release.

AGENTS.md reference: AGENTS.md:L61-L62

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declining the iroh part of this. poll_accept_uni and poll_accept_bi are methods on H3SessionAccept, which is a private struct (struct H3SessionAccept in rs/web-transport-iroh/src/session.rs). Downstream code can't reach them. In web-transport-iroh, kio shows up only in private code, so the kio bump doesn't change its public API.

The broader point is fair for quiche, quinn, and noq. They pub use kio; and take &kio::Waiter in their public SessionAccept poll methods, so moving to kio 0.6 is semver-visible there. The PR description already notes this. Per the maintainer's direction, this PR doesn't touch versions or release metadata, and the bump is settled when the release-plz release PR is reviewed. I'll flag your point that cargo-semver-checks may not catch a changed foreign type, so that review should confirm a minor bump for those three crates.

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator

Merge summary

This bumps kio from 0.5.4 to 0.6.2 in web-transport-iroh, -noq, -quiche, and -quinn.

Changes

  • Dependency requirement bumped in all four backends.
  • rs/web-transport-quiche/src/connection.rs: OpenBi::Header holds a Box<OpenBiHeader>, so clippy's large_enum_variant passes with kio 0.6's larger Waiter. The extra allocation happens only on the poll_open_bi path, once per opened stream.
  • Merged the latest main (chore: release #418 release, quest: plan the WebSocket follow-ups from #426 #429 quests). There were no conflicts.

Decisions (see the PR description for the alternatives)

  • Box the OpenBi::Header payload instead of using #[allow] or shrinking the ez streams.
  • Merge main instead of rebasing over dependabot's commit.
  • No size regression test. The CI clippy step already enforces the threshold.

Reviews

  • The original automated review's P1 (the clippy large_enum_variant failure) is fixed by the boxing commit.
  • Codex P1 on the new head ("mark the kio upgrade as breaking"): I declined the iroh part, because the poll methods it cites are on a private type. I acknowledged the broader point in the thread.

Compatibility

  • Wire: no change.
  • Public API: web-transport-quiche, -quinn, and -noq re-export kio (pub use kio;) and take &kio::Waiter in their public poll APIs, so moving to kio 0.6 changes their public API surface. This PR doesn't bump versions. release-plz and cargo-semver-checks will choose the next bump. cargo-semver-checks may not detect a changed foreign type, so whoever reviews the release PR should confirm that those three crates get a minor bump. web-transport-iroh uses kio only privately.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 14, 2026 22:57
@kixelated
kixelated merged commit c2e93e4 into main Oct 14, 2026
1 check passed
@kixelated
kixelated deleted the dependabot/cargo/cargo-bbdd180c4b branch October 14, 2026 23:14
This was referenced Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant