Repository navigation
chore(deps): update kio requirement from 0.5.4 to 0.6.2 in the cargo group across 1 directory - #415
Conversation
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8a55422
[P1] Adapt the quiche state size alongside the kio upgrade — rs/web-transport-quiche/Cargo.toml:29. The new requirement resolves to kio 0.6.2 in this PR's CI; its larger Waiter/Park is embedded in the stream handles, making OpenBi::Header at rs/web-transport-quiche/src/connection.rs:112–120 at least 264 bytes. Consequently cargo clippy --workspace --all-targets --all-features -- -D warnings fails with clippy::large_enum_variant, and the test step is skipped. Reduce the enum's inline payload (for example, box the Header state) or explicitly justify a targeted lint allowance, then rerun check and tests. Evidence: https://github.com/moq-dev/web-transport/actions/runs/37141051942/job/111255390277
Direction: updating all four backends together is sensible, but the dependency-only change is incomplete until this integration blocker is addressed.
Verification: inspected the complete four-file diff, relevant waiter/stream code, upstream kio changelog and waiter layout, and current CI logs. CI's workspace/all-targets/all-features cargo check passed; Clippy failed; tests did not run. No local build or runtime tests performed.
8a55422 to
89f72fc
Compare
Updates the requirements on [kio](https://github.com/moq-dev/moq) to permit the latest version. Updates `kio` to 0.6.2 - [Release notes](https://github.com/moq-dev/moq/releases) - [Commits](moq-dev/moq@kio-v0.5.4...kio-v0.6.2) --- updated-dependencies: - dependency-name: kio dependency-version: 0.6.1 dependency-type: direct:production dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
89f72fc to
6846530
Compare
kio 0.6 added a 64-byte registration record to Waiter, so every ez::SendStream and ez::RecvStream (each carrying a Parked) grew. That pushed OpenBi::Header past clippy's large_enum_variant threshold. Box the stream pair so idle session clones stay small. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2016398684
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| http = "1" | ||
| iroh = { version = "1", default-features = false, features = ["fast-apple-datapath"] } | ||
| kio = "0.5.4" | ||
| kio = "0.6.2" |
There was a problem hiding this comment.
Mark the public kio upgrade as breaking
This changes the nominal type accepted by the public SessionAccept::poll_accept_uni and poll_accept_bi methods (rs/web-transport-iroh/src/session.rs:570 and :650-653) from kio 0.5's Waiter to the semver-incompatible 0.6 type. Because the iroh crate does not re-export kio, a downstream poll-based consumer must depend on it directly; after an otherwise compatible web-transport-iroh update, Cargo can retain its 0.5 dependency alongside this new 0.6 dependency and the waiter argument will no longer type-check. The chore(deps) commit metadata normally requests only a patch release, and the configured semver checker does not detect changed parameter types, so this upgrade needs breaking-change metadata or insulation of the public API before release.
AGENTS.md reference: AGENTS.md:L61-L62
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Declining the iroh part of this. poll_accept_uni and poll_accept_bi are methods on H3SessionAccept, which is a private struct (struct H3SessionAccept in rs/web-transport-iroh/src/session.rs). Downstream code can't reach them. In web-transport-iroh, kio shows up only in private code, so the kio bump doesn't change its public API.
The broader point is fair for quiche, quinn, and noq. They pub use kio; and take &kio::Waiter in their public SessionAccept poll methods, so moving to kio 0.6 is semver-visible there. The PR description already notes this. Per the maintainer's direction, this PR doesn't touch versions or release metadata, and the bump is settled when the release-plz release PR is reviewed. I'll flag your point that cargo-semver-checks may not catch a changed foreign type, so that review should confirm a minor bump for those three crates.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge summaryThis bumps Changes
Decisions (see the PR description for the alternatives)
Reviews
Compatibility
(Written by Claude Opus 5.5) |
Summary
This bumps
kiofrom 0.5.4 to 0.6.2 in the iroh, noq, quiche, and quinn backends. It also adapts web-transport-quiche to kio's largerWaiter.Why clippy failed
kio 0.6 added a
parked: [AtomicU64; 8]registration record (64 bytes) toWaiter, which madeParkbigger. Everyez::SendStreamandez::RecvStreamholds aParked, so both streams grew too.OpenBi::Headerholds one of each, which pushed it to 264 bytes or more. That's past clippy'slarge_enum_variantthreshold, andIdlecarries nothing.OpenUni::Headerholds only one stream, so it stays under the threshold.Changes
maininto the branch (no conflicts).rs/web-transport-quiche/src/connection.rs:OpenBi::Headernow holds aBox<OpenBiHeader>, so the idle state that every session clone carries stays small. The asyncConnection::open_bipath is unchanged and doesn't allocate. The extra allocation happens only on thepoll::Session::poll_open_bipath, once per opened stream, next to theArcs that opening a stream already creates.kio 0.6 API impact on other backends
kio 0.6.0 removed
kio::time,kio::tokio,Deadline, andSleep, and addedTask/TasksandUnused. No crate in this workspace uses the removed items. TheWaiter,Park,Fan,WaiterList, andwaitAPIs that the backends rely on are source-compatible.just checkandjust testpass locally on 0.6.2.Public API / wire compatibility
None on the wire.
OpenBiis private.kiois re-exported from quiche, quinn, and noq, so moving to 0.6 is a semver-visible change for anyone who nameskiotypes through those re-exports. release-plz will pick that up.Decisions
These were made by an unattended agent, which took the recommended option each time.
How should the
large_enum_variantfailure be resolved?OpenBi::Headerpayload (recommended: fixes it where the size lives, and the allocation only hits the poll-trait path)recv, as clippy suggests (asymmetric, and saves the same amount)#[allow(clippy::large_enum_variant)](hides the size cost from every session clone)ezstreams by boxing theirParked(adds an allocation for everyAsyncRead/AsyncWriteuser, which is a wider change)Rebase or merge
main?Add a size regression test?
size_of::<OpenBi>()assertionFollow-ups
Waitershould keep its 64-byteparkedrecord inline. It now adds about 64 bytes to every parked stream handle in each backend.Original dependabot description
Updates the requirements on kio to permit the latest version.
Updates
kioto 0.6.2Release notes
Sourced from kio's releases.
Commits
2b58fcbfeat(audio): backend seams, surround layouts, and AAC encode (audio-codecs li...4033bfachore: release (#4320)19cfa9bchore(deps): bump urllib3 from 2.7.0 to 2.8.0 (#4593)603b973quest(m1): split cluster routing into child quests (#4592)a0309f6chore(tooling): thin justfiles and CI that calls them (#4038)6dc9ec7quest(m1): plan #4456, #4508, #4581, #4582 (#4587)a42a56dfeat(lite): moq-lite-07 switches to 64-bit leading-ones varints (#4455)cead1bdquest(m1): drop the retired TS import shared shift (#4583)146769equest: apply the 2026-09-30 audit (#4589)3e7313aquest(m2): plan a Windows.Graphics.Capture backend (#4586)🤖 Generated with Claude Code
(Written by Claude Opus 5.5)