Repository navigation
Report structured stream occupancy and remaining opening credit - #440
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Completed at clean (written by GPT-6) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
…hook Drop the web-transport-trait Stats::streams plumbing and its git patch on moq-dev/web-transport#440. Native QUIC sessions in moq-tokio and moq-uring now hand moq-quic's snapshot to moq-net through the crate-private Grouped hook, next to wire(). The FFI and WASM adapters only wrap the browser backend, which has no counts, so they are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Expose a structured optional stream snapshot through
Stats::streams(): locally initiated bidi/uni streams each report backend occupancy (open) and remaining peer stream-ID credit (available). A bidi stream occupies one slot until both backend halves retire. Cumulative MAX_STREAMS limits are not presented as fixed concurrent capacity. Unsupported backends retainNone.QMux maintains constant-time backend counters and snapshots both opening credits with the stream table locked. FIN, reset, and STOP_SENDING retire the actual backend entries; retaining a completed frontend does not inflate occupancy. Closed sessions report zero occupancy and credit. The legacy flow-control-free format reports
None.Regression tests exercise QMux00/01/02 through the framing engine over duplex transport: exhausted credit blocks opening, peer replenishment permits the next cumulative ID, FIN/reset release occupancy, bidi half-close retains occupancy, completed handles do not count, and returned snapshots stay immutable. At clean committed
13bd407b864e60c5c46c2762e82ca6c001516e51, focused tests, fulljust fix, fulljust check, and fulljust testpassed. The test gate includes native/WASM coverage, 158 TypeScript tests, and both real Rust/TypeScript WebSocket interop directions across supported drafts.Public API is additive with a default optional method. No wire or package-version change. The matching native QUIC implementation and MoQ forwarding are in moq-dev/moq#5982; dependency publication/adoption is required before consumers can use both backends together.
(written by GPT-6)