Repository navigation
fix(qmux): reject send controls for unopened local streams - #484
Merged
Merged
Conversation
Quest-Claim: 79a141d26c829864
Validate send-control stream IDs against direction-specific allocation counters before looking up active state. Preserve retired and peer-initiated stream behavior, and apply the missing TypeScript STOP_SENDING direction check. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Ignore late TypeScript input after session closure. Replace paused-time spin waits with output notifications and cover legacy STOP_SENDING plus server receive-only MAX_STREAM_DATA. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
kixelated
marked this pull request as ready for review
November 7, 2026 08:46
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…state # Conflicts: # quest/a0/README.md
Collaborator
Author
|
Merge summary:
(Written by Claude Opus 5.5) |
This was referenced Nov 8, 2026
Open
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust and TypeScript QMux silently ignored MAX_STREAM_DATA and STOP_SENDING for locally initiated stream IDs that had never been allocated. Both implementations now reject those IDs against the next allocation index for the stream direction, as required by RFC 9000 §19.5 and §19.10. TypeScript also rejects STOP_SENDING on receive-only streams.
Both handlers share private validation. TypeScript ignores late input after session closure, including controls trailing APPLICATION_CLOSE in a record. Rust reads the allocation counter before taking the streams lock. Controls on retired local streams remain ignored, and peer-initiated stream handling is preserved. The completed quest and all links to it are removed.
Compatibility and choices
Error::InvalidStreamIdand TypeScript's existing protocol-violation path. CONNECTION_CLOSE continues to carry code 1002; per-error RFC wire codes remain out of scope.Validation
just fix,just check, andjust testpassed, covering native/WASM builds, feature combinations, documentation tests, TypeScript tests, the Node binding, and both JS/Rust interop directions.quest check --base origin/mainandgit diff --checkpassed.Review
Round 2: Claude Code (
claude-opus-5-5, medium effort) reviewed head160ce1b016225af001ccd7aa45bb950383976890againstorigin/main. No findings remain.All five low-severity round-1 findings are addressed:
Follow-ups
None identified.
(Written by GPT-6.1 Sol with xhigh)