Skip to content

chore(qmux): release @moq/qmux 0.3.5 - #542

Merged
kixelated merged 2 commits into
mainfrom
quest/a0/qmux-js-release
Nov 15, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/a0/qmux-js-release

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Bumps @moq/qmux to 0.3.5. Merging this publishes main's js/qmux to npm through release-js.yml, carrying #516: cancelling a receive stream returns its connection credit, so browsers on the WebSocket fallback no longer stall once a connection window of cancelled group data piles up.

Finishes quest/a0/qmux-js-release.md and removes its links from quest/a0/qmux-05-recv-credit.md. qmux 0.5.4 is not on crates.io yet (latest 0.5.x is 0.5.3), so that quest stays.

Release notes

  • Fix: cancelling an incoming stream credits its unread bytes back to the connection flow-control window (#516).
  • Behavior change: a cancelled incoming stream keeps its stream-count slot until the peer sends FIN or RESET_STREAM, as RFC 9000 requires. A peer that leaves stopped streams idle can exhaust the incoming stream limit (100 by default). moq-relay resets its group streams promptly; checking the relay's other streams end to end belongs to moq-dev/moq's release-line bump.
  • Stricter frame validation (#483, #484) that qmux 0.5.x peers never trigger.

Audit

  • Earlier audit (in the quest's Plan, 2026-11-14): js/qmux from 0.3.4's 337787c through d0072fd (#451, #483, #484, #501, #505, #516) found no blockers. Interop passed against main's Rust and against qmux 0.5.3.
  • This PR's audit: git log d0072fd..origin/main -- js/qmux is empty, so nothing new landed. js/web-socket-stream changed since 0.3.4 only through a dev-dependency bump (#505), so the published ^0.1.1 dependency is still accurate.
  • One correction to the earlier audit: it said "the type declarations are identical to 0.3.4". In the built package, index.d.ts and every declaration reachable from it are byte-identical, but the internal credit.d.ts (increaseMax now returns void) and recv.d.ts (doc comment) differ. The exports map exposes only ., so consumers can't import them, and the public types are unchanged.

Public API and wire impact

No public API change: the exported declarations match 0.3.4. No wire change beyond the receive-credit and validation behavior described above. Version bump only.

Validation

  • bun install --frozen-lockfile, bun run check (root and every package): pass.
  • js/qmux: 318 unit tests pass; bun run test:interop (2 tests, against main's Rust qmux interop example) passes.
  • bun run build in js/qmux: publint passes, dist/package.json is version 0.3.5 with @moq/web-socket-stream: ^0.1.1.
  • Diffed the built dist/ against npm pack @moq/qmux@0.3.4: same file list and package.json apart from the version; declaration diffs as described in Audit.
  • Imported the built dist/index.js under Node: Session, install, selectSubprotocol, SessionError, StreamError all load.
  • Not run locally: the Rust half of just check. This change touches no Rust, and the Fedora host's boring-sys bindgen failure ("stdlib.h not found") is a known, pre-existing host problem; CI covers it.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm B)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: c124ca1

  • Base: origin/main at 56688bd

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1ddd2-c35e-7c61-b4db-0ce8dadc2113, round 1

  • Score: 10/10, The version bump matches the lockfile and existing release workflow, and the quest cleanup removes its cross-references; no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1ddd2-c35f-7402-8b24-e26f638f8bd5, round 1

  • Score: 10/10, The focused release change consistently bumps @moq/qmux to 0.3.5 and removes the completed release plan and its references, with no actionable defects found by inspection; checks were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 14, 2026 22:07
Ships main's js/qmux, carrying #516's receive-credit fix, and finishes
quest/a0/qmux-js-release.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Release @moq/qmux 0.3.5 with the receive-credit fix chore(qmux): release @moq/qmux 0.3.5 Nov 15, 2026
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 06:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T06:10:18.844716Z c124ca1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full 4-file diff of the @moq/qmux 0.3.5 release PR.

  • Version bump: js/qmux/package.json and bun.lock both move to 0.3.5 and agree with each other.
  • Quest cleanup: quest/a0/qmux-js-release.md is deleted, and its two links are removed from quest/a0/qmux-05-recv-credit.md. A repo-wide grep finds no remaining references to the deleted file.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The @moq/qmux package version changes from 0.3.4 to 0.3.5. The release-planning quest is deleted, and references to that release are removed from the receive-credit quest.

Merge Risk: Minimal · up to c124c

This is a version bump for the @moq/qmux release plus removal of release-planning notes. It does not change runtime behavior, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore(qmux): release @moq/qmux 0.3.5" names the main change: the version bump of @moq/qmux to 0.3.5 for npm publication. The raw summary confirms the only package change is the version fiel…
Description check Passed The description states the purpose of the PR: bumping @moq/qmux to 0.3.5 and publishing js/qmux via release-js.yml. It also covers the carried fix (#516), release notes, audit, and validation. This re…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(qmux): release @moq/qmux 0.3.5" names the main change: the version bump of @moq/qmux to 0.3.5 for npm publication. The raw summary confirms the only package change is the version field in js/qmux/package.json, and the objectives describe the same release purpose. The title is short and specific, with no file lists or vague terms.

Full details: Description check

Explanation

The description states the purpose of the PR: bumping @moq/qmux to 0.3.5 and publishing js/qmux via release-js.yml. It also covers the carried fix (#516), release notes, audit, and validation. This relates directly to the changeset, which bumps the package version and removes the release quest document.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bd9fbf90-98de-4caf-900e-039d310ab03e
Commits

Reviewing files that changed from the base of the PR and between 56688bd and c124ca1.

Files ignored due to path filters: 1

  • bun.lock is excluded by !**/*.lock
Files selected for processing: 3

  • js/qmux/package.json
  • quest/a0/qmux-05-recv-credit.md
  • quest/a0/qmux-js-release.md
Files with no reviewable changes: 2

  • quest/a0/qmux-05-recv-credit.md
  • quest/a0/qmux-js-release.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@kixelated
kixelated enabled auto-merge (squash) November 15, 2026 06:13
@kixelated
kixelated merged commit dc9324b into main Nov 15, 2026
9 checks passed
@kixelated
kixelated deleted the quest/a0/qmux-js-release branch November 15, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant