Skip to content

fix(baseline): Document the hook's dependabot allowance and test a Copilot request with no login - #48

Merged
mpaulosky merged 3 commits into
mainfrom
fix/40-review-findings
Nov 11, 2026
Merged

mpaulosky merged 3 commits into
mainfrom
fix/40-review-findings

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Why

Issue #40 lists findings from the pre-push review of TicketManager's re-Apply. R11 was already fixed by #41; R19 and R7 were not.

What changed

  • docs/PROCESS.md (Owned): says the pre-push hook also allows shell-safe dependabot/* names, and which names the Branch name check allows (R19).
  • pr-automerge.test.mjs (Owned): two review-request events with no reviewer login are not taken for Copilot's (R7). The code already handled them; this adds coverage.

Rollout: both are Owned files, so they reach the Fleet by a Rollout (rollout.sh), not by themselves.

Verification

scripts/gate.sh (with GATE_SKIP_REVIEW=1) passes; node --test on pr-automerge.test.mjs passes (403). Local pre-push review: 3 rounds, 2 Advisory findings, both fixed.

Fixes #40

🤖 Generated with Claude Code

mpaulosky and others added 3 commits November 11, 2026 07:48
…request with no login (#40)

R11 was fixed by #41. This documents the hook's dependabot/* allowance in PROCESS.md (R19)
and tests that a review request with no reviewer login is not taken for Copilot's (R7).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…CESS.md (#40)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ROCESS.md (#40)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the branch-name documentation clarifications and reviewer-login regression tests.

No open issues 🎉

What changed in this PR

This PR clarifies existing Baseline branch-name rules and adds regression coverage for review requests without a reviewer login. It changes documentation and tests only; both Owned files reach the Fleet through a Rollout.

Changes:

  • Documents the pre-push hook’s shell-safe Dependabot allowance and the broader exceptions accepted by the Branch name check.
  • Adds missing-login and null-login cases to verify those review requests are not treated as Copilot requests.
File Description
.claude/​skills/​repo-ci-baseline/​template/​owned/​docs/​PROCESS.md Clarifies branch-name allowances for hooks and CI.
.claude/​skills/​repo-ci-baseline/​template/​owned/​.github/​scripts/​tests/​pr-automerge.test.mjs Adds two regression cases for reviewer identities without a login.

Review effort: Balanced

@mpaulosky
mpaulosky enabled auto-merge (squash) November 11, 2026 16:09
@mpaulosky
mpaulosky merged commit 5b69f61 into main Nov 11, 2026
9 checks passed
@mpaulosky
mpaulosky deleted the fix/40-review-findings branch November 11, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(baseline): Fix the findings from the pre-push review of TicketManager's re-Apply

2 participants