Repository navigation
fix(baseline): Document the hook's dependabot allowance and test a Copilot request with no login - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the branch-name documentation clarifications and reviewer-login regression tests.
No open issues 🎉
What changed in this PR
This PR clarifies existing Baseline branch-name rules and adds regression coverage for review requests without a reviewer login. It changes documentation and tests only; both Owned files reach the Fleet through a Rollout.
Changes:
- Documents the pre-push hook’s shell-safe Dependabot allowance and the broader exceptions accepted by the Branch name check.
- Adds missing-login and null-login cases to verify those review requests are not treated as Copilot requests.
| File | Description |
|---|---|
.claude/skills/repo-ci-baseline/template/owned/docs/PROCESS.md |
Clarifies branch-name allowances for hooks and CI. |
.claude/skills/repo-ci-baseline/template/owned/.github/scripts/tests/pr-automerge.test.mjs |
Adds two regression cases for reviewer identities without a login. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #40 lists findings from the pre-push review of TicketManager's re-Apply. R11 was already fixed by #41; R19 and R7 were not.
What changed
docs/PROCESS.md(Owned): says the pre-push hook also allows shell-safedependabot/*names, and which names the Branch name check allows (R19).pr-automerge.test.mjs(Owned): two review-request events with no reviewer login are not taken for Copilot's (R7). The code already handled them; this adds coverage.Rollout: both are Owned files, so they reach the Fleet by a Rollout (
rollout.sh), not by themselves.Verification
scripts/gate.sh(withGATE_SKIP_REVIEW=1) passes;node --testonpr-automerge.test.mjspasses (403). Local pre-push review: 3 rounds, 2 Advisory findings, both fixed.Fixes #40
🤖 Generated with Claude Code