Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5163,7 +5163,9 @@ const copilotRequestedAt = (at, reviewer = { login: "Copilot", type: "Bot" }) =>
test("a request for a copilot-x user or team does not save an add that PR Auto-Merge removed (mpaulosky/Application_Factory#22)", async () => {
for (const event of [
{ event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { login: "copilot-x", type: "User" }, actor: { login: "ruleset" } },
{ event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_team: { name: "copilot-team" }, actor: { login: "ruleset" } }
{ event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_team: { name: "copilot-team" }, actor: { login: "ruleset" } },
{ event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { type: "Bot" }, actor: { login: "ruleset" } },
{ event: "review_requested", created_at: "2026-01-02T00:30:03Z", requested_reviewer: { login: null, type: "Bot" }, actor: { login: "ruleset" } }
]) {
const result = await evaluate(documentedLoop({ reviewRequests: COPILOT_PENDING }), [addedBy(OWNER), event, removedByActions("2026-01-02T00:30:05Z")]);
assert.equal(result.merges.length, 1, result.logs.join("\n"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ The folder is the branch name with `/` turned into `-`. Remove the worktree once
| `chore/{slug}` | Work without an issue |

`{slug}` is lowercase letters and digits in words joined by `-` (`upgrade-net10`, `oauth2-login`). A `chore/` slug
starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses any other name, and so does the
required **Branch name** check, which also catches a push that skipped the hook (a Claude cloud session's `claude/...`
branch, GitHub's web editor). To fix one, rename the branch on GitHub, then close and reopen the PR.
starts with a letter, so `chore/7-cleanup` is refused. The pre-push hook refuses any other name, except a shell-safe `dependabot/*` name, which it
allows so a person can push a fix to a Dependabot PR. The required **Branch name** check allows the same names, plus any
`dependabot/*` whatever its characters and the `docs/release-notes` and `docs/backfill-blog-posts` branches the release
workflows create. It refuses everything else, so it catches a push that skipped the hook (a Claude cloud session's
`claude/...` branch, GitHub's web editor). To fix a refused name, rename the branch on GitHub, then close and reopen the PR.

## Commits and PR titles

Expand Down
Loading