Skip to content

revert: open Bun WebSockets with permessage-deflate again (#623) - #635

Merged
klNuno merged 1 commit into
mainfrom
revert/bun-websocket-deflate
Oct 19, 2026
Merged

klNuno merged 1 commit into
mainfrom
revert/bun-websocket-deflate

Conversation

@klNuno

@klNuno klNuno commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Note

Clanker Claude Opus 5.5 is responding on behalf of meetsu

What changed

Bun WebSocket clients negotiate permessage-deflate again: #623 did not stop the 1002 closes it targeted, and it costs up to 13 times the bytes at boot between cores.

Verification

Affected paths

  • Desktop and phone
  • Each affected driver: Claude, ACP, Codex, Muse, pi, agy, echo
  • Both transports: the real core and lib/fake-client.ts
  • Reverse actions: archive, uninstall, unsubscribe, shutdown
  • Windows and Linux
  • Contract first: the domain file in packages/contracts/src/
  • Documentation

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: beboite/boite/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8bbabbe2-0a3a-481c-af60-e1b366fff950
📥 Commits

Reviewing files that changed from the base of the PR and between 18aa29c and a7099bd.

📒 Files selected for processing: 7
  • packages/core/src/browser/cdp.ts
  • packages/core/src/client.ts
  • packages/core/src/group/relay.ts
  • packages/core/test/browser/fixture.ts
  • packages/core/test/socket-options.test.ts
  • tests/e2e/group-devices.test.ts
  • tests/e2e/lib/cdp.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@klNuno
klNuno marked this pull request as ready for review October 19, 2026 05:51
@github-actions github-actions Bot added the core packages/core and packages/contracts label Oct 19, 2026
@klNuno
klNuno merged commit dc6416e into main Oct 19, 2026
62 of 67 checks passed
@klNuno
klNuno deleted the revert/bun-websocket-deflate branch October 19, 2026 07:05
klNuno added a commit that referenced this pull request Oct 19, 2026
The contacts experiment joins EXPERIMENT_IDS in contracts, where #609 moved
the list. The contact link offers permessage-deflate again, as every Bun
socket does since #635 reverted SOCKET_OPTIONS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core packages/core and packages/contracts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant