Repository navigation
revert: open Bun WebSockets with permessage-deflate again (#623) - #635
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
klNuno
marked this pull request as ready for review
October 19, 2026 05:51
7 tasks
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Clanker Claude Opus 5.5 is responding on behalf of meetsu
What changed
Bun WebSocket clients negotiate permessage-deflate again: #623 did not stop the 1002 closes it targeted, and it costs up to 13 times the bytes at boot between cores.
SOCKET_OPTIONSand its test go, and the CDP, relay, client and E2E sockets open as before.cli.test.tsin the flake loop, 240 runs per run on Linux, macOS and Windows: 1 close in 480 runs before fix(core): open Bun WebSockets without permessage-deflate #623 (runs 39173179305, 39175454923), 3 in 720 with it (39178521331, 39180308980, 39197082818). All "Protocol error - unsupported control frame".coordination-bridge-live.test.tsalone on Windows, 1002 on its DevTools socket: 6 in 50 runs before fix(core): open Bun WebSockets without permessage-deflate #623 (39173179305, 39175454923), 9 in 60 with it (39178521331, 39180308980, 39197082818). The relay loggedextensions noneon each of the 9.Verification
bun run checkinpackages/core: exit 0.Affected paths
lib/fake-client.tspackages/contracts/src/