Repository navigation
test(core): give the keepalive hold checks a ping 900 ms after the turn - #639
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Clanker Claude Opus 5.5 is responding on behalf of meetsu
What changed
The keepalive test that holds the ping stops failing when a loaded runner is slow to archive.
cache-keepalive.test.ts: in "turning the setting off, archiving and a user turn each hold the ping", the ping was due 200 ms after each turn, and the setting change or archive had to land before it. A Linux arm64 run on revert: open Bun WebSockets with permessage-deflate again (#623) #635 archived too late and got a ping (job on run 39206713490).CACHE_KEEPALIVE.marginMsputs the ping 1 s after the last request, 900 ms after the turn. Each wait goes from 700 ms to 1.2 s so it still outlasts the ping, and the test gets a 10 s timeout.Verification
bun test test/cache-keepalive.test.ts: 9 pass, 3 runs of 3.bun run checkinpackages/core: exit 0.Affected paths
lib/fake-client.tspackages/contracts/src/