Skip to content

test(core): give the keepalive hold checks a ping 900 ms after the turn - #639

Merged
klNuno merged 1 commit into
mainfrom
fix/keepalive-hold-margin
Oct 19, 2026
Merged

klNuno merged 1 commit into
mainfrom
fix/keepalive-hold-margin

Conversation

@klNuno

@klNuno klNuno commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Note

Clanker Claude Opus 5.5 is responding on behalf of meetsu

What changed

The keepalive test that holds the ping stops failing when a loaded runner is slow to archive.

  • cache-keepalive.test.ts: in "turning the setting off, archiving and a user turn each hold the ping", the ping was due 200 ms after each turn, and the setting change or archive had to land before it. A Linux arm64 run on revert: open Bun WebSockets with permessage-deflate again (#623) #635 archived too late and got a ping (job on run 39206713490).
  • For that test only, CACHE_KEEPALIVE.marginMs puts the ping 1 s after the last request, 900 ms after the turn. Each wait goes from 700 ms to 1.2 s so it still outlasts the ping, and the test gets a 10 s timeout.
  • The assertions are unchanged.

Verification

  • A 300 ms pause before the archive: the old test fails, the new one passes.
  • The archive removed: the new test fails on the archive check (line 246).
  • bun test test/cache-keepalive.test.ts: 9 pass, 3 runs of 3.
  • bun run check in packages/core: exit 0.
  • Not verified: a loop on the Linux arm64 runner.

Affected paths

  • Desktop and phone
  • Each affected driver: Claude, ACP, Codex, Muse, pi, agy, echo
  • Both transports: the real core and lib/fake-client.ts
  • Reverse actions: archive, uninstall, unsubscribe, shutdown
  • Windows and Linux
  • Contract first: the domain file in packages/contracts/src/
  • Documentation

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: beboite/boite/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e6200f6b-8b44-4963-876b-82df2dd0fb26
📥 Commits

Reviewing files that changed from the base of the PR and between 891c964 and 4c9a05f.

📒 Files selected for processing: 1
  • packages/core/test/cache-keepalive.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@klNuno
klNuno marked this pull request as ready for review October 19, 2026 06:50
@github-actions github-actions Bot added the core packages/core and packages/contracts label Oct 19, 2026
@klNuno
klNuno merged commit 0d7c3ab into main Oct 19, 2026
33 of 43 checks passed
@klNuno
klNuno deleted the fix/keepalive-hold-margin branch October 19, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core packages/core and packages/contracts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant